{"id":117,"url":"https://patchwork.libcamera.org/api/patches/117/?format=json","web_url":"https://patchwork.libcamera.org/patch/117/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190101212328.18361-2-laurent.pinchart@ideasonboard.com>","date":"2019-01-01T21:23:26","name":"[libcamera-devel,2/4] libcamera: mediadevice: Make getEntityByName() public","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b5dad6e904cacff8efae324563daaf22cc4dd785","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/117/mbox/","series":[{"id":45,"url":"https://patchwork.libcamera.org/api/series/45/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=45","date":"2019-01-01T21:23:26","name":"[libcamera-devel,1/4] libcamera: mediadevice: Fix graph parsing error handling","version":1,"mbox":"https://patchwork.libcamera.org/series/45/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/117/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/117/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A112860B33\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  1 Jan 2019 22:22:33 +0100 (CET)","from avalon.bb.dnainternet.fi\n\t(dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E02A3B81\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  1 Jan 2019 22:22:32 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1546377753;\n\tbh=Hw51POc7lSFpsCxFBLrFbyuQ3V0AtVZ2yuRFvdHOmHU=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=gCC3Gf1VHRskugqnCRwpbDMSEu9jBhibIBufwpFoFb8bhtGxGBarihAkhXPj1lM6a\n\t83tmOcPVinnW95rDq+soGWmizs6CX0XdD4FK/wrfrmKqWzsrqVZYpHExXAaQNQwO5A\n\tQTUVcfsNGlJ0rmr6frmDPaL4flHqaqKLpPfrNRmw=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Tue,  1 Jan 2019 23:23:26 +0200","Message-Id":"<20190101212328.18361-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.19.2","In-Reply-To":"<20190101212328.18361-1-laurent.pinchart@ideasonboard.com>","References":"<20190101212328.18361-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/4] libcamera: mediadevice: Make\n\tgetEntityByName() public","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 01 Jan 2019 21:22:34 -0000"},"content":"The function is useful as a public API, make it public.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/include/media_device.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/include/media_device.h b/src/libcamera/include/media_device.h\nindex 74a67c81398a..fd1e12d1bbcb 100644\n--- a/src/libcamera/include/media_device.h\n+++ b/src/libcamera/include/media_device.h\n@@ -32,7 +32,9 @@ public:\n \n \tconst std::string driver() const { return driver_; }\n \tconst std::string devnode() const { return devnode_; }\n+\n \tconst std::vector<MediaEntity *> &entities() const { return entities_; }\n+\tMediaEntity *getEntityByName(const std::string &name);\n \n private:\n \tstd::string driver_;\n@@ -46,7 +48,6 @@ private:\n \tvoid clear();\n \n \tstd::vector<MediaEntity *> entities_;\n-\tMediaEntity *getEntityByName(const std::string &name);\n \n \tbool populateEntities(const struct media_v2_topology &topology);\n \tbool populatePads(const struct media_v2_topology &topology);\n","prefixes":["libcamera-devel","2/4"]}