{"id":11696,"url":"https://patchwork.libcamera.org/api/patches/11696/?format=json","web_url":"https://patchwork.libcamera.org/patch/11696/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210324150125.1318325-3-kieran.bingham@ideasonboard.com>","date":"2021-03-24T15:01:21","name":"[libcamera-devel,v3,2/6] utils: ipc: proxy: Process pending messages","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a1cf3716cc7907c1ed370f001cb752f6a9cfd5df","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11696/mbox/","series":[{"id":1828,"url":"https://patchwork.libcamera.org/api/series/1828/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1828","date":"2021-03-24T15:01:19","name":"IPU3 Stability","version":3,"mbox":"https://patchwork.libcamera.org/series/1828/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11696/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11696/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 716A6C32E5\n\tfor ;\n\tWed, 24 Mar 2021 15:01:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F16F468D68;\n\tWed, 24 Mar 2021 16:01:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC077602E3\n\tfor ;\n\tWed, 24 Mar 2021 16:01:31 +0100 (CET)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 54E02580;\n\tWed, 24 Mar 2021 16:01:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DIrws9G+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616598091;\n\tbh=k3gnrktnFtKlTIoS3bCPGXMoxEuZ9o1+XOAkKRXQAFg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DIrws9G+ODMbA424AA9iLv1QvZJqXzQRDcuGBaulU22fxuFE90mCaR+iVeuotmJ1f\n\tKXortHFN0bR4j0ZvZTIwW0NA4lzmUM4bq1ScZKw9Ze8NNOHJev4LAMGwfx3cHFJ0BS\n\tdN2DlfB8OnEVAW4w0Tp8T/b+KJAp2RRgNSpk0JEs=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 24 Mar 2021 15:01:21 +0000","Message-Id":"<20210324150125.1318325-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210324150125.1318325-1-kieran.bingham@ideasonboard.com>","References":"<20210324150125.1318325-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 2/6] utils: ipc: proxy: Process pending\n\tmessages","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Laurent Pinchart \n\nEvents may be queued to the pipeline handler between the pipeline\nhandler entering the ::stop() function, and before the call to stop the\nIPA has completed.\n\nHandle these events by dispatching all pending messages at the proxy\nafter the IPA has fully stopped.\n\nReviewed-by: Jacopo Mondi \nSigned-off-by: Laurent Pinchart \nSigned-off-by: Kieran Bingham \n---\n utils/ipc/generators/libcamera_templates/proxy_functions.tmpl | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\nindex 13dc8fdcab6e..8addc2fad0a8 100644\n--- a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n+++ b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n@@ -31,6 +31,8 @@\n \tthread_.exit();\n \tthread_.wait();\n \n+\tThread::current()->dispatchMessages(Message::Type::InvokeMessage);\n+\n \trunning_ = false;\n {%- endmacro -%}\n \n","prefixes":["libcamera-devel","v3","2/6"]}