{"id":11695,"url":"https://patchwork.libcamera.org/api/patches/11695/?format=json","web_url":"https://patchwork.libcamera.org/patch/11695/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210324150125.1318325-2-kieran.bingham@ideasonboard.com>","date":"2021-03-24T15:01:20","name":"[libcamera-devel,v3,1/6] utils: ipc: proxy: Assert asynchronous calls execute in the running state","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9da43a8143feab014afccca71af60baccaee7fd9","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11695/mbox/","series":[{"id":1828,"url":"https://patchwork.libcamera.org/api/series/1828/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1828","date":"2021-03-24T15:01:19","name":"IPU3 Stability","version":3,"mbox":"https://patchwork.libcamera.org/series/1828/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11695/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11695/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1D3CC32E5\n\tfor ;\n\tWed, 24 Mar 2021 15:01:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1893A602E3;\n\tWed, 24 Mar 2021 16:01:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 64AF5602E3\n\tfor ;\n\tWed, 24 Mar 2021 16:01:31 +0100 (CET)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BADFE8F3;\n\tWed, 24 Mar 2021 16:01:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WyKf+r6r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616598091;\n\tbh=vQKpfhkgfbyPBUPGapP8weKWmKAw3k6l5cBEmmYLjSc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=WyKf+r6r1cOKuGrB0R3pjqau6zpBOMuzP6L28L6pHTMEkjlPVvFK9k0GDKzjTHeBe\n\tkYmt2MZMkIsxRevhW/A2/3UyEd5iO02Jlet0IiWKiB4HRI2sdmRGmE/3Qgp9QetK63\n\tfMOpaABXfB+YS/qXDs6lR+rzAz4GOYRCWuoKjNMo=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 24 Mar 2021 15:01:20 +0000","Message-Id":"<20210324150125.1318325-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210324150125.1318325-1-kieran.bingham@ideasonboard.com>","References":"<20210324150125.1318325-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 1/6] utils: ipc: proxy: Assert\n\tasynchronous calls execute in the running state","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Laurent Pinchart \n\nSignals and calls from the IPA should not occur after the IPA has been\nput into the stopped state.\n\nAdd assertions to catch and prevent any messages being processed after\nthis.\n\nReviewed-by: Niklas Söderlund \nReviewed-by: Jacopo Mondi \nSigned-off-by: Laurent Pinchart \nSigned-off-by: Kieran Bingham \n---\n .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 2 ++\n utils/ipc/generators/libcamera_templates/proxy_functions.tmpl | 4 ++--\n 2 files changed, 4 insertions(+), 2 deletions(-)","diff":"diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\nindex f75b1206cad4..e3b541db4e36 100644\n--- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n+++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n@@ -173,6 +173,7 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n \t{%- endfor -%}\n );\n {% elif method|is_async %}\n+\tASSERT(running_);\n \tproxy_.invokeMethod(&ThreadProxy::{{method.mojom_name}}, ConnectionTypeQueued,\n \t{%- for param in method|method_param_names -%}\n \t\t{{param}}{{- \", \" if not loop.last}}\n@@ -225,6 +226,7 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n {% for method in interface_event.methods %}\n {{proxy_funcs.func_sig(proxy_name, method, \"Thread\")}}\n {\n+\tASSERT(running_);\n \t{{method.mojom_name}}.emit({{method.parameters|params_comma_sep}});\n }\n \ndiff --git a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\nindex c2ac42fca45b..13dc8fdcab6e 100644\n--- a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n+++ b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n@@ -26,12 +26,12 @@\n \tif (!running_)\n \t\treturn;\n \n-\trunning_ = false;\n-\n \tproxy_.invokeMethod(&ThreadProxy::stop, ConnectionTypeBlocking);\n \n \tthread_.exit();\n \tthread_.wait();\n+\n+\trunning_ = false;\n {%- endmacro -%}\n \n \n","prefixes":["libcamera-devel","v3","1/6"]}