[{"id":16143,"web_url":"https://patchwork.libcamera.org/comment/16143/","msgid":"","date":"2021-04-07T10:29:49","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: raspberrypi: Make CamHelper\n\texposure methods virtual","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for your patch.\n\nOn Wed, 24 Mar 2021 at 11:44, David Plowman \nwrote:\n\n> This allows derived classes to override them if they have any special\n> behaviours to implement. For instance if a particular camera mode\n> produces a different signal level to other modes, you might choose to\n> address that in the gain or exposure methods.\n>\n> Signed-off-by: David Plowman \n>\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> src/ipa/raspberrypi/cam_helper.hpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/ipa/raspberrypi/cam_helper.hpp\n> b/src/ipa/raspberrypi/cam_helper.hpp\n> index 1b2d6eec..4053a870 100644\n> --- a/src/ipa/raspberrypi/cam_helper.hpp\n> +++ b/src/ipa/raspberrypi/cam_helper.hpp\n> @@ -66,8 +66,8 @@ public:\n> virtual ~CamHelper();\n> void SetCameraMode(const CameraMode &mode);\n> MdParser &Parser() const { return *parser_; }\n> - uint32_t ExposureLines(double exposure_us) const;\n> - double Exposure(uint32_t exposure_lines) const; // in us\n> + virtual uint32_t ExposureLines(double exposure_us) const;\n> + virtual double Exposure(uint32_t exposure_lines) const; // in us\n> virtual uint32_t GetVBlanking(double &exposure_us, double\n> minFrameDuration,\n> double maxFrameDuration) const;\n> virtual uint32_t GainCode(double gain) const = 0;\n> --\n> 2.20.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FDC4BD1F6\n\tfor ;\n\tWed, 7 Apr 2021 10:30:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E9C7E60518;\n\tWed, 7 Apr 2021 12:30:07 +0200 (CEST)","from mail-lj1-x233.google.com (mail-lj1-x233.google.com\n\t[IPv6:2a00:1450:4864:20::233])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2391B602CC\n\tfor ;\n\tWed, 7 Apr 2021 12:30:06 +0200 (CEST)","by mail-lj1-x233.google.com with SMTP id u20so19989024lja.13\n\tfor ;\n\tWed, 07 Apr 2021 03:30:05 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"XK+IxNk6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=KqEiS10deNHJvJYu2oUGgozOCg49tychuWKpLnUR35I=;\n\tb=XK+IxNk6AuZP1a/ZroP4C+E8s35++fugFLVe22x84IRuX9ju9BRtINCMFg2Sfp1qzz\n\tGGsbuywqcZs5F6fT4GUALH92bUIuYjsHYN0SjxvRnMv3U0mJmEGtif7to/Z1PacK4d5H\n\tIjUgF8725OT1R4PMJtVppK+5X6hgDQfxiLaJxak6VTox8BqcOUFT9ogKdTpcKsONCG4F\n\tW7MfJCEFUKO43HXsT/EavAveA5Xs8+ROnJCfRdIPSJhTTXy2Ot34dhjw3Fj6mIo5YQu2\n\tPqCcnoo3a++K4SRpr/jJrYTTCHSaZLbJj3dwEbGaf+xRr2ublT597XieiOAmNi6ntWiO\n\t4eqg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=KqEiS10deNHJvJYu2oUGgozOCg49tychuWKpLnUR35I=;\n\tb=i2xBGAL34x6GQeDbWURq/kKh/tuDfBTu8iLXxpXHonkVIFdD0cgqfAMIY2piy/Mrs7\n\tdNoRjW+oQDqj8PU6kCRhL4twGNlRevJsgGn/H0Ok8hffuH0a+mSzJp8E4H/LIi76A53S\n\tT+nja/OPUATvGzu0usqLhTn00b/kVvru9zXkQxAExHb905oWDM3a8FLYWJSCWrivxNWw\n\tJqNS0kWlPLH8FaDHCAYDg6w7eApPg6Lw5rVULCg2hZasL8beAGf7wbk3UWsxdHE1rNdZ\n\tp07rTN8n7HldgEa5CQV/HaD20ydaWW8Vw86VGf8Yz0cq5CuJtr7i44EJHTxAgah/y3U2\n\tAulQ==","X-Gm-Message-State":"AOAM530PjBZGASzQHPUxbo7bBnh8fkBKw+Z6qCBWv6lqOXCIdptJ+v9C\n\tSOWzgbx5ZKCa132smS2O7ZDzJilAEqeBWEG59pwUmg==","X-Google-Smtp-Source":"ABdhPJyPLmaI88096aSXvObsfCEuVJJhUFeNk6Hx8y9VIjEXLMX3DH8MruB2hX/pZtWOyglrICiTPl1r9R+yDBmWnkY=","X-Received":"by 2002:a2e:5315:: with SMTP id\n\th21mr1648854ljb.299.1617791405362; \n\tWed, 07 Apr 2021 03:30:05 -0700 (PDT)","MIME-Version":"1.0","References":"<20210324114415.19866-1-david.plowman@raspberrypi.com>\n\t<20210324114415.19866-2-david.plowman@raspberrypi.com>","In-Reply-To":"<20210324114415.19866-2-david.plowman@raspberrypi.com>","From":"Naushir Patuck ","Date":"Wed, 7 Apr 2021 11:29:49 +0100","Message-ID":"","To":"David Plowman ","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: raspberrypi: Make CamHelper\n\texposure methods virtual","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============4571768318444043298==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]