[{"id":15907,"web_url":"https://patchwork.libcamera.org/comment/15907/","msgid":"","date":"2021-03-25T22:36:40","subject":"Re: [libcamera-devel] [PATCH 5/7] android: camera_hal_manager: Use\n\tCameraHalConfig","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2021-03-24 12:25:25 +0100, Jacopo Mondi wrote:\n> Signed-off-by: Jacopo Mondi \n\nWith a commit message added, something simple as,\n\n Store the HAL configuration in the camera manager.\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_hal_manager.cpp | 6 +++++-\n> src/android/camera_hal_manager.h | 3 +++\n> 2 files changed, 8 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\n> index aeff14bdc14f..a19f80edede8 100644\n> --- a/src/android/camera_hal_manager.cpp\n> +++ b/src/android/camera_hal_manager.cpp\n> @@ -47,13 +47,17 @@ CameraHalManager::~CameraHalManager()\n> \n> int CameraHalManager::init()\n> {\n> +\tint ret = halConfig_.open();\n> +\tif (ret)\n> +\t\treturn ret;\n> +\n> \tcameraManager_ = new CameraManager();\n> \n> \t/* Support camera hotplug. */\n> \tcameraManager_->cameraAdded.connect(this, &CameraHalManager::cameraAdded);\n> \tcameraManager_->cameraRemoved.connect(this, &CameraHalManager::cameraRemoved);\n> \n> -\tint ret = cameraManager_->start();\n> +\tret = cameraManager_->start();\n> \tif (ret) {\n> \t\tLOG(HAL, Error) << \"Failed to start camera manager: \"\n> \t\t\t\t<< strerror(-ret);\n> diff --git a/src/android/camera_hal_manager.h b/src/android/camera_hal_manager.h\n> index 24bf716c9f9d..cb333293a441 100644\n> --- a/src/android/camera_hal_manager.h\n> +++ b/src/android/camera_hal_manager.h\n> @@ -19,6 +19,8 @@\n> \n> #include \n> \n> +#include \"camera_hal_config.h\"\n> +\n> class CameraDevice;\n> \n> class CameraHalManager\n> @@ -50,6 +52,7 @@ private:\n> \tCameraDevice *cameraDeviceFromHalId(unsigned int id);\n> \n> \tlibcamera::CameraManager *cameraManager_;\n> +\tCameraHalConfig halConfig_;\n> \n> \tconst camera_module_callbacks_t *callbacks_;\n> \tstd::vector> cameras_;\n> -- \n> 2.30.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3600BDC66\n\tfor ;\n\tThu, 25 Mar 2021 22:36:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F86768D65;\n\tThu, 25 Mar 2021 23:36:47 +0100 (CET)","from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com\n\t[IPv6:2a00:1450:4864:20::12a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4707A603FE\n\tfor ;\n\tThu, 25 Mar 2021 23:36:46 +0100 (CET)","by mail-lf1-x12a.google.com with SMTP id n138so4871794lfa.3\n\tfor ;\n\tThu, 25 Mar 2021 15:36:46 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ts22sm927068ljd.28.2021.03.25.15.36.40\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 25 Mar 2021 15:36:40 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"F+/xWn5P\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=I4oReFLY9kFzsFCTh3BxIQA6s9Y2DHaoeeNTPDXpM8s=;\n\tb=F+/xWn5PMrmnwuzVQJAovu8z6NqUHzfauY4qZ5xpKDM8sMoGCpTbpjlijLpefy3bw9\n\tNHok+GzDuxGv9tjcOECs4JAGiiPgu0iip09sC8uq+FxDN1wiRfUy7bNDoCrZOw8WPgAZ\n\tPbSDE9xkTAf9UAG/LCsH1VTkazlOxiTWOOZvw/9FDPTpEfLHKoARqFEIz3SEPhT1cErj\n\tbAvIS9deREfkzITdQx8O5V7JYV7KPnJRDwZeOIzIr+o56weoaNkpSjOZ3vf9M9lCuIAP\n\teGTJ9r2FjUyvCs+Qe/vRjGQSyDxA3TGn6xOMA/xs17wVnG4Ysn0yJmxMGtqjFVtG+8QF\n\t1ZuQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=I4oReFLY9kFzsFCTh3BxIQA6s9Y2DHaoeeNTPDXpM8s=;\n\tb=j0s34MPTToxld1kl7f7mk5uwDeKrS/x/iF+rtoU3n8fUwctPFAibmOtmZGad8p+UwN\n\t4QrpCpdfXn+qKJN4KqjiwKWdh7ivViQGSc4I8cAPCqG3e6Z+cMpQ0jeag55r7Q1C1D24\n\trzNm1jYYD7QOMteQ1LJJxEO+X/zyHo4Yoj1aZRD0ynU3Rrtb1PqNH+M2xn2yFgRjweor\n\tLhnKnr5zVXKHOhC/47OyGuiccX8PV0SrpFVrTlME3ZZgK0aRexsPz49L4bfaoGcsMs+i\n\tqaY/LtnkXNUIBHRxtvYRpfIz5aYZGu0gdncWGXWTm3w3Y6g3E3XTBVXaAp5p8xjeDvHb\n\tVETw==","X-Gm-Message-State":"AOAM53183VPEi2Q60QvTUZnq6EGWyoRIPZStx8ENFxIurZBs4vDsQYxy\n\tzXFX7pwCHLVej6OT/4Y39d1afg==","X-Google-Smtp-Source":"ABdhPJwkRera56Ee56t6IK+E5Tjt83zo/qmU44dr2vOtL7uUjkCoUoGnNbbcmMSx4LbtnEE4m95e/Q==","X-Received":"by 2002:a19:ed03:: with SMTP id y3mr6277507lfy.394.1616711805280;\n\tThu, 25 Mar 2021 15:36:45 -0700 (PDT)","Date":"Thu, 25 Mar 2021 23:36:40 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210324112527.63701-1-jacopo@jmondi.org>\n\t<20210324112527.63701-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210324112527.63701-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 5/7] android: camera_hal_manager: Use\n\tCameraHalConfig","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]