[{"id":15886,"web_url":"https://patchwork.libcamera.org/comment/15886/","msgid":"","date":"2021-03-25T06:27:17","subject":"Re: [libcamera-devel] [PATCH 2/7] libcamera: android: Add libyaml\n\tdependency","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Jacopo, thanks for the patch.\n\nOn Wed, Mar 24, 2021 at 8:25 PM Jacopo Mondi wrote:\n>\n> Add a dependency to the libyaml library.\n>\n> The pkg-config symbol is named yaml-0.1\n>\n> Signed-off-by: Jacopo Mondi \n> ---\n> README.rst | 2 +-\n> src/android/meson.build | 1 +\n> 2 files changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/README.rst b/README.rst\n> index 28c33871140a..1a888f86ac64 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -88,7 +88,7 @@ for tracing with lttng: [optional]\n> liblttng-ust-dev python3-jinja2 lttng-tools\n>\n> for Android Camera3 HAL: [optional]\n> - libexif libjpeg\n> + libexif libjpeg libyaml\n>\n> Using GStreamer plugin\n> ~~~~~~~~~~~~~~~~~~~~~~\n> diff --git a/src/android/meson.build b/src/android/meson.build\n> index 87d162c3bbea..19f94a4073f1 100644\n> --- a/src/android/meson.build\n> +++ b/src/android/meson.build\n> @@ -3,6 +3,7 @@\n> android_deps = [\n> dependency('libexif', required : get_option('android')),\n> dependency('libjpeg', required : get_option('android')),\n> + dependency('yaml-0.1', required : get_option('android')),\n> ]\n\nIs this necessary to be 'yaml-0.1'?\nDoesn't 'libyaml' work?\n\n-Hiro\n\n>\n> android_enabled = true\n> --\n> 2.30.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B1338C32E9\n\tfor ;\n\tThu, 25 Mar 2021 06:27:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 37029602D7;\n\tThu, 25 Mar 2021 07:27:28 +0100 (CET)","from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n\t[IPv6:2a00:1450:4864:20::632])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C9D4602D7\n\tfor ;\n\tThu, 25 Mar 2021 07:27:26 +0100 (CET)","by mail-ej1-x632.google.com with SMTP id r12so1067432ejr.5\n\tfor ;\n\tWed, 24 Mar 2021 23:27:26 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"n8W4ceag\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=ICXKidPb/sdI6pVeTpts1CHhz5zoeT5PgHq74k2bCGU=;\n\tb=n8W4ceagyOqPoGm6ZfN9x2/1ED70a4s2MsQ919pbrCiZMJtM//jVExYROFILWpvzwj\n\tJ3jt91R6wXqBAQqR3vzu9D+LFoEUDRmpYjuP7kVJCacvB8e4I8adAjTIxON+rxc5M545\n\tWEvIudfU3ZJxdHaqMyqTHJfvhUE7c6iyYiYGY=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=ICXKidPb/sdI6pVeTpts1CHhz5zoeT5PgHq74k2bCGU=;\n\tb=rcCZzFejlqtNhqcF8z/cQOJs7WMtEBuTN3IwiuYsbcmFr513ngbMZu4fcyGyH/j6aJ\n\ty7FremM9MJJU5diDRfRZmTY2ydgFjkV+exAIPJniLzWNjPV8AGOsXYf4yr72E+26bmg4\n\tI2arxpmAzhG8vy+TtqKqT6gAVACL+rOnjOSJREoUmPzMmINT2KS9oPASVMixRNxg0sSK\n\teemi4Jbkgv+48f+RVQ9AeohB1A1Xf6iqX+DR0BJeE2Z6DS7Mq7xT8uVLzhesB2UWdWu/\n\taCaG4stD+RWtl9BdzUiwwEI5VlfM0W4G0lcuW60QztuGhiaos/1RKSTwwgIXC7WQl7oL\n\tdt5w==","X-Gm-Message-State":"AOAM530FQMCZoeirLf7pug28rq4n5L9Z1xJaPtNXGkcB3Waq5FSpq7SR\n\t/NoG1Q+1W8O2e8Y5lSSucon8PbllxWFk1XseO9FCr7xhLYk=","X-Google-Smtp-Source":"ABdhPJwyulGJZLnFOPmWwa9xhGJHE0dBh+2C7RuAjz/x1bE3EJIhNDyIcNt2xR9VqEAjakCMw+MrH0wjNbPezuJTP3w=","X-Received":"by 2002:a17:906:4747:: with SMTP id\n\tj7mr7540318ejs.221.1616653646155; \n\tWed, 24 Mar 2021 23:27:26 -0700 (PDT)","MIME-Version":"1.0","References":"<20210324112527.63701-1-jacopo@jmondi.org>\n\t<20210324112527.63701-3-jacopo@jmondi.org>","In-Reply-To":"<20210324112527.63701-3-jacopo@jmondi.org>","From":"Hirokazu Honda ","Date":"Thu, 25 Mar 2021 15:27:17 +0900","Message-ID":"","To":"Jacopo Mondi ","Subject":"Re: [libcamera-devel] [PATCH 2/7] libcamera: android: Add libyaml\n\tdependency","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15887,"web_url":"https://patchwork.libcamera.org/comment/15887/","msgid":"<20210325082141.x5qa3fc3dob6qbhb@uno.localdomain>","date":"2021-03-25T08:21:41","subject":"Re: [libcamera-devel] [PATCH 2/7] libcamera: android: Add libyaml\n\tdependency","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Hiro,\n\nOn Thu, Mar 25, 2021 at 03:27:17PM +0900, Hirokazu Honda wrote:\n> Hi Jacopo, thanks for the patch.\n>\n> On Wed, Mar 24, 2021 at 8:25 PM Jacopo Mondi wrote:\n> >\n> > Add a dependency to the libyaml library.\n> >\n> > The pkg-config symbol is named yaml-0.1\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > README.rst | 2 +-\n> > src/android/meson.build | 1 +\n> > 2 files changed, 2 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/README.rst b/README.rst\n> > index 28c33871140a..1a888f86ac64 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -88,7 +88,7 @@ for tracing with lttng: [optional]\n> > liblttng-ust-dev python3-jinja2 lttng-tools\n> >\n> > for Android Camera3 HAL: [optional]\n> > - libexif libjpeg\n> > + libexif libjpeg libyaml\n> >\n> > Using GStreamer plugin\n> > ~~~~~~~~~~~~~~~~~~~~~~\n> > diff --git a/src/android/meson.build b/src/android/meson.build\n> > index 87d162c3bbea..19f94a4073f1 100644\n> > --- a/src/android/meson.build\n> > +++ b/src/android/meson.build\n> > @@ -3,6 +3,7 @@\n> > android_deps = [\n> > dependency('libexif', required : get_option('android')),\n> > dependency('libjpeg', required : get_option('android')),\n> > + dependency('yaml-0.1', required : get_option('android')),\n> > ]\n>\n> Is this necessary to be 'yaml-0.1'?\n> Doesn't 'libyaml' work?\n>\n\nTo have the library correctly located by pkg-config, that's the symbol\nto be used in my understanding. libyaml (which was the most obvious\nchoice to me) didn't work in my native Linux nor ChromiumOS.\n\nSo I went and\n\n$ pkg-config --list-all | grep yaml\nyaml-0.1 LibYAML - Library to parse and emit YAML\n\nSo it seems that's the symbol name that pkg-config uses for libyaml\n\n> -Hiro\n>\n> >\n> > android_enabled = true\n> > --\n> > 2.30.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ABA04BDC66\n\tfor ;\n\tThu, 25 Mar 2021 08:21:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D434768D62;\n\tThu, 25 Mar 2021 09:21:10 +0100 (CET)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 20CEC6084F\n\tfor ;\n\tThu, 25 Mar 2021 09:21:09 +0100 (CET)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 7B53260008;\n\tThu, 25 Mar 2021 08:21:08 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","Date":"Thu, 25 Mar 2021 09:21:41 +0100","From":"Jacopo Mondi ","To":"Hirokazu Honda ","Message-ID":"<20210325082141.x5qa3fc3dob6qbhb@uno.localdomain>","References":"<20210324112527.63701-1-jacopo@jmondi.org>\n\t<20210324112527.63701-3-jacopo@jmondi.org>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 2/7] libcamera: android: Add libyaml\n\tdependency","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15929,"web_url":"https://patchwork.libcamera.org/comment/15929/","msgid":"","date":"2021-03-26T03:10:53","subject":"Re: [libcamera-devel] [PATCH 2/7] libcamera: android: Add libyaml\n\tdependency","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Mar 24, 2021 at 12:25:22PM +0100, Jacopo Mondi wrote:\n> Add a dependency to the libyaml library.\n> \n> The pkg-config symbol is named yaml-0.1\n> \n> Signed-off-by: Jacopo Mondi \n\nI'd squash this with 4/7, up to you.\n\nReviewed-by: Laurent Pinchart \n\n> ---\n> README.rst | 2 +-\n> src/android/meson.build | 1 +\n> 2 files changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/README.rst b/README.rst\n> index 28c33871140a..1a888f86ac64 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -88,7 +88,7 @@ for tracing with lttng: [optional]\n> liblttng-ust-dev python3-jinja2 lttng-tools\n> \n> for Android Camera3 HAL: [optional]\n> - libexif libjpeg\n> + libexif libjpeg libyaml\n> \n> Using GStreamer plugin\n> ~~~~~~~~~~~~~~~~~~~~~~\n> diff --git a/src/android/meson.build b/src/android/meson.build\n> index 87d162c3bbea..19f94a4073f1 100644\n> --- a/src/android/meson.build\n> +++ b/src/android/meson.build\n> @@ -3,6 +3,7 @@\n> android_deps = [\n> dependency('libexif', required : get_option('android')),\n> dependency('libjpeg', required : get_option('android')),\n> + dependency('yaml-0.1', required : get_option('android')),\n> ]\n> \n> android_enabled = true","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0DB23BDC66\n\tfor ;\n\tFri, 26 Mar 2021 03:11:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 73C7A6084F;\n\tFri, 26 Mar 2021 04:11:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 59FD5602E3\n\tfor ;\n\tFri, 26 Mar 2021 04:11:37 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BFB03443;\n\tFri, 26 Mar 2021 04:11:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"O91KkJRj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616728296;\n\tbh=JNGyv5lnIOe6AwJt25GCgREHuN3s/0KDSFTXRuU2WGw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=O91KkJRjv3Orz6IvEkdZ3X84ttyQT8vKNZy9n9X5/AIZ0BKXZCK6NGdfl3+KJtzwL\n\t353hX6xZEfvJ+ZD9SEnrGtcl9+IPYOcyDAzrkHDOuUb1IMjvcOLAz81/DYqW5Zaber\n\tZB3iDRiBHQib5PNUMOgR0r6sQOeQFEw0bF7emNLA=","Date":"Fri, 26 Mar 2021 05:10:53 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210324112527.63701-1-jacopo@jmondi.org>\n\t<20210324112527.63701-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210324112527.63701-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 2/7] libcamera: android: Add libyaml\n\tdependency","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]