[{"id":15891,"web_url":"https://patchwork.libcamera.org/comment/15891/","msgid":"<20210325084054.tb6reluyd6zmp3mc@uno.localdomain>","date":"2021-03-25T08:40:54","subject":"Re: [libcamera-devel] [PATCH v2 4/8] android: CameraDevice: Take\n\tshared_ptr in constructor","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Hiro\n\nOn Wed, Mar 24, 2021 at 04:07:53PM +0900, Hirokazu Honda wrote:\n> CameraDevice takes the ownership of Camera. Therefore,\n> shared_ptr would rather be used than const shared_ptr&.\n>\n> Signed-off-by: Hirokazu Honda \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/android/camera_device.cpp | 12 +++++++-----\n> src/android/camera_device.h | 4 ++--\n> 2 files changed, 9 insertions(+), 7 deletions(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index d0955de7..c0630e53 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -312,9 +312,10 @@ CameraDevice::Camera3RequestDescriptor::~Camera3RequestDescriptor()\n> * back to the framework using the designated callbacks.\n> */\n>\n> -CameraDevice::CameraDevice(unsigned int id, const std::shared_ptr &camera)\n> -\t: id_(id), running_(false), camera_(camera), staticMetadata_(nullptr),\n> -\t facing_(CAMERA_FACING_FRONT), orientation_(0)\n> +CameraDevice::CameraDevice(unsigned int id, std::shared_ptr camera)\n> +\t: id_(id), running_(false), camera_(std::move(camera)),\n> +\t staticMetadata_(nullptr), facing_(CAMERA_FACING_FRONT),\n> +\t orientation_(0)\n> {\n> \tcamera_->requestCompleted.connect(this, &CameraDevice::requestComplete);\n>\n> @@ -351,9 +352,10 @@ CameraDevice::~CameraDevice()\n> }\n>\n> std::unique_ptr CameraDevice::create(unsigned int id,\n> -\t\t\t\t\t\t const std::shared_ptr &cam)\n> +\t\t\t\t\t\t std::shared_ptr cam)\n> {\n> -\treturn std::unique_ptr(new CameraDevice(id, cam));\n> +\treturn std::unique_ptr(\n> +\t\tnew CameraDevice(id, std::move(cam)));\n> }\n>\n> /*\n> diff --git a/src/android/camera_device.h b/src/android/camera_device.h\n> index 8be7f305..555b33e7 100644\n> --- a/src/android/camera_device.h\n> +++ b/src/android/camera_device.h\n> @@ -33,7 +33,7 @@ class CameraDevice : protected libcamera::Loggable\n> {\n> public:\n> \tstatic std::unique_ptr create(unsigned int id,\n> -\t\t\t\t\t\t const std::shared_ptr &cam);\n> +\t\t\t\t\t\t std::shared_ptr cam);\n> \t~CameraDevice();\n>\n> \tint initialize();\n> @@ -66,7 +66,7 @@ protected:\n> \tstd::string logPrefix() const override;\n>\n> private:\n> -\tCameraDevice(unsigned int id, const std::shared_ptr &camera);\n> +\tCameraDevice(unsigned int id, std::shared_ptr camera);\n>\n> \tstruct Camera3RequestDescriptor {\n> \t\tCamera3RequestDescriptor(libcamera::Camera *camera,\n> --\n> 2.31.0.291.g576ba9dcdaf-goog\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16CE6C32E9\n\tfor ;\n\tThu, 25 Mar 2021 08:40:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B2C768D6C;\n\tThu, 25 Mar 2021 09:40:22 +0100 (CET)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EBA4868D58\n\tfor ;\n\tThu, 25 Mar 2021 09:40:21 +0100 (CET)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 4BC8540012;\n\tThu, 25 Mar 2021 08:40:20 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","Date":"Thu, 25 Mar 2021 09:40:54 +0100","From":"Jacopo Mondi ","To":"Hirokazu Honda ","Message-ID":"<20210325084054.tb6reluyd6zmp3mc@uno.localdomain>","References":"<20210324070757.3530377-1-hiroh@chromium.org>\n\t<20210324070757.3530377-5-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210324070757.3530377-5-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v2 4/8] android: CameraDevice: Take\n\tshared_ptr in constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]