[{"id":15880,"web_url":"https://patchwork.libcamera.org/comment/15880/","msgid":"","date":"2021-03-24T21:01:54","subject":"Re: [libcamera-devel] [PATCH v2 3/8] android: CameraHalManager: Fix\n\ta function call of a moved Camera","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch.\n\nOn Wed, Mar 24, 2021 at 04:07:52PM +0900, Hirokazu Honda wrote:\n> libcamera::Camera::id() is called after std::move() in\n> cameraAdded(). This fixes the issue by not executing std::move().\n> \n> Signed-off-by: Hirokazu Honda \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_hal_manager.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\n> index b501f8db..f70cd8a8 100644\n> --- a/src/android/camera_hal_manager.cpp\n> +++ b/src/android/camera_hal_manager.cpp\n> @@ -115,7 +115,7 @@ void CameraHalManager::cameraAdded(std::shared_ptr cam)\n> \t}\n> \n> \t/* Create a CameraDevice instance to wrap the libcamera Camera. */\n> -\tstd::unique_ptr camera = CameraDevice::create(id, std::move(cam));\n> +\tstd::unique_ptr camera = CameraDevice::create(id, cam);\n> \tint ret = camera->initialize();\n> \tif (ret) {\n> \t\tLOG(HAL, Error) << \"Failed to initialize camera: \" << cam->id();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A085C32E7\n\tfor ;\n\tWed, 24 Mar 2021 21:02:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 41C3C68D63;\n\tWed, 24 Mar 2021 22:02:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 129D6602E3\n\tfor ;\n\tWed, 24 Mar 2021 22:02:38 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 77E3D580;\n\tWed, 24 Mar 2021 22:02:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pjxw0/ch\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616619757;\n\tbh=uTMZtcGFDrNFJGpmFG5MMsJk7kXn0Y4uay2lq3vKThY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pjxw0/chBSrLZx4vladnbr7DxYkR7+l/+0UwdScu7or4pnY7TR56hLanndRwvt1CT\n\twd3jVX0ZXT/qraGJEcH/aeiMa4l7iRBmWGuxcrip18FLNqCrvdVK6KAYXyufvAnvX4\n\tfuAO/elyc/uign/IHiWHtKk4eRBPN45EsTnfPbuo=","Date":"Wed, 24 Mar 2021 23:01:54 +0200","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210324070757.3530377-1-hiroh@chromium.org>\n\t<20210324070757.3530377-4-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210324070757.3530377-4-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v2 3/8] android: CameraHalManager: Fix\n\ta function call of a moved Camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15890,"web_url":"https://patchwork.libcamera.org/comment/15890/","msgid":"<20210325083740.73s4n6mzvdtmbj75@uno.localdomain>","date":"2021-03-25T08:37:40","subject":"Re: [libcamera-devel] [PATCH v2 3/8] android: CameraHalManager: Fix\n\ta function call of a moved Camera","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Hiro,\n\nOn Wed, Mar 24, 2021 at 04:07:52PM +0900, Hirokazu Honda wrote:\n> libcamera::Camera::id() is called after std::move() in\n> cameraAdded(). This fixes the issue by not executing std::move().\n>\n> Signed-off-by: Hirokazu Honda \n> ---\n> src/android/camera_hal_manager.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\n> index b501f8db..f70cd8a8 100644\n> --- a/src/android/camera_hal_manager.cpp\n> +++ b/src/android/camera_hal_manager.cpp\n> @@ -115,7 +115,7 @@ void CameraHalManager::cameraAdded(std::shared_ptr cam)\n> \t}\n>\n> \t/* Create a CameraDevice instance to wrap the libcamera Camera. */\n> -\tstd::unique_ptr camera = CameraDevice::create(id, std::move(cam));\n> +\tstd::unique_ptr camera = CameraDevice::create(id, cam);\n\nFurthermore, the shared pointer reference counter will be anyway\ndecreased when 'cam' goes out of scope.. So no need for move in any\nway\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n> \tint ret = camera->initialize();\n> \tif (ret) {\n> \t\tLOG(HAL, Error) << \"Failed to initialize camera: \" << cam->id();\n> --\n> 2.31.0.291.g576ba9dcdaf-goog\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 437FFBDC66\n\tfor ;\n\tThu, 25 Mar 2021 08:37:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0A48B68D6D;\n\tThu, 25 Mar 2021 09:37:09 +0100 (CET)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9EE5168D58\n\tfor ;\n\tThu, 25 Mar 2021 09:37:07 +0100 (CET)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 16668200004;\n\tThu, 25 Mar 2021 08:37:06 +0000 (UTC)"],"Date":"Thu, 25 Mar 2021 09:37:40 +0100","From":"Jacopo Mondi ","To":"Hirokazu Honda ","Message-ID":"<20210325083740.73s4n6mzvdtmbj75@uno.localdomain>","References":"<20210324070757.3530377-1-hiroh@chromium.org>\n\t<20210324070757.3530377-4-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210324070757.3530377-4-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v2 3/8] android: CameraHalManager: Fix\n\ta function call of a moved Camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]