{"id":11678,"url":"https://patchwork.libcamera.org/api/patches/11678/?format=json","web_url":"https://patchwork.libcamera.org/patch/11678/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210324070757.3530377-4-hiroh@chromium.org>","date":"2021-03-24T07:07:52","name":"[libcamera-devel,v2,3/8] android: CameraHalManager: Fix a function call of a moved Camera","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"c09fc263c54388d9e04eec4cdf241348c4eb29f4","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11678/mbox/","series":[{"id":1825,"url":"https://patchwork.libcamera.org/api/series/1825/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1825","date":"2021-03-24T07:07:51","name":"Improve pointer types in android HAL adaptation layer","version":2,"mbox":"https://patchwork.libcamera.org/series/1825/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11678/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11678/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 237CAC32E7\n\tfor ;\n\tWed, 24 Mar 2021 07:08:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CECAB68D69;\n\tWed, 24 Mar 2021 08:08:16 +0100 (CET)","from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com\n\t[IPv6:2607:f8b0:4864:20::102c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB69D68D62\n\tfor ;\n\tWed, 24 Mar 2021 08:08:12 +0100 (CET)","by mail-pj1-x102c.google.com with SMTP id\n\tk23-20020a17090a5917b02901043e35ad4aso650667pji.3\n\tfor ;\n\tWed, 24 Mar 2021 00:08:12 -0700 (PDT)","from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:2:7c07:24cd:c637:7fab])\n\tby smtp.gmail.com with ESMTPSA id\n\te63sm1246860pfe.208.2021.03.24.00.08.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 24 Mar 2021 00:08:08 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Q9rxYLkG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=t5MwDzkNk5G2yMVMsAXj5zqQX2fgl2OED1OdWzHSIn0=;\n\tb=Q9rxYLkGtvYyHbKiQIxcP9Lyma7vsDI3ePqp1dX8SA1SsiqPKIYVujmytpMUGj3wZT\n\t/WnAkkKDlUXFUHmbKK/G96Q0Ige+vilkXXCuR+AJ5zq94CwEQR+5iMMyRKof7U4BMfhi\n\tqp8i8W17nxrlHqK+OZmo4K+KbUOwCVGTLHyfk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=t5MwDzkNk5G2yMVMsAXj5zqQX2fgl2OED1OdWzHSIn0=;\n\tb=npukhwpzCZI12F4pmEEYnAU6QGMTFqCPHqj82kz8FxjPhxArE0tLpFVU24uNvzK0NW\n\tVLRhEUTdYnRSUGA6TX4EVdBYhHXPFR64pNysBdgmXPFfHxDN40wUEMLR6t6PQqtlhbj3\n\tr0MxqOrJUnC336lC2BY2kXS08oymJJ0nAzd2buRWEdTBsqnfJT3tOaMCH9UdhuLfWMfO\n\totP78ujFl77uYIu13W4nJu87anWQSV0NF3ATo8WVhwb+IAadne/MMCDD/GaoHjy/6mW+\n\tQh545Cqd+3ZxdjterMFY0CImG8GwYCNCtErj6EP67681mjjvkFc6zEBqeKsHX2CpmvO2\n\thEIw==","X-Gm-Message-State":"AOAM531InYCZgMKPA27hk7IQg80WEGkbI6i7TKkPvnIoxwIidp7KyjUy\n\tSd8APqCZYqnUPF/yDtf7/MnzXUy81Zib6Q==","X-Google-Smtp-Source":"ABdhPJzNp109bzuscz7LbMNVD4SjfPg3LJQZ3ixrCTCExh2U5k7btTJ0N4sUhUYqAgTliuKZ3VkN9Q==","X-Received":"by 2002:a17:90a:868c:: with SMTP id\n\tp12mr1953197pjn.82.1616569689090; \n\tWed, 24 Mar 2021 00:08:09 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 24 Mar 2021 16:07:52 +0900","Message-Id":"<20210324070757.3530377-4-hiroh@chromium.org>","X-Mailer":"git-send-email 2.31.0.291.g576ba9dcdaf-goog","In-Reply-To":"<20210324070757.3530377-1-hiroh@chromium.org>","References":"<20210324070757.3530377-1-hiroh@chromium.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 3/8] android: CameraHalManager: Fix a\n\tfunction call of a moved Camera","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"libcamera::Camera::id() is called after std::move() in\ncameraAdded(). This fixes the issue by not executing std::move().\n\nSigned-off-by: Hirokazu Honda \n---\n src/android/camera_hal_manager.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n--\n2.31.0.291.g576ba9dcdaf-goog","diff":"diff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\nindex b501f8db..f70cd8a8 100644\n--- a/src/android/camera_hal_manager.cpp\n+++ b/src/android/camera_hal_manager.cpp\n@@ -115,7 +115,7 @@ void CameraHalManager::cameraAdded(std::shared_ptr cam)\n \t}\n\n \t/* Create a CameraDevice instance to wrap the libcamera Camera. */\n-\tstd::unique_ptr camera = CameraDevice::create(id, std::move(cam));\n+\tstd::unique_ptr camera = CameraDevice::create(id, cam);\n \tint ret = camera->initialize();\n \tif (ret) {\n \t\tLOG(HAL, Error) << \"Failed to initialize camera: \" << cam->id();\n","prefixes":["libcamera-devel","v2","3/8"]}