[{"id":15838,"web_url":"https://patchwork.libcamera.org/comment/15838/","msgid":"<20210323143955.2hhwqjgjjarpzrhc@basti-TUXEDO-Book-XA1510>","date":"2021-03-23T14:39:55","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_manager: Document\n\tthe CameraManager destructor","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"Hello Laurent,\n\nThanks for the patch.\n\nOn 23.03.2021 16:16, Laurent Pinchart wrote:\n>The destructor stops the camera manager if it is running. This is at the\n>moment an implementation detail, but makes sense to guarantee in the\n>API. Document it.\n>\n>Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n>---\n> src/libcamera/camera_manager.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n>\n>diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n>index 67641a555e1e..9e4d9c391f09 100644\n>--- a/src/libcamera/camera_manager.cpp\n>+++ b/src/libcamera/camera_manager.cpp\n>@@ -269,6 +269,11 @@ CameraManager::CameraManager()\n> \tself_ = this;\n> }\n>\n>+/**\n>+ * \\brief Destroy the camera manager\n>+ *\n>+ * Destroying the camera manager stops it if it is currently running.\n>+ */\n> CameraManager::~CameraManager()\n> {\n> \tstop();\n>-- \n>Regards,\n\nReviewed-by: Sebastian Fricke <sebastian.fricke@posteo.net>\n\nGreetings,\nSebastian\n>\n>Laurent Pinchart\n>\n>_______________________________________________\n>libcamera-devel mailing list\n>libcamera-devel@lists.libcamera.org\n>https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9D8A5C32E4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Mar 2021 14:39:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 119BF68D6E;\n\tTue, 23 Mar 2021 15:39:58 +0100 (CET)","from mout01.posteo.de (mout01.posteo.de [185.67.36.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09C8568D66\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Mar 2021 15:39:57 +0100 (CET)","from submission (posteo.de [89.146.220.130]) \n\tby mout01.posteo.de (Postfix) with ESMTPS id 6FC3016005C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Mar 2021 15:39:56 +0100 (CET)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4F4YtM6q5cz6tmW;\n\tTue, 23 Mar 2021 15:39:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"PG2lvupX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1616510396; bh=wKhw1eLoW5Ew8W7XFInd82/qZtQoEpLhuzy7VgbbVk4=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=PG2lvupXu2PMjEgr7zxqX65tecrFCQ+L1UyZADvEXjsodf0Y5HIRXITDqK9rTqPBY\n\tRD5899RMInsrAVM89Q+pCr5K/Uf4M0U5sYOflogfmafEhPxsTIzyKGXZdxHmXbemEj\n\t5GIJKl2u55OPmWHFyl/v+uMKj5O+rYdxg1dNfYppY+dWHG1ktnGyniXMQdYLHBAF6n\n\tZZaFQo3ZAVomDTYE5ehiXWJma1t5mVO5m0GYS2lVmWaa8BH5cdxvgZyqzaziEogA53\n\ttt3hnrus6Q2nXKWC2yzk1TSivdiFjtaSB9omurs9cJPcQqHEebFYmmapoLjVEpjpiV\n\tMoPnIk4uUpDvg==","Date":"Tue, 23 Mar 2021 15:39:55 +0100","From":"Sebastian Fricke <sebastian.fricke@posteo.net>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20210323143955.2hhwqjgjjarpzrhc@basti-TUXEDO-Book-XA1510>","References":"<20210323141631.29827-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210323141631.29827-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_manager: Document\n\tthe CameraManager destructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":15839,"web_url":"https://patchwork.libcamera.org/comment/15839/","msgid":"<ff9856f4-fefb-da28-50e8-dcdd0f1bf351@ideasonboard.com>","date":"2021-03-23T14:59:46","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_manager: Document\n\tthe CameraManager destructor","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 3/23/21 8:09 PM, Sebastian Fricke wrote:\n> Hello Laurent,\n>\n> Thanks for the patch.\n>\n> On 23.03.2021 16:16, Laurent Pinchart wrote:\n>> The destructor stops the camera manager if it is running. This is at the\n>> moment an implementation detail, but makes sense to guarantee in the\n>> API. Document it.\n>>\n>> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n\n>> ---\n>> src/libcamera/camera_manager.cpp | 5 +++++\n>> 1 file changed, 5 insertions(+)\n>>\n>> diff --git a/src/libcamera/camera_manager.cpp \n>> b/src/libcamera/camera_manager.cpp\n>> index 67641a555e1e..9e4d9c391f09 100644\n>> --- a/src/libcamera/camera_manager.cpp\n>> +++ b/src/libcamera/camera_manager.cpp\n>> @@ -269,6 +269,11 @@ CameraManager::CameraManager()\n>>     self_ = this;\n>> }\n>>\n>> +/**\n>> + * \\brief Destroy the camera manager\n>> + *\n>> + * Destroying the camera manager stops it if it is currently running.\n>> + */\n>> CameraManager::~CameraManager()\n>> {\n>>     stop();\n>> -- \n>> Regards,\n>\n> Reviewed-by: Sebastian Fricke <sebastian.fricke@posteo.net>\n>\n> Greetings,\n> Sebastian\n>>\n>> Laurent Pinchart\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C760C32E5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 23 Mar 2021 14:59:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E2E7C68D69;\n\tTue, 23 Mar 2021 15:59:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BFBFC68D58\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Mar 2021 15:59:51 +0100 (CET)","from localhost.localdomain (unknown [103.238.109.27])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A164E885;\n\tTue, 23 Mar 2021 15:59:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"GZnL1Zqc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616511591;\n\tbh=qaYoNEihPJb6hcK1qBZejzjSvxeZ6d3Fj5oXliCzz+M=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=GZnL1ZqcEyikTZdW7T0Sc9EhHcb8nHw5OCaZpIynN2FDZAqwgIcb4ERtFCf6/Wq9r\n\txd8Nn9B/k6t5K4G+MDyE4AouEDovnu5Ha2SSC7gvTVFEgj9a0XPqDg1VMx/JPegLbo\n\tWIIAMf9SCnAimOTp3D2INgkjc0OjhE42CN3xda/A=","To":"Sebastian Fricke <sebastian.fricke@posteo.net>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>","References":"<20210323141631.29827-1-laurent.pinchart@ideasonboard.com>\n\t<20210323143955.2hhwqjgjjarpzrhc@basti-TUXEDO-Book-XA1510>","From":"Umang Jain <umang.jain@ideasonboard.com>","Message-ID":"<ff9856f4-fefb-da28-50e8-dcdd0f1bf351@ideasonboard.com>","Date":"Tue, 23 Mar 2021 20:29:46 +0530","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.11.0","MIME-Version":"1.0","In-Reply-To":"<20210323143955.2hhwqjgjjarpzrhc@basti-TUXEDO-Book-XA1510>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_manager: Document\n\tthe CameraManager destructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":15848,"web_url":"https://patchwork.libcamera.org/comment/15848/","msgid":"<CAO5uPHPQA-bRpLsfeZhnOGy9F+WijBUdjgE73s9OJF53KHQT6w@mail.gmail.com>","date":"2021-03-24T06:16:28","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_manager: Document\n\tthe CameraManager destructor","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Laurent, Thanks for the patch.\n\n\nOn Tue, Mar 23, 2021 at 11:59 PM Umang Jain <umang.jain@ideasonboard.com> wrote:\n>\n> Hi Laurent,\n>\n> On 3/23/21 8:09 PM, Sebastian Fricke wrote:\n> > Hello Laurent,\n> >\n> > Thanks for the patch.\n> >\n> > On 23.03.2021 16:16, Laurent Pinchart wrote:\n> >> The destructor stops the camera manager if it is running. This is at the\n> >> moment an implementation detail, but makes sense to guarantee in the\n> >> API. Document it.\n> >>\n> >> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>\n>\n> >> ---\n> >> src/libcamera/camera_manager.cpp | 5 +++++\n> >> 1 file changed, 5 insertions(+)\n> >>\n> >> diff --git a/src/libcamera/camera_manager.cpp\n> >> b/src/libcamera/camera_manager.cpp\n> >> index 67641a555e1e..9e4d9c391f09 100644\n> >> --- a/src/libcamera/camera_manager.cpp\n> >> +++ b/src/libcamera/camera_manager.cpp\n> >> @@ -269,6 +269,11 @@ CameraManager::CameraManager()\n> >>     self_ = this;\n> >> }\n> >>\n> >> +/**\n> >> + * \\brief Destroy the camera manager\n> >> + *\n> >> + * Destroying the camera manager stops it if it is currently running.\n> >> + */\n> >> CameraManager::~CameraManager()\n> >> {\n> >>     stop();\n> >> --\n> >> Regards,\n> >\n> > Reviewed-by: Sebastian Fricke <sebastian.fricke@posteo.net>\n> >\n\nReviewed-by: Hirokazu Honda<hiroh@chromium.org>\n\nRegards,\n-Hiro\n> > Greetings,\n> > Sebastian\n> >>\n> >> Laurent Pinchart\n> >>\n> >> _______________________________________________\n> >> libcamera-devel mailing list\n> >> libcamera-devel@lists.libcamera.org\n> >> https://lists.libcamera.org/listinfo/libcamera-devel\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1AB77C32E5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 24 Mar 2021 06:16:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D67A68D63;\n\tWed, 24 Mar 2021 07:16:39 +0100 (CET)","from mail-ed1-x530.google.com (mail-ed1-x530.google.com\n\t[IPv6:2a00:1450:4864:20::530])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6676068D47\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Mar 2021 07:16:38 +0100 (CET)","by mail-ed1-x530.google.com with SMTP id z1so26303898edb.8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 23 Mar 2021 23:16:38 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Q+oUGdBR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=ocL4nimDhisJ0RS+OohUvFkbNqxNGl5iEQwb0Cuc4Lk=;\n\tb=Q+oUGdBR1jDJaNvW+/24LX5TI+QbAqj1nIJYjuIVH2QEioRbhfoavGeXHNO9z3v2K4\n\tHC7DsLwd9li3gUKO3EbJmYlJMl+LZHNOKDftzT4wdlHVWs+uIChcpotfRJLfA4Pujasn\n\tv3vlRXl146v2r98lidJ7Ud5yAjaQjY3p8P/Zw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=ocL4nimDhisJ0RS+OohUvFkbNqxNGl5iEQwb0Cuc4Lk=;\n\tb=qMYTet6EI5/i6edXk0lJFqxSkb9Nl7awW0FbURleC1qzWMwdI4pC5byForzQtvQs9L\n\tJJaD59xs9yNJJldBeC86kiWpxFG1HbUqygahJR6J+6CI6YF3aV+nVTEveXaMNCPIs6OO\n\tUWI/2t6Rb2j5dhMovsRcBQy/AXDXfdcD1S8ChWFIbEIokXrTmO9sk2PEmSv64kftv0MV\n\tJmuH8jAsIxnPtGp6L+aysXPOCaD1M7U8E2BDJ/AL96c+j3hGvX5RGW/NfB4v/W/MH61H\n\tGrISBs9rmBcLMrBaHGwU+ezXhg0hf/VBKnj+7+BXXDrODpCGkO91zlKTr6cZCwejDmf1\n\t0h2w==","X-Gm-Message-State":"AOAM531egLQ2fo19xsUHZUDd6cwwafu+zYihwXGMnhxjSZbGBet7FVjU\n\tAWDcXS6n3JfAovopXS7qtLuFUN/QaYNWAcgNoviYXPMFD2J3uA==","X-Google-Smtp-Source":"ABdhPJxWcik2o40OH5ERIeFs/nJOtXm5FxyXNl+hSobaTPLOTjje91nXXRJWhk0Gsl1I59JguKc1gUziSRnNJ/67Aic=","X-Received":"by 2002:aa7:c4cc:: with SMTP id\n\tp12mr1576325edr.325.1616566598053; \n\tTue, 23 Mar 2021 23:16:38 -0700 (PDT)","MIME-Version":"1.0","References":"<20210323141631.29827-1-laurent.pinchart@ideasonboard.com>\n\t<20210323143955.2hhwqjgjjarpzrhc@basti-TUXEDO-Book-XA1510>\n\t<ff9856f4-fefb-da28-50e8-dcdd0f1bf351@ideasonboard.com>","In-Reply-To":"<ff9856f4-fefb-da28-50e8-dcdd0f1bf351@ideasonboard.com>","From":"Hirokazu Honda <hiroh@chromium.org>","Date":"Wed, 24 Mar 2021 15:16:28 +0900","Message-ID":"<CAO5uPHPQA-bRpLsfeZhnOGy9F+WijBUdjgE73s9OJF53KHQT6w@mail.gmail.com>","To":"Umang Jain <umang.jain@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_manager: Document\n\tthe CameraManager destructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":15860,"web_url":"https://patchwork.libcamera.org/comment/15860/","msgid":"<20210324093116.GD2562@pyrite.rasen.tech>","date":"2021-03-24T09:31:16","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_manager: Document\n\tthe CameraManager destructor","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Tue, Mar 23, 2021 at 04:16:31PM +0200, Laurent Pinchart wrote:\n> The destructor stops the camera manager if it is running. This is at the\n> moment an implementation detail, but makes sense to guarantee in the\n> API. Document it.\n> \n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nReviewed-by: Paul Elder <paul.elder@ideasonboard.com>\n\n> ---\n>  src/libcamera/camera_manager.cpp | 5 +++++\n>  1 file changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 67641a555e1e..9e4d9c391f09 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -269,6 +269,11 @@ CameraManager::CameraManager()\n>  \tself_ = this;\n>  }\n>  \n> +/**\n> + * \\brief Destroy the camera manager\n> + *\n> + * Destroying the camera manager stops it if it is currently running.\n> + */\n>  CameraManager::~CameraManager()\n>  {\n>  \tstop();\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5DE31C32E7\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 24 Mar 2021 09:31:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A746C68D65;\n\tWed, 24 Mar 2021 10:31:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6B81E602D9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Mar 2021 10:31:25 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 92DB9580;\n\tWed, 24 Mar 2021 10:31:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MmF6qqK5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616578285;\n\tbh=AiQ3rkDgFhBS2W8zoD2Py0/ssbPfLBZsRz7qHyS+Lnc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MmF6qqK52fsD0p0efk9RLc5ZSNfeNukbtvoxfHCLVRosoSQTXmBqZ/JKWEQrDgf6X\n\tX9/C+Lr5DcuPOkXB7IxWvWPRJNps9pX6JPgnf9XZymJUFzmIV4B7zsSQEePXcvLTzQ\n\t2bPEICre9dsSXNhqaa/hYFoQYPerMrmTjDk8q/sI=","Date":"Wed, 24 Mar 2021 18:31:16 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Message-ID":"<20210324093116.GD2562@pyrite.rasen.tech>","References":"<20210323141631.29827-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210323141631.29827-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera_manager: Document\n\tthe CameraManager destructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]