[{"id":15808,"web_url":"https://patchwork.libcamera.org/comment/15808/","msgid":"","date":"2021-03-23T01:46:52","subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Remove\n\tunnecessary rvalue references","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hiro,\n\nThank you for the patch.\n\nOn Tue, Mar 23, 2021 at 07:09:10AM +0900, Hirokazu Honda wrote:\n> There are std::unique_ptr rvalue reference arguments. They are\n> intended to pass the ownership to the functions. In the case,\n> it is right to let the argument be std::unique_ptr value and\n> pass by std::move().\n> \n> Signed-off-by: Hirokazu Honda \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/internal/device_enumerator.h | 2 +-\n> include/libcamera/internal/device_enumerator_udev.h | 4 ++--\n> src/libcamera/device_enumerator.cpp | 2 +-\n> 3 files changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/internal/device_enumerator.h b/include/libcamera/internal/device_enumerator.h\n> index a9850400..707cfe8f 100644\n> --- a/include/libcamera/internal/device_enumerator.h\n> +++ b/include/libcamera/internal/device_enumerator.h\n> @@ -49,7 +49,7 @@ public:\n> \n> protected:\n> \tstd::unique_ptr createDevice(const std::string &deviceNode);\n> -\tvoid addDevice(std::unique_ptr &&media);\n> +\tvoid addDevice(std::unique_ptr media);\n> \tvoid removeDevice(const std::string &deviceNode);\n> \n> private:\n> diff --git a/include/libcamera/internal/device_enumerator_udev.h b/include/libcamera/internal/device_enumerator_udev.h\n> index 6f45be0c..58e64a29 100644\n> --- a/include/libcamera/internal/device_enumerator_udev.h\n> +++ b/include/libcamera/internal/device_enumerator_udev.h\n> @@ -39,8 +39,8 @@ private:\n> \tusing DependencyMap = std::map>;\n> \n> \tstruct MediaDeviceDeps {\n> -\t\tMediaDeviceDeps(std::unique_ptr &&media,\n> -\t\t\t\tDependencyMap &&deps)\n> +\t\tMediaDeviceDeps(std::unique_ptr media,\n> +\t\t\t\tDependencyMap deps)\n> \t\t\t: media_(std::move(media)), deps_(std::move(deps))\n> \t\t{\n> \t\t}\n> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> index 647974b1..e6ecc360 100644\n> --- a/src/libcamera/device_enumerator.cpp\n> +++ b/src/libcamera/device_enumerator.cpp\n> @@ -246,7 +246,7 @@ std::unique_ptr DeviceEnumerator::createDevice(const std::string &d\n> * This method shall be called after all members of the entities of the\n> * media graph have been confirmed to be initialized.\n> */\n> -void DeviceEnumerator::addDevice(std::unique_ptr &&media)\n> +void DeviceEnumerator::addDevice(std::unique_ptr media)\n> {\n> \tLOG(DeviceEnumerator, Debug)\n> \t\t<< \"Added device \" << media->deviceNode() << \": \" << media->driver();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42853BD80C\n\tfor ;\n\tTue, 23 Mar 2021 01:47:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 68C9768D7A;\n\tTue, 23 Mar 2021 02:47:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 796B868D6D\n\tfor ;\n\tTue, 23 Mar 2021 02:47:34 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E5DBA885;\n\tTue, 23 Mar 2021 02:47:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DXtqXilP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616464054;\n\tbh=oGs0deQvz25ppo5wZULZKBt7lcXGLBadIOBUsE8Ufo4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=DXtqXilPGNpZF1/thxJLAZapeXgYobnJFA9JTi5O90g9jISaoBY6VPdD+8IXlxS3i\n\tO6l+dyaRMSoHO6nXNsShq6ZDpfZwSl6C/C8UwGqQ6HWRVbGVRKlPgvD9yd/P2hN8QI\n\thtJQGNvYg2YiIWUFSD9t/QcJxM3SgQ87qrtonzD0=","Date":"Tue, 23 Mar 2021 03:46:52 +0200","From":"Laurent Pinchart ","To":"Hirokazu Honda ","Message-ID":"","References":"<20210322220910.3179457-1-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210322220910.3179457-1-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: device_enumerator: Remove\n\tunnecessary rvalue references","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]