[{"id":15826,"web_url":"https://patchwork.libcamera.org/comment/15826/","msgid":"<20210323102307.GA2056@pyrite.rasen.tech>","date":"2021-03-23T10:23:07","subject":"Re: [libcamera-devel] [PATCH v5] Add alternative meson install\n\tcommand","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Vedant,\n\nThank you for the patch.\n\nOn Tue, Mar 23, 2021 at 12:54:00AM +0530, Vedant Paranjape wrote:\n> Changes in v5:\n> * Updated README.rst to describe meson install issue\n> * Removed \"changelog\" heading from commit message\n> * Fixed few grammatical mistakes\n> * Reworded few sentences\n\nThis belongs below ---\n\n> \n> While installing meson using pip3 install --user meson, due to python\n> path issues, build.ninja can't be located by ninja. meson generates\n> ninja files fine, but then when you run ninja, it is unable to find\n> meson's build.ninja python module due to path issues.\n\nI think you need some more detail on \"path issues\".\n\nAlso I think you should take in what what Nicolas said in review of v3.\n\n\nPaul\n\n> It gives the following error on ninja -C build install:\n> \n> ninja: Entering directory `build'\n> ninja: error: loading 'build.ninja': No such file or directory\n> \n> After uninstalling meson using pip3 and installing it again using pip\n> without --user argument solved the issue.\n> \n> Signed-off-by: Vedant Paranjape \n> ---\n> README.rst | 16 ++++++++++++++++\n> 1 file changed, 16 insertions(+)\n> \n> diff --git a/README.rst b/README.rst\n> index 1427c714..39213dc4 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -37,6 +37,22 @@ To fetch the sources, build and install:\n> meson build\n> ninja -C build install\n> \n> +Several users have reported issues with meson installation, crux of the issue is a potential version\n> +mismatch between the version that root uses, and the version that the normal user\n> +uses. On calling `ninja -C build`, it can't find the build.ninja module. This the snippet of error message,\n> +\n> +:: \n> +\n> + ninja: Entering directory `build' \n> + ninja: error: loading 'build.ninja': No such file or directory\n> +\n> +This can be solved in two ways: \n> +\n> +1) Don't install meson again if it is already installed system-wide.\n> +2) If meson which is different from system-wide is already installed, \n> +uninstall that meson using pip3, and install again without the --user \n> +argument.\n> +\n> Dependencies\n> ~~~~~~~~~~~~\n> \n> -- \n> 2.25.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0BF25C32E4\n\tfor ;\n\tTue, 23 Mar 2021 10:23:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 74BE368D69;\n\tTue, 23 Mar 2021 11:23:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7ABC68D47\n\tfor ;\n\tTue, 23 Mar 2021 11:23:15 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 00E0B885;\n\tTue, 23 Mar 2021 11:23:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"C/ycJ02K\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616494995;\n\tbh=IcZm86G6ZKM5qyFXvtbNRkpw/YVi350mJVRArE/ceqk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=C/ycJ02KUlyWSOO5nvtZv2oxRhqSBrzloSFKh7oP4dAmHEgpqqMDIScmHEkw6QiVB\n\tEZ5eRje26oZNDWkdJoXH556Wz6Qrs2zWsoOER4+fnY22u+K7DxOPGL4lQuzJtatSeV\n\tCJvvZLwDNVizOEH+CQjftULf9fqJpzY+5v6tHXZE=","Date":"Tue, 23 Mar 2021 19:23:07 +0900","From":"paul.elder@ideasonboard.com","To":"Vedant Paranjape ","Message-ID":"<20210323102307.GA2056@pyrite.rasen.tech>","References":"<20210322192400.76427-1-vedantparanjape160201@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210322192400.76427-1-vedantparanjape160201@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v5] Add alternative meson install\n\tcommand","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15827,"web_url":"https://patchwork.libcamera.org/comment/15827/","msgid":"<20210323102604.GB2056@pyrite.rasen.tech>","date":"2021-03-23T10:26:04","subject":"Re: [libcamera-devel] [PATCH v5] Add alternative meson install\n\tcommand","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Tue, Mar 23, 2021 at 07:23:07PM +0900, paul.elder@ideasonboard.com wrote:\n> Hi Vedant,\n> \n> Thank you for the patch.\n> \n> On Tue, Mar 23, 2021 at 12:54:00AM +0530, Vedant Paranjape wrote:\n> > Changes in v5:\n> > * Updated README.rst to describe meson install issue\n> > * Removed \"changelog\" heading from commit message\n> > * Fixed few grammatical mistakes\n> > * Reworded few sentences\n> \n> This belongs below ---\n> \n> > \n> > While installing meson using pip3 install --user meson, due to python\n> > path issues, build.ninja can't be located by ninja. meson generates\n> > ninja files fine, but then when you run ninja, it is unable to find\n> > meson's build.ninja python module due to path issues.\n> \n> I think you need some more detail on \"path issues\".\n\nOh never mind, it's in the content of the patch, so it's fine here.\n\n> \n> Also I think you should take in what what Nicolas said in review of v3.\n> \n> \n> Paul\n> \n> > It gives the following error on ninja -C build install:\n> > \n> > ninja: Entering directory `build'\n> > ninja: error: loading 'build.ninja': No such file or directory\n> > \n> > After uninstalling meson using pip3 and installing it again using pip\n> > without --user argument solved the issue.\n> > \n> > Signed-off-by: Vedant Paranjape \n> > ---\n> > README.rst | 16 ++++++++++++++++\n> > 1 file changed, 16 insertions(+)\n> > \n> > diff --git a/README.rst b/README.rst\n> > index 1427c714..39213dc4 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -37,6 +37,22 @@ To fetch the sources, build and install:\n> > meson build\n> > ninja -C build install\n> > \n> > +Several users have reported issues with meson installation, crux of the issue is a potential version\n> > +mismatch between the version that root uses, and the version that the normal user\n> > +uses. On calling `ninja -C build`, it can't find the build.ninja module. This the snippet of error message,\n\nLine length 75 characters.\n\n\nPaul\n\n> > +\n> > +:: \n> > +\n> > + ninja: Entering directory `build' \n> > + ninja: error: loading 'build.ninja': No such file or directory\n> > +\n> > +This can be solved in two ways: \n> > +\n> > +1) Don't install meson again if it is already installed system-wide.\n> > +2) If meson which is different from system-wide is already installed, \n> > +uninstall that meson using pip3, and install again without the --user \n> > +argument.\n> > +\n> > Dependencies\n> > ~~~~~~~~~~~~\n> > \n> > -- \n> > 2.25.1\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C3C63C32E4\n\tfor ;\n\tTue, 23 Mar 2021 10:26:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 37C8C68D69;\n\tTue, 23 Mar 2021 11:26:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4EF268D47\n\tfor ;\n\tTue, 23 Mar 2021 11:26:11 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9895F885;\n\tTue, 23 Mar 2021 11:26:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IrAhg85J\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616495171;\n\tbh=nx6B6XAKTjcINZRN83Ih+iAFh8Ce6W/bp4wzUQH0C7Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=IrAhg85JFK9rbnt/RFBRxRIBqiL49aiT04NjG2XmogzhMgu7VIkFV4ejjngfd/sxW\n\tJ3Lc5aOlxcSCCEyYPZ5mS+LZl8kPvALbbrqiqyNtyoPpc8tzJ1QKv+rkENBeFuBew6\n\tkaU7LHOeQhP9igwPef8yNgfuf+rDc5DSWOSDXX7E=","Date":"Tue, 23 Mar 2021 19:26:04 +0900","From":"paul.elder@ideasonboard.com","To":"Vedant Paranjape ,\n\tVedant Paranjape , g@ideasonboard.com","Message-ID":"<20210323102604.GB2056@pyrite.rasen.tech>","References":"<20210322192400.76427-1-vedantparanjape160201@gmail.com>\n\t<20210323102307.GA2056@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210323102307.GA2056@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH v5] Add alternative meson install\n\tcommand","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15832,"web_url":"https://patchwork.libcamera.org/comment/15832/","msgid":"","date":"2021-03-23T13:15:10","subject":"Re: [libcamera-devel] [PATCH v5] Add alternative meson install\n\tcommand","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Vedant,\n\nThank you for the patch.\n\nOn Tue, Mar 23, 2021 at 07:26:04PM +0900, paul.elder@ideasonboard.com wrote:\n> On Tue, Mar 23, 2021 at 07:23:07PM +0900, paul.elder@ideasonboard.com wrote:\n> > On Tue, Mar 23, 2021 at 12:54:00AM +0530, Vedant Paranjape wrote:\n> > > Changes in v5:\n> > > * Updated README.rst to describe meson install issue\n> > > * Removed \"changelog\" heading from commit message\n> > > * Fixed few grammatical mistakes\n> > > * Reworded few sentences\n> > \n> > This belongs below ---\n> > \n> > > \n> > > While installing meson using pip3 install --user meson, due to python\n> > > path issues, build.ninja can't be located by ninja. meson generates\n> > > ninja files fine, but then when you run ninja, it is unable to find\n> > > meson's build.ninja python module due to path issues.\n> > \n> > I think you need some more detail on \"path issues\".\n> \n> Oh never mind, it's in the content of the patch, so it's fine here.\n> \n> > \n> > Also I think you should take in what what Nicolas said in review of v3.\n> > \n> > > It gives the following error on ninja -C build install:\n> > > \n> > > ninja: Entering directory `build'\n> > > ninja: error: loading 'build.ninja': No such file or directory\n> > > \n> > > After uninstalling meson using pip3 and installing it again using pip\n> > > without --user argument solved the issue.\n> > > \n> > > Signed-off-by: Vedant Paranjape \n\nWhen applying this patch, I get\n\nApplying: Add alternative meson install command\n.git/rebase-apply/patch:17: trailing whitespace.\n::\n.git/rebase-apply/patch:19: trailing whitespace.\n ninja: Entering directory `build'\n.git/rebase-apply/patch:22: trailing whitespace.\nThis can be solved in two ways:\n.git/rebase-apply/patch:25: trailing whitespace.\n2) If meson which is different from system-wide is already installed,\n.git/rebase-apply/patch:26: trailing whitespace.\nuninstall that meson using pip3, and install again without the --user\nwarning: 5 lines add whitespace errors.\n\n> > > ---\n> > > README.rst | 16 ++++++++++++++++\n> > > 1 file changed, 16 insertions(+)\n> > > \n> > > diff --git a/README.rst b/README.rst\n> > > index 1427c714..39213dc4 100644\n> > > --- a/README.rst\n> > > +++ b/README.rst\n> > > @@ -37,6 +37,22 @@ To fetch the sources, build and install:\n> > > meson build\n> > > ninja -C build install\n> > > \n> > > +Several users have reported issues with meson installation, crux of the issue is a potential version\n> > > +mismatch between the version that root uses, and the version that the normal user\n> > > +uses. On calling `ninja -C build`, it can't find the build.ninja module. This the snippet of error message,\n> \n> Line length 75 characters.\n> \n> > > +\n> > > +:: \n> > > +\n> > > + ninja: Entering directory `build' \n> > > + ninja: error: loading 'build.ninja': No such file or directory\n> > > +\n> > > +This can be solved in two ways: \n> > > +\n> > > +1) Don't install meson again if it is already installed system-wide.\n> > > +2) If meson which is different from system-wide is already installed, \n> > > +uninstall that meson using pip3, and install again without the --user \n> > > +argument.\n\nThis isn't a correct ReST syntax.\n\nI've sent a patch (and CC'ed you) to get the whole of README.rst built\nas part of the documentation build to make sure we can catch this kind\nof issues.\n\n> > > +\n> > > Dependencies\n> > > ~~~~~~~~~~~~\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4CE46C32E4\n\tfor ;\n\tTue, 23 Mar 2021 13:15:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A35F0602D7;\n\tTue, 23 Mar 2021 14:15:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B45E6602D7\n\tfor ;\n\tTue, 23 Mar 2021 14:15:52 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 159A8885;\n\tTue, 23 Mar 2021 14:15:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ytf52cQW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616505352;\n\tbh=9LlnyO1rr2je51+njSoOtqq2Mh2aOOb6NPN+AS8Uv+c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Ytf52cQWl1NlX3Zg9BFJNAHzWN0Qh2UStuX7x60QtdVzy45tvNKCew2qlAnHsCizc\n\twBlg9782uyx2U5f1Dpc0zXSbOCoy4FZ4qaNrwePXk5rqYgyiI2jB4JFmR+9aDnL2T6\n\tTNUFliamCbzNAGG3OJpVaZpN1gONl5OjCpr7GPr0=","Date":"Tue, 23 Mar 2021 15:15:10 +0200","From":"Laurent Pinchart ","To":"paul.elder@ideasonboard.com","Message-ID":"","References":"<20210322192400.76427-1-vedantparanjape160201@gmail.com>\n\t<20210323102307.GA2056@pyrite.rasen.tech>\n\t<20210323102604.GB2056@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210323102604.GB2056@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH v5] Add alternative meson install\n\tcommand","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org,\n\tVedant Paranjape ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]