{"id":11637,"url":"https://patchwork.libcamera.org/api/patches/11637/?format=json","web_url":"https://patchwork.libcamera.org/patch/11637/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210322104242.31107-4-m.cichy@pengutronix.de>","date":"2021-03-22T10:42:42","name":"[libcamera-devel,3/3] gst: utils: Add framerate to caps","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7563fa4a7beb1db3a9b96e81bb9596ad47181a65","submitter":{"id":80,"url":"https://patchwork.libcamera.org/api/people/80/?format=json","name":"Marian Cichy","email":"m.cichy@pengutronix.de"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11637/mbox/","series":[{"id":1812,"url":"https://patchwork.libcamera.org/api/series/1812/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1812","date":"2021-03-22T10:42:39","name":"Add frame duration to stream configuration","version":1,"mbox":"https://patchwork.libcamera.org/series/1812/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11637/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11637/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD231C32E1\n\tfor ;\n\tMon, 22 Mar 2021 10:43:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C338E68D6C;\n\tMon, 22 Mar 2021 11:43:11 +0100 (CET)","from metis.ext.pengutronix.de (metis.ext.pengutronix.de\n\t[IPv6:2001:67c:670:201:290:27ff:fe1d:cc33])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D975468D60\n\tfor ;\n\tMon, 22 Mar 2021 11:43:08 +0100 (CET)","from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28])\n\tby metis.ext.pengutronix.de with esmtps\n\t(TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)\n\t(envelope-from )\n\tid 1lOI1c-0008Cg-2d; Mon, 22 Mar 2021 11:43:08 +0100","from mci by dude02.hi.pengutronix.de with local (Exim 4.92)\n\t(envelope-from )\n\tid 1lOI1b-00087b-Qp; Mon, 22 Mar 2021 11:43:07 +0100"],"From":"Marian Cichy ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 22 Mar 2021 11:42:42 +0100","Message-Id":"<20210322104242.31107-4-m.cichy@pengutronix.de>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20210322104242.31107-1-m.cichy@pengutronix.de>","References":"<20210322104242.31107-1-m.cichy@pengutronix.de>","MIME-Version":"1.0","X-SA-Exim-Connect-IP":"2001:67c:670:100:1d::28","X-SA-Exim-Mail-From":"mci@pengutronix.de","X-SA-Exim-Scanned":"No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false","X-PTX-Original-Recipient":"libcamera-devel@lists.libcamera.org","Subject":"[libcamera-devel] [PATCH 3/3] gst: utils: Add framerate to caps","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"graphics@pengutronix.de, Marian Cichy ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Access the frame duration from the controlList of the stream\nconfiguration and convert it to values fitting for GST_FRACTION. By\nsetting the frame rate to the caps configuration, the Gstreamer pipeline\nhas information about the camera frame rate, which can be potentially\nused for more efficient memory allocation or for debug purposes.\n\nSigned-off-by: Marian Cichy \n---\n src/gstreamer/gstlibcamera-utils.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex 5381dca5..fdd8b85c 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -8,6 +8,7 @@\n \n #include \"gstlibcamera-utils.h\"\n \n+#include \n #include \n \n using namespace libcamera;\n@@ -128,10 +129,16 @@ gst_libcamera_stream_configuration_to_caps(const StreamConfiguration &stream_cfg\n {\n \tGstCaps *caps = gst_caps_new_empty();\n \tGstStructure *s = bare_structure_from_format(stream_cfg.pixelFormat);\n+\tint numerator;\n+\tint denominator;\n+\tdouble framerate = 1'000'000 / static_cast(stream_cfg.controls.get(\n+\t\t\t\tcontrols::FrameDurations)[0]);\n \n+\tgst_util_double_to_fraction(framerate, &numerator, &denominator);\n \tgst_structure_set(s,\n \t\t\t \"width\", G_TYPE_INT, stream_cfg.size.width,\n \t\t\t \"height\", G_TYPE_INT, stream_cfg.size.height,\n+\t\t\t \"framerate\", GST_TYPE_FRACTION, numerator, denominator,\n \t\t\t nullptr);\n \tgst_caps_append_structure(caps, s);\n \n","prefixes":["libcamera-devel","3/3"]}