[{"id":15789,"web_url":"https://patchwork.libcamera.org/comment/15789/","msgid":"<20210322095439.GE9888@pyrite.rasen.tech>","date":"2021-03-22T09:54:39","subject":"Re: [libcamera-devel] [PATCH] Added alternative to meson install\n\tcommand, if it fails with --user argument","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Vedant,\n\nThank you for the patch.\n\nThe subject should be more concise, limited to 75 characters (you can go\nover by one word, maybe). I think Jacopo had a pretty good suggestion in\nhis review of v1.\n\nAlso for v2 the patch subject should have [PATCH v2], which you can put\nin automatically with git format-patch -v 2\n\nOn Mon, Mar 22, 2021 at 03:01:03PM +0530, Vedant Paranjape wrote:\n> While installing meson using pip3 install --user meson, due to python path issues, build.ninja can't be located by ninja.\n\nAll lines in the changelog should be line wrapped to 75 characters per\nline (with some exceptions allowed, for compiler error messages, for\nexample).\n\nAs for the content I think you have the gist. I would want some more\nelaboration on what kind of python path issues, though.\n\n> It gives the following error on ninja -C build install:\n> \n> ninja: Entering directory `build'\n> ninja: error: loading 'build.ninja': No such file or directory\n> \n> After uninstalling meson and installing it without --user argument solved the issue, as discussed with pinchartl on irc.\n\nSame here on line length.\n\nUninstalling meson where? From pip, or from the system package manager?\n\n> \n> Signed-off-by: Vedant Paranjape \n> ---\n> README.rst | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/README.rst b/README.rst\n> index 1427c714..0bfd39d9 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -56,7 +56,9 @@ Meson Build system: [required]\n> \n> pip3 install --user meson\n> pip3 install --user --upgrade meson\n> -\n> + \n> + If this fails, retry with `pip3 install meson`\n> + \n\nI assume you'll upgrade this in v3 :)\n\n\nPaul\n\n> for the libcamera core: [required]\n> python3-yaml python3-ply python3-jinja2\n> \n> -- \n> 2.25.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9DE5FC32E1\n\tfor ;\n\tMon, 22 Mar 2021 09:54:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BA17668D58;\n\tMon, 22 Mar 2021 10:54:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B2746051E\n\tfor ;\n\tMon, 22 Mar 2021 10:54:49 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0185BAD6;\n\tMon, 22 Mar 2021 10:54:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Gu4AOU2s\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616406888;\n\tbh=2dgArTz4oGMSaAXe4rp08TOhRfCkuhs8+fBe3hMtNcc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Gu4AOU2ssPe+srLNbDlL9Q9LMpBkltcMW1xYC6IKpnbmIgldERXgzuP0cKJ0uPRt9\n\tWKOH/Ju/Dh2khMS8JKcUeWSrfjkAR7gHdZwVlyzF18PWs9segPipHgWsyve17s681c\n\taaFhvacOqHZJP/T+irtEetqYT2NGFA0gWj4NTQbo=","Date":"Mon, 22 Mar 2021 18:54:39 +0900","From":"paul.elder@ideasonboard.com","To":"Vedant Paranjape ","Message-ID":"<20210322095439.GE9888@pyrite.rasen.tech>","References":"<20210322093103.34842-1-vedantparanjape160201@gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210322093103.34842-1-vedantparanjape160201@gmail.com>","Subject":"Re: [libcamera-devel] [PATCH] Added alternative to meson install\n\tcommand, if it fails with --user argument","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15790,"web_url":"https://patchwork.libcamera.org/comment/15790/","msgid":"","date":"2021-03-22T10:09:58","subject":"Re: [libcamera-devel] [PATCH] Added alternative to meson install\n\tcommand, if it fails with --user argument","submitter":{"id":85,"url":"https://patchwork.libcamera.org/api/people/85/","name":"Vedant Paranjape","email":"vedantparanjape160201@gmail.com"},"content":"Thanks for the feedback! Is there any way to enforce character limit ?\n\nOn Mon, Mar 22, 2021 at 3:24 PM wrote:\n\n> Hi Vedant,\n>\n> Thank you for the patch.\n>\n> The subject should be more concise, limited to 75 characters (you can go\n> over by one word, maybe). I think Jacopo had a pretty good suggestion in\n> his review of v1.\n>\n> Also for v2 the patch subject should have [PATCH v2], which you can put\n> in automatically with git format-patch -v 2\n>\n> On Mon, Mar 22, 2021 at 03:01:03PM +0530, Vedant Paranjape wrote:\n> > While installing meson using pip3 install --user meson, due to python\n> path issues, build.ninja can't be located by ninja.\n>\n> All lines in the changelog should be line wrapped to 75 characters per\n> line (with some exceptions allowed, for compiler error messages, for\n> example).\n>\n> As for the content I think you have the gist. I would want some more\n> elaboration on what kind of python path issues, though.\n>\n> > It gives the following error on ninja -C build install:\n> >\n> > ninja: Entering directory `build'\n> > ninja: error: loading 'build.ninja': No such file or directory\n> >\n> > After uninstalling meson and installing it without --user argument\n> solved the issue, as discussed with pinchartl on irc.\n>\n> Same here on line length.\n>\n> Uninstalling meson where? From pip, or from the system package manager?\n>\n> >\n> > Signed-off-by: Vedant Paranjape \n> > ---\n> > README.rst | 4 +++-\n> > 1 file changed, 3 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/README.rst b/README.rst\n> > index 1427c714..0bfd39d9 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -56,7 +56,9 @@ Meson Build system: [required]\n> >\n> > pip3 install --user meson\n> > pip3 install --user --upgrade meson\n> > -\n> > +\n> > + If this fails, retry with `pip3 install meson`\n> > +\n>\n> I assume you'll upgrade this in v3 :)\n>\n>\n> Paul\n>\n> > for the libcamera core: [required]\n> > python3-yaml python3-ply python3-jinja2\n> >\n> > --\n> > 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AA51BC32E1\n\tfor ;\n\tMon, 22 Mar 2021 10:10:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BEE7A68D65;\n\tMon, 22 Mar 2021 11:10:13 +0100 (CET)","from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com\n\t[IPv6:2607:f8b0:4864:20::b2c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B12026051E\n\tfor ;\n\tMon, 22 Mar 2021 11:10:11 +0100 (CET)","by mail-yb1-xb2c.google.com with SMTP id w8so5931005ybt.3\n\tfor ;\n\tMon, 22 Mar 2021 03:10:11 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"oy3dyQBY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=DCZlvmqzFCNMojvFbuuDdGUoRDwgEq6kbW1/rppvcho=;\n\tb=oy3dyQBYSSh8EFM+lRwb1wQSeQlqFWScIqlFyTRiTPRFesJ7PKG81XN8wK95xa7XEd\n\tnYRaVyuMRzEvxrUdinXv2e70t8p3jkZYPxoXKXiq59PdRpcNJ5jRU3TwFAp+RE92GYGC\n\t0nC6NOTiU9RwOR1IdQs22SKxIDImHl1HAx+goq2ejsb9A23eKN6vyqRfrEUWV2i1EoCs\n\tf0GcLyQLjw6YJ2OAXNXLwSJrlSi0fKlX93i68MoHKzXeWtijiHNR3Rh8ngjKe01JeZT+\n\tAGUhT4+1nsYiY2+u6bSaNGW2ItE/V3QwUbQwo3uueabP/XX5CQZkkgpjBIqcqKRgLYjw\n\t41tA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=DCZlvmqzFCNMojvFbuuDdGUoRDwgEq6kbW1/rppvcho=;\n\tb=JuCiZSRjxGGBxu70Hz6uiP6oUq+U2/c7g2nQcc4c1do64HDz2ET7LUMQr4jpsfnueR\n\tVmTGfZsllqGt7xpyGUtt0Fqv0pB4MDh0kYJ5wttGF2B78t+zmUXu7MQ7wCujXz7eCiMN\n\tcXNlkrIoQVa/m8mzsGI11fHmJw5XVZy6uBUozjDZ3K1ass6ERQWSo9SBQN5UKkeHsQC6\n\tFTCYsMeZHReIcVps7z47yMTTWvDicDv58EOZgFroGuMiYbT6vPqZwU1D1iT+4XvPIn1n\n\tyvX4n2x5Qb1hvDeEZzZUFGD5Qpm6uRCZhman+bL0+hgb86IUCpsp53AR4MDG7A+0SY3R\n\tVrxA==","X-Gm-Message-State":"AOAM532+nyziGwfXSjv5xjcIjS24NRDMZW9TwJCI7/WzfAjb1ShvSdxl\n\tP6sDXItVN5YGM+wzTJ4fdt98TtHJVkwYGjI0b22SXTi7pP25tQ==","X-Google-Smtp-Source":"ABdhPJwc89wFF6hI8GNfOm7VAckc6ZtZZ1RIRZk+YhAJcEzlPHQeCOnw8JVcvPJxK3qFYR7kA4MfF/M6ZIJrIPOSTgQ=","X-Received":"by 2002:a25:1008:: with SMTP id 8mr23380349ybq.21.1616407810417; \n\tMon, 22 Mar 2021 03:10:10 -0700 (PDT)","MIME-Version":"1.0","References":"<20210322093103.34842-1-vedantparanjape160201@gmail.com>\n\t<20210322095439.GE9888@pyrite.rasen.tech>","In-Reply-To":"<20210322095439.GE9888@pyrite.rasen.tech>","From":"Vedant Paranjape ","Date":"Mon, 22 Mar 2021 15:39:58 +0530","Message-ID":"","To":"paul.elder@ideasonboard.com","Subject":"Re: [libcamera-devel] [PATCH] Added alternative to meson install\n\tcommand, if it fails with --user argument","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/mixed;\n\tboundary=\"===============5920769673971975923==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]