[{"id":15770,"web_url":"https://patchwork.libcamera.org/comment/15770/","msgid":"<20210319164429.73o5usoujjmq7wlf@basti-TUXEDO-Book-XA1510>","date":"2021-03-19T16:44:29","subject":"Re: [libcamera-devel] [PATCH] pipeline: simple: Update\n\tdocumentation on pipeline setup","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"Hey Marian,\n\nThank you for the patch.\n\nOn 19.03.2021 17:03, Marian Cichy wrote:\n>After 4671911df040, the explanation in the SimplePipeline documentation\n>how the handler tries to find a valid path to capture device doest not\n\ns/doest not/doesn't/\n\n>reflect the reality anymore. Update the text to the new situation.\n>\n>Fixes: 4671911df040 (\"pipeline: simple: Use breadth-first search to\n>setup media pipeline\")\n>\n>Signed-off-by: Marian Cichy \n>---\n> src/libcamera/pipeline/simple/simple.cpp | 11 ++++++-----\n> 1 file changed, 6 insertions(+), 5 deletions(-)\n>\n>diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n>index 068fb454..39f3d019 100644\n>--- a/src/libcamera/pipeline/simple/simple.cpp\n>+++ b/src/libcamera/pipeline/simple/simple.cpp\n>@@ -69,11 +69,12 @@ LOG_DEFINE_CATEGORY(SimplePipeline)\n> *\n> * When matching a device, the pipeline handler enumerates all camera sensors\n> * and attempts, for each of them, to find a path to a video capture video node.\n>- * It does so by traversing the media graph, following the first non permanently\n>- * disabled downstream link. If such a path is found, the pipeline handler\n>- * creates a corresponding SimpleCameraData instance, and stores the media graph\n>- * path in its entities_ list.\n>- *\n>+ * It does so by using a breadth-first search to find the shortest path from the\n>+ * sensor device to a valid capture device. This is guaranteed to produce a\n>+ * valid path on devices with one only option and is a good heuristic on more\n\ns/with one only option/with a single option\n\n>+ * complex devices to skip paths that aren't suitable for the simple pipeline\n>+ * handler. For instance, on the IPU-based i.MX6, the shortest path will skip\n>+ * encoders and image converts, and it will end in a CSI capture device.\n\ns/image converts/image converters/\n\n> * A more complex graph search algorithm could be implemented if a device that\n> * would otherwise be compatible with the pipeline handler isn't correctly\n> * handled by this heuristic.\n>-- \n>2.29.2\n\nYou can add:\nReviewed-by: Sebastian Fricke \nif you like :).\n\nGreetings,\nSebastian\n>\n>_______________________________________________\n>libcamera-devel mailing list\n>libcamera-devel@lists.libcamera.org\n>https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9AA5BD80C\n\tfor ;\n\tFri, 19 Mar 2021 16:44:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2183068D62;\n\tFri, 19 Mar 2021 17:44:33 +0100 (CET)","from mout01.posteo.de (mout01.posteo.de [185.67.36.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC8456051E\n\tfor ;\n\tFri, 19 Mar 2021 17:44:30 +0100 (CET)","from submission (posteo.de [89.146.220.130]) \n\tby mout01.posteo.de (Postfix) with ESMTPS id 4409F16005C\n\tfor ;\n\tFri, 19 Mar 2021 17:44:30 +0100 (CET)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4F28qx4pKGz9rxW;\n\tFri, 19 Mar 2021 17:44:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"HapXJGhp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1616172270; bh=egsb/nTl5mEoJKJZ1kisI5S29xD1+x8Kf74P2T4wW6k=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=HapXJGhprBNatpQBCA4RmYr/wPwPpInuyQKrP4TQrzj4iCY3UC2D/9EqjDiREq8eK\n\tN1i7cweMQmhSAP84SbkMRcWVYIgsK9urpEaeuPLNY1a62H68+LFpglYzlNxIBFDlHJ\n\tR2iWmywXi8IPKC9GGC/+c/IwsFR2qIZCaks8xofTXY4Ksvep40rTR1ltbiobLxgBm4\n\tijTvFilLEnPBdmahKA0+89lL+xbtnlSvoh5dgOM0aSoMUrcgl4TexG0iRMchQEeCil\n\tWyrnYR8bBrd/lTVO4APNVkEk09vlltEm3Bp+fybRmqGRM4/ATy5QT1jR3d3NmKeEnX\n\tEKoS8MhN1FyLw==","Date":"Fri, 19 Mar 2021 17:44:29 +0100","From":"Sebastian Fricke ","To":"Marian Cichy ","Message-ID":"<20210319164429.73o5usoujjmq7wlf@basti-TUXEDO-Book-XA1510>","References":"<20210319160322.13029-1-m.cichy@pengutronix.de>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210319160322.13029-1-m.cichy@pengutronix.de>","Subject":"Re: [libcamera-devel] [PATCH] pipeline: simple: Update\n\tdocumentation on pipeline setup","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org, graphics@pengutronix.de","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15772,"web_url":"https://patchwork.libcamera.org/comment/15772/","msgid":"","date":"2021-03-20T20:22:48","subject":"Re: [libcamera-devel] [PATCH] pipeline: simple: Update\n\tdocumentation on pipeline setup","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Marian,\n\nThank you for the patch.\n\nOn Fri, Mar 19, 2021 at 05:44:29PM +0100, Sebastian Fricke wrote:\n> On 19.03.2021 17:03, Marian Cichy wrote:\n> > After 4671911df040, the explanation in the SimplePipeline documentation\n\nTo make it easier for the reader, commits should be quoted with their\nsubject line:\n\nAfter commit 4671911df040 (\"pipeline: simple: Use breadth-first search\nto setup media pipeline\"), the explanation ...\n\n> > how the handler tries to find a valid path to capture device doest not\n> \n> s/doest not/doesn't/\n\nOr 'does not'.\n\n> > reflect the reality anymore. Update the text to the new situation.\n> > \n> > Fixes: 4671911df040 (\"pipeline: simple: Use breadth-first search to\n> > setup media pipeline\")\n\nNo line break, you can go over the 72 columns limit for Fixes lines.\n\nReviewed-by: Laurent Pinchart \n\nI'll address these small issues when applying, no need to resubmit.\n\n> > Signed-off-by: Marian Cichy \n> > ---\n> > src/libcamera/pipeline/simple/simple.cpp | 11 ++++++-----\n> > 1 file changed, 6 insertions(+), 5 deletions(-)\n> > \n> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > index 068fb454..39f3d019 100644\n> > --- a/src/libcamera/pipeline/simple/simple.cpp\n> > +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > @@ -69,11 +69,12 @@ LOG_DEFINE_CATEGORY(SimplePipeline)\n> > *\n> > * When matching a device, the pipeline handler enumerates all camera sensors\n> > * and attempts, for each of them, to find a path to a video capture video node.\n> > - * It does so by traversing the media graph, following the first non permanently\n> > - * disabled downstream link. If such a path is found, the pipeline handler\n> > - * creates a corresponding SimpleCameraData instance, and stores the media graph\n> > - * path in its entities_ list.\n> > - *\n> > + * It does so by using a breadth-first search to find the shortest path from the\n> > + * sensor device to a valid capture device. This is guaranteed to produce a\n> > + * valid path on devices with one only option and is a good heuristic on more\n> \n> s/with one only option/with a single option\n> \n> > + * complex devices to skip paths that aren't suitable for the simple pipeline\n> > + * handler. For instance, on the IPU-based i.MX6, the shortest path will skip\n> > + * encoders and image converts, and it will end in a CSI capture device.\n> \n> s/image converts/image converters/\n> \n> > * A more complex graph search algorithm could be implemented if a device that\n> > * would otherwise be compatible with the pipeline handler isn't correctly\n> > * handled by this heuristic.\n> \n> You can add:\n> Reviewed-by: Sebastian Fricke \n> if you like :).","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0E49BBD80C\n\tfor ;\n\tSat, 20 Mar 2021 20:23:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3124168D60;\n\tSat, 20 Mar 2021 21:23:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 071B5602DB\n\tfor ;\n\tSat, 20 Mar 2021 21:23:29 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 78606883;\n\tSat, 20 Mar 2021 21:23:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"e+c2Ytpp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616271808;\n\tbh=aa8fKMSMExYTQSe9nWuiURSp8brU54zhp90CDlOgSRw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=e+c2YtppZ5tqPqHWMyrxDuc7hdKQxuGtZs07D/EjiSKxJ44qQGXkkmilGjjL767cY\n\t/CMVGZk86CNUJRnyWOxrM3EZJEY4kv0vxsjKqbx+WQ7jczej/EvgIZFI0QklAPuR3T\n\tepckLBxvAS+EyyBG5Ab5AKRxqa1pscvoETbiQkdk=","Date":"Sat, 20 Mar 2021 22:22:48 +0200","From":"Laurent Pinchart ","To":"Marian Cichy ","Message-ID":"","References":"<20210319160322.13029-1-m.cichy@pengutronix.de>\n\t<20210319164429.73o5usoujjmq7wlf@basti-TUXEDO-Book-XA1510>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210319164429.73o5usoujjmq7wlf@basti-TUXEDO-Book-XA1510>","Subject":"Re: [libcamera-devel] [PATCH] pipeline: simple: Update\n\tdocumentation on pipeline setup","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org, graphics@pengutronix.de","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]