[{"id":15781,"web_url":"https://patchwork.libcamera.org/comment/15781/","msgid":"<20210322055531.GC3413@pyrite.rasen.tech>","date":"2021-03-22T05:55:31","subject":"Re: [libcamera-devel] [PATCH v2 3/3] android: camera_device: Do not\n\tdefault External to Front","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Fri, Mar 19, 2021 at 02:01:20PM +0100, Jacopo Mondi wrote:\n> Now that the camera location is not defaulted anymore in the library but\n> doesn't get registered if the firmware interface does not provide the\n> information, do not default it to FRONT if LocationExternal is reported.\n> \n> To maintain compatibility with CTS requirements, default location to\n> FRONT only if the camera property is not available.\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/android/camera_device.cpp | 12 +++++++-----\n> 1 file changed, 7 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index a81e3c905d6c..72a89258386d 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -376,13 +376,15 @@ int CameraDevice::initialize()\n> \t\t\tfacing_ = CAMERA_FACING_BACK;\n> \t\t\tbreak;\n> \t\tcase properties::CameraLocationExternal:\n> -\t\t\t/*\n> -\t\t\t * \\todo Set this to EXTERNAL once we support\n> -\t\t\t * HARDWARE_LEVEL_EXTERNAL\n> -\t\t\t */\n> -\t\t\tfacing_ = CAMERA_FACING_FRONT;\n> +\t\t\tfacing_ = CAMERA_FACING_EXTERNAL;\n> \t\t\tbreak;\n> \t\t}\n> +\t} else {\n> +\t\t/*\n> +\t\t * \\todo Retrieve the camera location from configuration file\n> +\t\t * if not available from the library.\n> +\t\t */\n> +\t\tfacing_ = CAMERA_FACING_FRONT;\n> \t}\n> \n> \t/*\n> -- \n> 2.30.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 46647C32E1\n\tfor ;\n\tMon, 22 Mar 2021 05:55:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C385468D61;\n\tMon, 22 Mar 2021 06:55:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7DC1602D7\n\tfor ;\n\tMon, 22 Mar 2021 06:55:38 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 411A18CE;\n\tMon, 22 Mar 2021 06:55:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gU5FGmSr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616392538;\n\tbh=jdtiepVU3gaBFaAUNkDKWGRDauIlbQJKGQnCvL+3AzM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gU5FGmSrxXYV7qQuEzPv9m9ceZa+vQeEomAbju3d4aHmVA1iWOYytImbN+wenL0jd\n\t5jly+5xCFo9mUVS7GG3+e3eb8oTMtn2O+i7CQInsR5v9Whxsvkyz9vY/wfRKVcLHpF\n\tL5p5ZR9cMdPCtecAol9/046vomZhXSPHfeoGFXYs=","Date":"Mon, 22 Mar 2021 14:55:31 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20210322055531.GC3413@pyrite.rasen.tech>","References":"<20210319130120.141563-1-jacopo@jmondi.org>\n\t<20210319130120.141563-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210319130120.141563-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 3/3] android: camera_device: Do not\n\tdefault External to Front","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]