[{"id":15780,"web_url":"https://patchwork.libcamera.org/comment/15780/","msgid":"<20210322055226.GB3413@pyrite.rasen.tech>","date":"2021-03-22T05:52:26","subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: camera_sensor: Do\n\tnot register Location if not available","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Fri, Mar 19, 2021 at 02:01:19PM +0100, Jacopo Mondi wrote:\n> Do not register the Location property if not available from the firmware\n> interface instead of defaulting it to External.\n> \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/camera_sensor.cpp | 6 ++----\n> 1 file changed, 2 insertions(+), 4 deletions(-)\n> \n> diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\n> index 27f82071151e..f7ed91d990f7 100644\n> --- a/src/libcamera/camera_sensor.cpp\n> +++ b/src/libcamera/camera_sensor.cpp\n> @@ -468,12 +468,10 @@ int CameraSensor::initProperties()\n> \t\t\tpropertyValue = properties::CameraLocationBack;\n> \t\t\tbreak;\n> \t\t}\n> +\t\tproperties_.set(properties::Location, propertyValue);\n> \t} else {\n> -\t\tLOG(CameraSensor, Warning)\n> -\t\t\t<< \"Failed to retrieve the camera location, setting to External\";\n> -\t\tpropertyValue = properties::CameraLocationExternal;\n> +\t\tLOG(CameraSensor, Warning) << \"Failed to retrieve the camera location\";\n> \t}\n> -\tproperties_.set(properties::Location, propertyValue);\n> \n> \tconst auto &rotationControl = controls.find(V4L2_CID_CAMERA_SENSOR_ROTATION);\n> \tif (rotationControl != controls.end()) {\n> -- \n> 2.30.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C7DFBD80C\n\tfor ;\n\tMon, 22 Mar 2021 05:52:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0EEE68D58;\n\tMon, 22 Mar 2021 06:52:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C6F5B602D7\n\tfor ;\n\tMon, 22 Mar 2021 06:52:34 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5A5F18CE;\n\tMon, 22 Mar 2021 06:52:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Z++fCkH9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616392354;\n\tbh=BzF9bwj2giQg4LNhuxTfboeCE2yrVDoyiLQA2CpXtR4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Z++fCkH9m7LDSHfyhpnNZwGCtJUOcfkBz0GoLJ+8u0G1Y00lep4rxHIZOLFCQ82gX\n\tUKAtxr3PDhjnT/iKRjy+3HrkbrO4aWRGyheuf34su286UmVZbURr49fwABDi22q/dk\n\txhVQWEW3y92bYAUs5Fx7NRptHo5lnEBYWbsZe/VM=","Date":"Mon, 22 Mar 2021 14:52:26 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20210322055226.GB3413@pyrite.rasen.tech>","References":"<20210319130120.141563-1-jacopo@jmondi.org>\n\t<20210319130120.141563-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210319130120.141563-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: camera_sensor: Do\n\tnot register Location if not available","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]