[{"id":15758,"web_url":"https://patchwork.libcamera.org/comment/15758/","msgid":"<9104ed8a-c1c3-dd22-198b-a37fe73da808@pengutronix.de>","date":"2021-03-18T14:17:01","subject":"Re: [libcamera-devel] [PATCH] libcamera: request: Fix documentation\n\tof controls() method","submitter":{"id":81,"url":"https://patchwork.libcamera.org/api/people/81/","name":"Marian Cichy","email":"mci@pengutronix.de"},"content":"On 3/18/21 3:11 PM, Marian Cichy wrote:\n> The documentation of the controls() method refers to the methods\n> ControlList::operator[]() and ControlList::update(), which do not exist.\n>\n> Instead refer to ControlList::get() and ControlList::set() to achieve a\n> similar documentation.\n>\n> Signed-off-by: Marian Cichy \n> ---\n> src/libcamera/request.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index 24c3694d..fe521ae2 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -138,8 +138,8 @@ void Request::reuse(ReuseFlag flags)\n> *\n> * Requests store a list of controls to be applied to all frames captured for\n> * the request. They are created with an empty list of controls that can be\n> - * accessed through this method and updated with ControlList::operator[]() or\n> - * ControlList::update().\n> + * accessed through this method. Control values can be retrieved using\n> + * Control::get() and updated using Control::set().\n\nthis was supposed to be ControlList::get() and ControlList::set() as in \nthe commit message. Sorry!\n\n> *\n> * Only controls supported by the camera to which this request will be\n> * submitted shall be included in the controls list. Attempting to add an","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DBAEABD80C\n\tfor ;\n\tThu, 18 Mar 2021 14:17:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 65F1D68D5E;\n\tThu, 18 Mar 2021 15:17:03 +0100 (CET)","from metis.ext.pengutronix.de (metis.ext.pengutronix.de\n\t[IPv6:2001:67c:670:201:290:27ff:fe1d:cc33])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 29779602DB\n\tfor ;\n\tThu, 18 Mar 2021 15:17:02 +0100 (CET)","from erdnuss.hi.pengutronix.de\n\t([2001:67c:670:100:2e4d:54ff:fe9d:849c])\n\tby metis.ext.pengutronix.de with esmtp (Exim 4.92)\n\t(envelope-from )\n\tid 1lMtSP-0002vc-C9; Thu, 18 Mar 2021 15:17:01 +0100"],"To":"libcamera-devel@lists.libcamera.org","References":"<20210318141124.12014-1-m.cichy@pengutronix.de>","From":"Marian Cichy ","Message-ID":"<9104ed8a-c1c3-dd22-198b-a37fe73da808@pengutronix.de>","Date":"Thu, 18 Mar 2021 15:17:01 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.8.0","MIME-Version":"1.0","In-Reply-To":"<20210318141124.12014-1-m.cichy@pengutronix.de>","Content-Language":"en-US","X-SA-Exim-Connect-IP":"2001:67c:670:100:2e4d:54ff:fe9d:849c","X-SA-Exim-Mail-From":"mci@pengutronix.de","X-SA-Exim-Scanned":"No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false","X-PTX-Original-Recipient":"libcamera-devel@lists.libcamera.org","Subject":"Re: [libcamera-devel] [PATCH] libcamera: request: Fix documentation\n\tof controls() method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"graphics@pengutronix.de","Content-Transfer-Encoding":"7bit","Content-Type":"text/plain; charset=\"us-ascii\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15759,"web_url":"https://patchwork.libcamera.org/comment/15759/","msgid":"","date":"2021-03-18T23:38:13","subject":"Re: [libcamera-devel] [PATCH] libcamera: request: Fix documentation\n\tof controls() method","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Marian,\n\nThank you for the patch.\n\nOn Thu, Mar 18, 2021 at 03:17:01PM +0100, Marian Cichy wrote:\n> On 3/18/21 3:11 PM, Marian Cichy wrote:\n> > The documentation of the controls() method refers to the methods\n> > ControlList::operator[]() and ControlList::update(), which do not exist.\n> >\n> > Instead refer to ControlList::get() and ControlList::set() to achieve a\n> > similar documentation.\n> >\n\nI'll add\n\nFixes: a8c40942b99e (\"libcamera: controls: Improve the API towards applications\")\n\n> > Signed-off-by: Marian Cichy \n> > ---\n> > src/libcamera/request.cpp | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> > index 24c3694d..fe521ae2 100644\n> > --- a/src/libcamera/request.cpp\n> > +++ b/src/libcamera/request.cpp\n> > @@ -138,8 +138,8 @@ void Request::reuse(ReuseFlag flags)\n> > *\n> > * Requests store a list of controls to be applied to all frames captured for\n> > * the request. They are created with an empty list of controls that can be\n> > - * accessed through this method and updated with ControlList::operator[]() or\n> > - * ControlList::update().\n> > + * accessed through this method. Control values can be retrieved using\n> > + * Control::get() and updated using Control::set().\n> \n> this was supposed to be ControlList::get() and ControlList::set() as in \n> the commit message. Sorry!\n\nFix applied in my branch.\n\nReviewed-by: Laurent Pinchart \n\n> > *\n> > * Only controls supported by the camera to which this request will be\n> > * submitted shall be included in the controls list. Attempting to add an","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A06BC32E1\n\tfor ;\n\tThu, 18 Mar 2021 23:38:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B9A4D68D67;\n\tFri, 19 Mar 2021 00:38:54 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3EEF46084F\n\tfor ;\n\tFri, 19 Mar 2021 00:38:52 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A36204FD;\n\tFri, 19 Mar 2021 00:38:51 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uJxFXv3T\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616110731;\n\tbh=sAZl5j/aDoRMLbzUl/biR/0TwH3hcG2RQEftYQUTAUg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uJxFXv3TuzJbGGod54cLxMFh3pzPD9fwzNLvsEkt5z0w3fC9heWPvw+BjJckZxT5q\n\tEO3AWPDXHmpfpox46j3dX3i3nyaOYseqG8f1Octy5Z3re2D5LY3iAhNoISPDQOc7i+\n\tnhqlOtcXFkWnMk7TxfK9A6zQIiIBIDcMhUulFBWk=","Date":"Fri, 19 Mar 2021 01:38:13 +0200","From":"Laurent Pinchart ","To":"Marian Cichy ","Message-ID":"","References":"<20210318141124.12014-1-m.cichy@pengutronix.de>\n\t<9104ed8a-c1c3-dd22-198b-a37fe73da808@pengutronix.de>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<9104ed8a-c1c3-dd22-198b-a37fe73da808@pengutronix.de>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: request: Fix documentation\n\tof controls() method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org, graphics@pengutronix.de","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]