[{"id":15765,"web_url":"https://patchwork.libcamera.org/comment/15765/","msgid":"","date":"2021-03-19T00:08:09","subject":"Re: [libcamera-devel] [PATCH 2/2] android: camera_device: Do not\n\tdefault External to Front","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Mar 18, 2021 at 01:55:21PM +0100, Jacopo Mondi wrote:\n> Now that the camera location is not defaulted anymore in the library but\n> doesn't get registered if the firmware interface does not provide the\n> information, do not default it to FRONT if LocationExternal is reported.\n> \n> To maintain compatibility with CTS requirements, default location to\n> FRONT only if the camera property is not available.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 6 +-----\n> 1 file changed, 1 insertion(+), 5 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index a81e3c905d6c..a65b978ffc32 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -376,11 +376,7 @@ int CameraDevice::initialize()\n> \t\t\tfacing_ = CAMERA_FACING_BACK;\n> \t\t\tbreak;\n> \t\tcase properties::CameraLocationExternal:\n> -\t\t\t/*\n> -\t\t\t * \\todo Set this to EXTERNAL once we support\n> -\t\t\t * HARDWARE_LEVEL_EXTERNAL\n> -\t\t\t */\n> -\t\t\tfacing_ = CAMERA_FACING_FRONT;\n> +\t\t\tfacing_ = CAMERA_FACING_EXTERNAL;\n> \t\t\tbreak;\n> \t\t}\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0DE94C32E1\n\tfor ;\n\tFri, 19 Mar 2021 00:08:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49AEC68D51;\n\tFri, 19 Mar 2021 01:08:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04B486051D\n\tfor ;\n\tFri, 19 Mar 2021 01:08:48 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 767454FD;\n\tFri, 19 Mar 2021 01:08:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"O6YOfvMf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616112527;\n\tbh=vBPm3Y2vnRu1GrjeAmWo6qBcZqZDiPTRZtXcemk+RBo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=O6YOfvMfjh1wqzAD5dJ9RamtCFaHc14gol/4k+wPq6GfL269nXY9LypVSkK6gV48l\n\tZOvlS5919a5C36j756HvkhloxHhf7keJg/1tTkO4H3nf8OrU71d1Ps1J/bp7xTy8HC\n\tW+tzswd0maStj1F/HdIU/f9KYvh9ppz5Gg7DNGAc=","Date":"Fri, 19 Mar 2021 02:08:09 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210318125521.43278-1-jacopo@jmondi.org>\n\t<20210318125521.43278-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210318125521.43278-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 2/2] android: camera_device: Do not\n\tdefault External to Front","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]