[{"id":15855,"web_url":"https://patchwork.libcamera.org/comment/15855/","msgid":"<64b59b34-a45e-b532-5030-c46db14f04c6@ideasonboard.com>","date":"2021-03-24T07:16:24","subject":"Re: [libcamera-devel] [PATCH 5/7] libcamera: ipu3: imgu: Fix BSD\n\theight size comparison","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Jacopo,\n\nThanks for the patch,\n\nOn 18/03/2021 11:39, Jacopo Mondi wrote:\n> Fix a size comparison when iterating on the BDS sizes to align it with\n> the python scritp implementation.\ns/scritp/script\n\n> \n> Signed-off-by: Jacopo Mondi \nTested-by: Jean-Michel Hautbois \nReviewed-by: Jean-Michel Hautbois \n\n> ---\n> src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> index 89a01bddbed2..ccc85864fc39 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> @@ -182,7 +182,7 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe, const Size &iif, const Size &gdc\n> \t\t}\n> \t} else {\n> \t\tifHeight = utils::alignUp(iif.height, IF_ALIGN_H);\n> -\t\twhile (ifHeight > minIFHeight && ifHeight / bdsSF >= minBDSHeight) {\n> +\t\twhile (ifHeight >= minIFHeight && ifHeight / bdsSF >= minBDSHeight) {\n> \n> \t\t\tbdsHeight = ifHeight / bdsSF;\n> \t\t\tif (std::fmod(ifHeight, 1.0) == 0 && std::fmod(bdsHeight, 1.0) == 0) {\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B097EC32E7\n\tfor ;\n\tWed, 24 Mar 2021 07:16:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6DE7B68D63;\n\tWed, 24 Mar 2021 08:16:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD34068D47\n\tfor ;\n\tWed, 24 Mar 2021 08:16:24 +0100 (CET)","from [IPv6:2a01:e0a:169:7140:21bd:98cc:c21e:1364] (unknown\n\t[IPv6:2a01:e0a:169:7140:21bd:98cc:c21e:1364])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6B8E9580;\n\tWed, 24 Mar 2021 08:16:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"L9MMA/vE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616570184;\n\tbh=1Y7vDi2H2i7ok56vsjIfTAXVqanSRRWAHLc5jejUg4o=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=L9MMA/vEq1JBPzofMp46tZMMhdNFZo+17p63FcvHZEB7ftjDhaZShgRSa+767DWs+\n\tcFGTQ8kYn+UG9Q5rj+ME2Hu7iVI2WFLb6Gnv0IR/pVhbv+o0wx8lYhYf5jED/RrsZN\n\tW6AixEY5Vy2cIQ8OYD3IzMU+WzsdfOQqG0IJGU1A=","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20210318103941.18837-1-jacopo@jmondi.org>\n\t<20210318103941.18837-6-jacopo@jmondi.org>","From":"Jean-Michel Hautbois ","Message-ID":"<64b59b34-a45e-b532-5030-c46db14f04c6@ideasonboard.com>","Date":"Wed, 24 Mar 2021 08:16:24 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"<20210318103941.18837-6-jacopo@jmondi.org>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 5/7] libcamera: ipu3: imgu: Fix BSD\n\theight size comparison","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":16194,"web_url":"https://patchwork.libcamera.org/comment/16194/","msgid":"","date":"2021-04-12T23:59:46","subject":"Re: [libcamera-devel] [PATCH 5/7] libcamera: ipu3: imgu: Fix BSD\n\theight size comparison","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Mar 18, 2021 at 11:39:39AM +0100, Jacopo Mondi wrote:\n> Fix a size comparison when iterating on the BDS sizes to align it with\n> the python scritp implementation.\n\nThe change seems to be correct, but it would be best to explain why in\nthe commit message, not just mention the python script.\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\n> index 89a01bddbed2..ccc85864fc39 100644\n> --- a/src/libcamera/pipeline/ipu3/imgu.cpp\n> +++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n> @@ -182,7 +182,7 @@ void calculateBDSHeight(ImgUDevice::Pipe *pipe, const Size &iif, const Size &gdc\n> \t\t}\n> \t} else {\n> \t\tifHeight = utils::alignUp(iif.height, IF_ALIGN_H);\n> -\t\twhile (ifHeight > minIFHeight && ifHeight / bdsSF >= minBDSHeight) {\n> +\t\twhile (ifHeight >= minIFHeight && ifHeight / bdsSF >= minBDSHeight) {\n> \n> \t\t\tbdsHeight = ifHeight / bdsSF;\n> \t\t\tif (std::fmod(ifHeight, 1.0) == 0 && std::fmod(bdsHeight, 1.0) == 0) {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE3A8BD224\n\tfor ;\n\tTue, 13 Apr 2021 00:00:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 213C0687F4;\n\tTue, 13 Apr 2021 02:00:37 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E5C59605AE\n\tfor ;\n\tTue, 13 Apr 2021 02:00:35 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 23C6B6F2;\n\tTue, 13 Apr 2021 02:00:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MBPjX7hr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618272035;\n\tbh=+bzE9aB1noc30dWu5SCa6j3A3JRWKfQ9Q65hnPnBD0Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=MBPjX7hrdSUL6ZYCANlTWGIoj9Q0BEeT8+l55psY5ceW8hP9NCnS3lHIO2qpxNBvt\n\tvQQziflpOCe3Xd2Z66yDLqfr58LrEXJfK9FC8b/OR44phF7cgtAaKNiAoUPXogeKWp\n\tJUA6GmwM0DNk6+txvI6IZmxFZ/lsgWZEJYeVVEWc=","Date":"Tue, 13 Apr 2021 02:59:46 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210318103941.18837-1-jacopo@jmondi.org>\n\t<20210318103941.18837-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210318103941.18837-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 5/7] libcamera: ipu3: imgu: Fix BSD\n\theight size comparison","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]