[{"id":15752,"web_url":"https://patchwork.libcamera.org/comment/15752/","msgid":"<20210318052120.d457rqvo4qo3hoou@basti-TUXEDO-Book-XA1510>","date":"2021-03-18T05:21:20","subject":"Re: [libcamera-devel] [PATCH 5/5] Documentation: guides:\n\tpipeline-handler: Fix capture flag usage","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"Hey Nícolas,\n\nThank you for the patch.\n\nReviewed-by: Sebastian Fricke \n\nOn 17.03.2021 16:28, Nícolas F. R. A. Prado wrote:\n>The number of frames passed to the -C flag of cam should come right\n>after it, without a space, otherwise the value is discarded.\n>The log below already showed the correct usage, but the command in the\n>code-block was wrong, so fix it.\n>\n>Signed-off-by: Nícolas F. R. A. Prado \n>---\n> Documentation/guides/pipeline-handler.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n>diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n>index bcce86793ccd..8ef83fea9837 100644\n>--- a/Documentation/guides/pipeline-handler.rst\n>+++ b/Documentation/guides/pipeline-handler.rst\n>@@ -1433,7 +1433,7 @@ capture through the pipeline through both of the cam and qcam utilities.\n> .. code-block:: shell\n>\n> ninja -C build\n>- ./build/src/cam/cam -c vivid -C 5\n>+ ./build/src/cam/cam -c vivid -C5\n\nI think this could be even more descriptive by writing:\n```\n./build/src/cam/cam --camera=vivid --capture=5\n```\nBut that is probably just my own preference.\n\n>\n> To test that the pipeline handler can detect a device, and capture input.\n>\n>-- \n>2.30.2\n>\n>_______________________________________________\n>libcamera-devel mailing list\n>libcamera-devel@lists.libcamera.org\n>https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5ACEBC32E1\n\tfor ;\n\tThu, 18 Mar 2021 05:21:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB95D68D49;\n\tThu, 18 Mar 2021 06:21:23 +0100 (CET)","from mout01.posteo.de (mout01.posteo.de [185.67.36.65])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DFC06051E\n\tfor ;\n\tThu, 18 Mar 2021 06:21:22 +0100 (CET)","from submission (posteo.de [89.146.220.130]) \n\tby mout01.posteo.de (Postfix) with ESMTPS id CB37316005F\n\tfor ;\n\tThu, 18 Mar 2021 06:21:21 +0100 (CET)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4F1Fk922zJz9rxL;\n\tThu, 18 Mar 2021 06:21:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"SkuMAPJX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1616044881; bh=raUjBslAT7qPWTdfVdYlS1fu4Lb4RWrQCXOXEpG9ThQ=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=SkuMAPJXxsMmRJNoU2PJqqF828bZrnZhMKhjwHZSKL56xTGsUgk9RiX5acnn8Ugzt\n\tWZJBMi1M3kDIddLr+Anm0VFeEEr2EMefMXMynrjwW/wFXkyugPFikIzy0vzSzYF6y7\n\tQM9qPS8kyPxRHnkOMVBQxsLKZSDlqCzwyURlbiJU3DotSdZkBrv8D/qwwYL5XFzLXk\n\tXR7BEp6oVNi/15Yy7QS69xvdcUozCpjfJeEY2WC/sx7pDzaDC9PPzmY3CJBnJTUMPn\n\tG+yRBYGhNMX9cDZ41WgeRpNbwnhDPntMWmM1S14EE+66P+3DuuD2rAHoHOHNrWt/wp\n\tu5dA68jx993Ow==","Date":"Thu, 18 Mar 2021 06:21:20 +0100","From":"Sebastian Fricke ","To":"=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4=?= Prado ","Message-ID":"<20210318052120.d457rqvo4qo3hoou@basti-TUXEDO-Book-XA1510>","References":"<20210317192831.359014-1-nfraprado@collabora.com>\n\t<20210317192831.359014-6-nfraprado@collabora.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210317192831.359014-6-nfraprado@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH 5/5] Documentation: guides:\n\tpipeline-handler: Fix capture flag usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Chris Chinchilla ,\n\tSebastian Fricke ,\n\tlibcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15764,"web_url":"https://patchwork.libcamera.org/comment/15764/","msgid":"","date":"2021-03-19T00:02:37","subject":"Re: [libcamera-devel] [PATCH 5/5] Documentation: guides:\n\tpipeline-handler: Fix capture flag usage","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nThank you for the patch.\n\nOn Thu, Mar 18, 2021 at 06:21:20AM +0100, Sebastian Fricke wrote:\n> Hey Nícolas,\n> \n> Thank you for the patch.\n> \n> Reviewed-by: Sebastian Fricke \n> \n> On 17.03.2021 16:28, Nícolas F. R. A. Prado wrote:\n> > The number of frames passed to the -C flag of cam should come right\n> > after it, without a space, otherwise the value is discarded.\n> > The log below already showed the correct usage, but the command in the\n> > code-block was wrong, so fix it.\n> >\n> > Signed-off-by: Nícolas F. R. A. Prado \n> > ---\n> > Documentation/guides/pipeline-handler.rst | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n> > index bcce86793ccd..8ef83fea9837 100644\n> > --- a/Documentation/guides/pipeline-handler.rst\n> > +++ b/Documentation/guides/pipeline-handler.rst\n> > @@ -1433,7 +1433,7 @@ capture through the pipeline through both of the cam and qcam utilities.\n> > .. code-block:: shell\n> > \n> > ninja -C build\n> > - ./build/src/cam/cam -c vivid -C 5\n> > + ./build/src/cam/cam -c vivid -C5\n> \n> I think this could be even more descriptive by writing:\n> ```\n> ./build/src/cam/cam --camera=vivid --capture=5\n> ```\n> But that is probably just my own preference.\n\nThat's nice too. I don't have a strong preference. I'll push patch 1/5\nto 4/5 already, and let you (Nicolas) decide what option you prefer for\nthis.\n\nReviewed-by: Laurent Pinchart \n\n> >\n> > To test that the pipeline handler can detect a device, and capture input.\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB065BD80C\n\tfor ;\n\tFri, 19 Mar 2021 00:03:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F3DC68D65;\n\tFri, 19 Mar 2021 01:03:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6C7F66051D\n\tfor ;\n\tFri, 19 Mar 2021 01:03:15 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CBE4B4FD;\n\tFri, 19 Mar 2021 01:03:14 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UX2k8n6k\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616112195;\n\tbh=9bQPOFbK6/pywguS3TKQhQ/eCF6gI/MWXfDXGR5JRzM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UX2k8n6kzLEjynGGEMJ0tPytOxpInwewhm3wRpH2BhQJ+ttBsY6XAhkzdVJLT6SAA\n\tPA0fWtTtcakKbyfvvXn9JWFFFXHTauDhd/xoZeTtm8/5gF163ukwWP0mF6mMav3ORW\n\tSyUGMmlUGlrS3Q1hMB9JH8aO43jS2oXzFrkZZUTI=","Date":"Fri, 19 Mar 2021 02:02:37 +0200","From":"Laurent Pinchart ","To":"=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4=?= Prado ","Message-ID":"","References":"<20210317192831.359014-1-nfraprado@collabora.com>\n\t<20210317192831.359014-6-nfraprado@collabora.com>\n\t<20210318052120.d457rqvo4qo3hoou@basti-TUXEDO-Book-XA1510>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210318052120.d457rqvo4qo3hoou@basti-TUXEDO-Book-XA1510>","Subject":"Re: [libcamera-devel] [PATCH 5/5] Documentation: guides:\n\tpipeline-handler: Fix capture flag usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Chris Chinchilla ,\n\tSebastian Fricke ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15769,"web_url":"https://patchwork.libcamera.org/comment/15769/","msgid":"","date":"2021-03-19T12:19:38","subject":"Re: [libcamera-devel] [PATCH 5/5] Documentation: guides:\n\tpipeline-handler: Fix capture flag usage","submitter":{"id":84,"url":"https://patchwork.libcamera.org/api/people/84/","name":"Nícolas F. R. A. Prado","email":"nfraprado@collabora.com"},"content":"Em 2021-03-18 21:02, Laurent Pinchart escreveu:\n\n> Hi Nicolas,\n>\n> Thank you for the patch.\n>\n> On Thu, Mar 18, 2021 at 06:21:20AM +0100, Sebastian Fricke wrote:\n> > Hey Nícolas,\n> > \n> > Thank you for the patch.\n> > \n> > Reviewed-by: Sebastian Fricke \n> > \n> > On 17.03.2021 16:28, Nícolas F. R. A. Prado wrote:\n> > > The number of frames passed to the -C flag of cam should come right\n> > > after it, without a space, otherwise the value is discarded.\n> > > The log below already showed the correct usage, but the command in the\n> > > code-block was wrong, so fix it.\n> > >\n> > > Signed-off-by: Nícolas F. R. A. Prado \n> > > ---\n> > > Documentation/guides/pipeline-handler.rst | 2 +-\n> > > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > >\n> > > diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n> > > index bcce86793ccd..8ef83fea9837 100644\n> > > --- a/Documentation/guides/pipeline-handler.rst\n> > > +++ b/Documentation/guides/pipeline-handler.rst\n> > > @@ -1433,7 +1433,7 @@ capture through the pipeline through both of the cam and qcam utilities.\n> > > .. code-block:: shell\n> > > \n> > > ninja -C build\n> > > - ./build/src/cam/cam -c vivid -C 5\n> > > + ./build/src/cam/cam -c vivid -C5\n> > \n> > I think this could be even more descriptive by writing:\n> > ```\n> > ./build/src/cam/cam --camera=vivid --capture=5\n> > ```\n> > But that is probably just my own preference.\n>\n> That's nice too. I don't have a strong preference. I'll push patch 1/5\n> to 4/5 already, and let you (Nicolas) decide what option you prefer for\n> this.\n\nI agree with Sebastian that using `--capture=` is more descriptive, but that\nusage is obvious from the `--help`, while the lack of space after `-C` is not.\nSo I'd keep the `-C` usage (moreover, people are lazy and will use the shorter\nforms, so it should be clear how to do so :)).\n\nThanks,\nNícolas\n\n>\n> Reviewed-by: Laurent Pinchart \n>\n> > >\n> > > To test that the pipeline handler can detect a device, and capture input.\n> > >\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6F66ABD80C\n\tfor ;\n\tFri, 19 Mar 2021 12:26:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C7B7268D60;\n\tFri, 19 Mar 2021 13:26:08 +0100 (CET)","from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A2E9368D5E\n\tfor ;\n\tFri, 19 Mar 2021 13:26:06 +0100 (CET)","from localhost (unknown\n\t[IPv6:2804:14c:1a0:2f63:47ae:9089:7ce3:6d30])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits))\n\t(No client certificate requested) (Authenticated sender: nfraprado)\n\tby bhuna.collabora.co.uk (Postfix) with ESMTPSA id 9A61A1F4688E;\n\tFri, 19 Mar 2021 12:26:04 +0000 (GMT)"],"Mime-Version":"1.0","From":"=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= ","To":"\"Laurent Pinchart\" ","Date":"Fri, 19 Mar 2021 09:19:38 -0300","Message-Id":"","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 5/5] Documentation: guides:\n\tpipeline-handler: Fix capture flag usage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Chris Chinchilla ,\n\tSebastian Fricke ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]