[{"id":15754,"web_url":"https://patchwork.libcamera.org/comment/15754/","msgid":"<20210318053300.xclf3phsbpso2q7h@basti-TUXEDO-Book-XA1510>","date":"2021-03-18T05:33:00","subject":"Re: [libcamera-devel] [PATCH 4/5] Documentation: guides:\n\tpipeline-handler: Update code, commands and logs","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"Hello Nícolas,\n\nThank you for the patch.\n\nReviewed-by: Sebastian Fricke \n\nOn 17.03.2021 16:28, Nícolas F. R. A. Prado wrote:\n>The pipeline-handler guide is a bit outdated:\n>- ControlList* in start() is now const.\n>- Registered pipeline handler log now comes from Camera log and the message is different.\n>\n>Update the pipeline-handler guide to reflect these changes.\n>\n>Signed-off-by: Nícolas F. R. A. Prado \n>---\n> Documentation/guides/pipeline-handler.rst | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n>\n>diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n>index 43783ec32afa..bcce86793ccd 100644\n>--- a/Documentation/guides/pipeline-handler.rst\n>+++ b/Documentation/guides/pipeline-handler.rst\n>@@ -209,7 +209,7 @@ methods for the overridden class members.\n> int exportFrameBuffers(Camera *camera, Stream *stream,\n> std::vector> *buffers) override;\n>\n>- int start(Camera *camera, ControlList *controls) override;\n>+ int start(Camera *camera, const ControlList *controls) override;\n> void stop(Camera *camera) override;\n>\n> int queueRequestDevice(Camera *camera, Request *request) override;\n>@@ -239,7 +239,7 @@ methods for the overridden class members.\n> return -1;\n> }\n>\n>- int PipelineHandlerVivid::start(Camera *camera, ControlList *controls)\n>+ int PipelineHandlerVivid::start(Camera *camera, const ControlList *controls)\n> {\n> return -1;\n> }\n>@@ -303,13 +303,13 @@ new pipeline handler by running:\n>\n> .. code-block:: shell\n>\n>- LIBCAMERA_LOG_LEVELS=Pipeline:0 ./build/src/cam/cam -l\n>+ LIBCAMERA_LOG_LEVELS=Camera:0 ./build/src/cam/cam -l\n>\n> And you should see output like the below:\n>\n> .. code-block:: shell\n>\n>- DEBUG Pipeline pipeline_handler.cpp:680 Registered pipeline handler \"PipelineHandlerVivid\"\n>+ DEBUG Camera camera_manager.cpp:148 Found registered pipeline handler 'PipelineHandlerVivid'\n>\n> Matching devices\n> ~~~~~~~~~~~~~~~~\n>-- \n>2.30.2\n>\n>_______________________________________________\n>libcamera-devel mailing list\n>libcamera-devel@lists.libcamera.org\n>https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 345AFC32E1\n\tfor ;\n\tThu, 18 Mar 2021 05:33:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 706CE68D51;\n\tThu, 18 Mar 2021 06:33:03 +0100 (CET)","from mout02.posteo.de (mout02.posteo.de [185.67.36.66])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E97C66051E\n\tfor ;\n\tThu, 18 Mar 2021 06:33:01 +0100 (CET)","from submission (posteo.de [89.146.220.130]) \n\tby mout02.posteo.de (Postfix) with ESMTPS id 570F12400FC\n\tfor ;\n\tThu, 18 Mar 2021 06:33:01 +0100 (CET)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4F1Fzc6TWgz9rxP;\n\tThu, 18 Mar 2021 06:33:00 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"E+QghQeD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1616045581; bh=xpj4Z3hu16ZrfFJYSS9jP5/yArQAIjOYR5xqB0bUE4w=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=E+QghQeDmWv7t+ryAokn3pzg7hDTUJJ/Nm5u5WyxaI21PieW3qGOVuz1qN9YWEYen\n\tlZNBI26OQRno/rANGrBynScBLy/Vy09V483Ay0An9F6Q4294E/OJtFfygVkH1n9lNI\n\t1DFfS/9Tris815vjjULDyXN79dZ/shUXli2AwHBc4/GCJLLsRXVqgU+8R11pwTsv2M\n\tCVNl+N7EzsTYn8/Tj4y/bxg4WZUAuRM7e9ZPL4LcL58kdOR0HHSIe13itzx7bO3yNf\n\tYjrrVx1ccEjnAFAsd/nTEPNrW3LPftA3UZhnApK3Q9EfqtNIV5/HxwGxYD6lN3aOkd\n\tQl8hvoO0mMwIw==","Date":"Thu, 18 Mar 2021 06:33:00 +0100","From":"Sebastian Fricke ","To":"=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4=?= Prado ","Message-ID":"<20210318053300.xclf3phsbpso2q7h@basti-TUXEDO-Book-XA1510>","References":"<20210317192831.359014-1-nfraprado@collabora.com>\n\t<20210317192831.359014-5-nfraprado@collabora.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210317192831.359014-5-nfraprado@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH 4/5] Documentation: guides:\n\tpipeline-handler: Update code, commands and logs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Chris Chinchilla ,\n\tSebastian Fricke ,\n\tlibcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15763,"web_url":"https://patchwork.libcamera.org/comment/15763/","msgid":"","date":"2021-03-18T23:59:58","subject":"Re: [libcamera-devel] [PATCH 4/5] Documentation: guides:\n\tpipeline-handler: Update code, commands and logs","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nThank you for the patch.\n\nOn Wed, Mar 17, 2021 at 04:28:30PM -0300, Nícolas F. R. A. Prado wrote:\n> The pipeline-handler guide is a bit outdated:\n\nThis was bound to happen. I wonder if there could be away to detect this\nkind of issue faster, ideally in an automated way.\n\n> - ControlList* in start() is now const.\n> - Registered pipeline handler log now comes from Camera log and the message is different.\n> \n> Update the pipeline-handler guide to reflect these changes.\n> \n> Signed-off-by: Nícolas F. R. A. Prado \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Documentation/guides/pipeline-handler.rst | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/Documentation/guides/pipeline-handler.rst b/Documentation/guides/pipeline-handler.rst\n> index 43783ec32afa..bcce86793ccd 100644\n> --- a/Documentation/guides/pipeline-handler.rst\n> +++ b/Documentation/guides/pipeline-handler.rst\n> @@ -209,7 +209,7 @@ methods for the overridden class members.\n> int exportFrameBuffers(Camera *camera, Stream *stream,\n> std::vector> *buffers) override;\n> \n> - int start(Camera *camera, ControlList *controls) override;\n> + int start(Camera *camera, const ControlList *controls) override;\n> void stop(Camera *camera) override;\n> \n> int queueRequestDevice(Camera *camera, Request *request) override;\n> @@ -239,7 +239,7 @@ methods for the overridden class members.\n> return -1;\n> }\n> \n> - int PipelineHandlerVivid::start(Camera *camera, ControlList *controls)\n> + int PipelineHandlerVivid::start(Camera *camera, const ControlList *controls)\n> {\n> return -1;\n> }\n> @@ -303,13 +303,13 @@ new pipeline handler by running:\n> \n> .. code-block:: shell\n> \n> - LIBCAMERA_LOG_LEVELS=Pipeline:0 ./build/src/cam/cam -l\n> + LIBCAMERA_LOG_LEVELS=Camera:0 ./build/src/cam/cam -l\n> \n> And you should see output like the below:\n> \n> .. code-block:: shell\n> \n> - DEBUG Pipeline pipeline_handler.cpp:680 Registered pipeline handler \"PipelineHandlerVivid\"\n> + DEBUG Camera camera_manager.cpp:148 Found registered pipeline handler 'PipelineHandlerVivid'\n> \n> Matching devices\n> ~~~~~~~~~~~~~~~~","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 232C2C32E1\n\tfor ;\n\tFri, 19 Mar 2021 00:00:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F7B968D51;\n\tFri, 19 Mar 2021 01:00:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E0C16051D\n\tfor ;\n\tFri, 19 Mar 2021 01:00:37 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4FD6C4FD;\n\tFri, 19 Mar 2021 01:00:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"prX3zCD7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616112036;\n\tbh=hSpZ93pFgxBaknCwJgElnOaKhRGPZcbz1iqPI2Aom1U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=prX3zCD732n59AUO/htsqoRI8v47i5w/yHpyfw3nh5T+uuwBetuaenW7EcjLMmjKc\n\tFPYDxWXdzislOZz12YU5QPPgjJ6UwV6DSAzLSLhtbKq0+uJHO4D7k5l/GjETgXaMcD\n\twzCNxHtYmc0inVmf6oIda2lwwxhVjDF88F3rQ6Lg=","Date":"Fri, 19 Mar 2021 01:59:58 +0200","From":"Laurent Pinchart ","To":"=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4=?= Prado ","Message-ID":"","References":"<20210317192831.359014-1-nfraprado@collabora.com>\n\t<20210317192831.359014-5-nfraprado@collabora.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210317192831.359014-5-nfraprado@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH 4/5] Documentation: guides:\n\tpipeline-handler: Update code, commands and logs","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Chris Chinchilla ,\n\tSebastian Fricke ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]