[{"id":15753,"web_url":"https://patchwork.libcamera.org/comment/15753/","msgid":"<20210318053032.6v3n6ym7fhbpscqk@basti-TUXEDO-Book-XA1510>","date":"2021-03-18T05:30:32","subject":"Re: [libcamera-devel] [PATCH 3/5] Documentation: sensor-driver: Fix\n\tlinks to V4L2 documentation","submitter":{"id":78,"url":"https://patchwork.libcamera.org/api/people/78/","name":"Sebastian Fricke","email":"sebastian.fricke@posteo.net"},"content":"Hello Nícolas,\n\nThank you for the patch.\n\nReviewed-by: Sebastian Fricke \n\nOn 17.03.2021 16:28, Nícolas F. R. A. Prado wrote:\n>Fix some links to the V4L2 documentation. The first one is indeed\n>pointing to the wrong page. The second one has a highlight embedded, so\n>not necessarily wrong, but not needed, so clean it up as well.\n>\n>Signed-off-by: Nícolas F. R. A. Prado \n>---\n> Documentation/sensor_driver_requirements.rst | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n>diff --git a/Documentation/sensor_driver_requirements.rst b/Documentation/sensor_driver_requirements.rst\n>index 3e800c8e9c13..b0854be3328a 100644\n>--- a/Documentation/sensor_driver_requirements.rst\n>+++ b/Documentation/sensor_driver_requirements.rst\n>@@ -51,7 +51,7 @@ The sensor driver should support the following V4L2 controls:\n> * `V4L2_CID_CAMERA_SENSOR_ROTATION`_\n>\n> .. _V4L2_CID_CAMERA_ORIENTATION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-camera.html\n>-.. _V4L2_CID_CAMERA_SENSOR_ROTATION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-image-process.html\n>+.. _V4L2_CID_CAMERA_SENSOR_ROTATION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-camera.html\n\nSadly, the link doesn't jump immediatly to the term and you first\nhave to scroll all the way down :/.\nBut for that to change we would first have to add sub-links into the\nkernel documentation.\n\n>\n> The controls are used to register the camera location and rotation.\n>\n>@@ -60,7 +60,7 @@ specifically it should implement support for the\n> `VIDIOC_SUBDEV_G_SELECTION`_ ioctl with support for the following selection\n> targets:\n>\n>-.. _VIDIOC_SUBDEV_G_SELECTION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/vidioc-subdev-g-selection.html?highlight=g_selection#c.V4L.VIDIOC_SUBDEV_G_SELECTION\n>+.. _VIDIOC_SUBDEV_G_SELECTION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/vidioc-subdev-g-selection.html#c.V4L.VIDIOC_SUBDEV_G_SELECTION\n>\n> * `V4L2_SEL_TGT_CROP_BOUNDS`_ to report the readable pixel array area size\n> * `V4L2_SEL_TGT_CROP_DEFAULT`_ to report the active pixel array area size\n>-- \n>2.30.2\n>\n>_______________________________________________\n>libcamera-devel mailing list\n>libcamera-devel@lists.libcamera.org\n>https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6AF17BD80C\n\tfor ;\n\tThu, 18 Mar 2021 05:30:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DBAD668D49;\n\tThu, 18 Mar 2021 06:30:35 +0100 (CET)","from mout02.posteo.de (mout02.posteo.de [185.67.36.66])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ACE5B6051E\n\tfor ;\n\tThu, 18 Mar 2021 06:30:33 +0100 (CET)","from submission (posteo.de [89.146.220.130]) \n\tby mout02.posteo.de (Postfix) with ESMTPS id 223AE2400FD\n\tfor ;\n\tThu, 18 Mar 2021 06:30:33 +0100 (CET)","from customer (localhost [127.0.0.1])\n\tby submission (posteo.de) with ESMTPSA id 4F1Fwm4tLBz9rxL;\n\tThu, 18 Mar 2021 06:30:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=posteo.net header.i=@posteo.net\n\theader.b=\"TsKi+S5C\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;\n\tt=1616045433; bh=IojDTySe0IdJTsH9hEkfKrIpWTLlFKljDpUHLnPFiDU=;\n\th=Date:From:To:Cc:Subject:From;\n\tb=TsKi+S5C/1UOO8SkGxf8N3djHDSrqz/97bjl/RbsWFYzTaNFtMNgwmrMp+wyAfiVh\n\t0hMNuow2ej+4CcAd7U5+9LPxtFFzXil8yd1SWXG3byxTdbipsiQwCPkG/aIsKAAC7E\n\tQ7hv8ZKQ8+Xyu/AWhW/BkaPLqJNFPEz9O+tTrbgSKPW8gG9Sn6/FBQh0NuZslBY5cN\n\ti3lRITtaLRAv12NjQV64fNak9ZMkvKOrhnZ8qHuaHyyBOQrK4Ud36GaiVNGou+uhh8\n\t3q9CdpEY+V1UWhkGg7goJVgY55OvYC124D9esW2u2F/23kSMjK7fnaQDxV+GU5uSqL\n\txfEOywp7HDFdg==","Date":"Thu, 18 Mar 2021 06:30:32 +0100","From":"Sebastian Fricke ","To":"=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4=?= Prado ","Message-ID":"<20210318053032.6v3n6ym7fhbpscqk@basti-TUXEDO-Book-XA1510>","References":"<20210317192831.359014-1-nfraprado@collabora.com>\n\t<20210317192831.359014-4-nfraprado@collabora.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210317192831.359014-4-nfraprado@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH 3/5] Documentation: sensor-driver: Fix\n\tlinks to V4L2 documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Chris Chinchilla ,\n\tSebastian Fricke ,\n\tlibcamera-devel@lists.libcamera.org","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15762,"web_url":"https://patchwork.libcamera.org/comment/15762/","msgid":"","date":"2021-03-18T23:57:41","subject":"Re: [libcamera-devel] [PATCH 3/5] Documentation: sensor-driver: Fix\n\tlinks to V4L2 documentation","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nThank you for the patch.\n\nOn Wed, Mar 17, 2021 at 04:28:29PM -0300, Nícolas F. R. A. Prado wrote:\n> Fix some links to the V4L2 documentation. The first one is indeed\n> pointing to the wrong page. The second one has a highlight embedded, so\n> not necessarily wrong, but not needed, so clean it up as well.\n> \n> Signed-off-by: Nícolas F. R. A. Prado \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Documentation/sensor_driver_requirements.rst | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/Documentation/sensor_driver_requirements.rst b/Documentation/sensor_driver_requirements.rst\n> index 3e800c8e9c13..b0854be3328a 100644\n> --- a/Documentation/sensor_driver_requirements.rst\n> +++ b/Documentation/sensor_driver_requirements.rst\n> @@ -51,7 +51,7 @@ The sensor driver should support the following V4L2 controls:\n> * `V4L2_CID_CAMERA_SENSOR_ROTATION`_\n> \n> .. _V4L2_CID_CAMERA_ORIENTATION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-camera.html\n> -.. _V4L2_CID_CAMERA_SENSOR_ROTATION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-image-process.html\n> +.. _V4L2_CID_CAMERA_SENSOR_ROTATION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-camera.html\n> \n> The controls are used to register the camera location and rotation.\n> \n> @@ -60,7 +60,7 @@ specifically it should implement support for the\n> `VIDIOC_SUBDEV_G_SELECTION`_ ioctl with support for the following selection\n> targets:\n> \n> -.. _VIDIOC_SUBDEV_G_SELECTION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/vidioc-subdev-g-selection.html?highlight=g_selection#c.V4L.VIDIOC_SUBDEV_G_SELECTION\n> +.. _VIDIOC_SUBDEV_G_SELECTION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/vidioc-subdev-g-selection.html#c.V4L.VIDIOC_SUBDEV_G_SELECTION\n> \n> * `V4L2_SEL_TGT_CROP_BOUNDS`_ to report the readable pixel array area size\n> * `V4L2_SEL_TGT_CROP_DEFAULT`_ to report the active pixel array area size","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99ABAC32E1\n\tfor ;\n\tThu, 18 Mar 2021 23:58:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1B8776084F;\n\tFri, 19 Mar 2021 00:58:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 80A396051D\n\tfor ;\n\tFri, 19 Mar 2021 00:58:19 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DD8C74FD;\n\tFri, 19 Mar 2021 00:58:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QBH15A8R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616111899;\n\tbh=BMldfDH+9BQ23GXuRNs7IUxDDSNsbXhg2l9CqD0mWJs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=QBH15A8RKJyPrqsFnUOyc7taSpnCTqiP626EVAtBMFMJj+26wL+1yNdpjQ6Hydp0Q\n\tMi2C3P7A3RgN1bta6c9BjP0pLkCLA6HfFVAOzLS55r9IvszPSXYSbOe3Fj4ZVcUB6l\n\t+y6Iz91TX4+89sKl3XY7muA2LiXGFbzapy6qKf6I=","Date":"Fri, 19 Mar 2021 01:57:41 +0200","From":"Laurent Pinchart ","To":"=?utf-8?b?TsOtY29sYXMgRi4gUi4gQS4=?= Prado ","Message-ID":"","References":"<20210317192831.359014-1-nfraprado@collabora.com>\n\t<20210317192831.359014-4-nfraprado@collabora.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210317192831.359014-4-nfraprado@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH 3/5] Documentation: sensor-driver: Fix\n\tlinks to V4L2 documentation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Chris Chinchilla ,\n\tSebastian Fricke ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]