[{"id":15804,"web_url":"https://patchwork.libcamera.org/comment/15804/","msgid":"","date":"2021-03-22T21:20:01","subject":"Re: [libcamera-devel] [PATCH 5/7] ipa: raspberrypi: Remove unused\n\tmember variables","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Wed, Mar 17, 2021 at 10:02:09AM +0000, Naushir Patuck wrote:\n> With the recent refactoring of code from ipa::configure() to ipa::init()\n> some member variable are now unused, so remove them.\n\ncontrollerInit_ could be dropped in 4/7. lastMode_ is already unused\nbefore this series, so you may want to update the commit message\naccordingly.\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 7 +------\n> 1 file changed, 1 insertion(+), 6 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index e2db0716b84b..2ca64bcdb80a 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -67,8 +67,7 @@ class IPARPi : public ipa::RPi::IPARPiInterface\n> {\n> public:\n> \tIPARPi()\n> -\t\t: lastMode_({}), controller_(), controllerInit_(false),\n> -\t\t frameCount_(0), checkCount_(0), mistrustCount_(0),\n> +\t\t: controller_(), frameCount_(0), checkCount_(0), mistrustCount_(0),\n> \t\t lsTable_(nullptr), firstStart_(true)\n> \t{\n> \t}\n> @@ -129,12 +128,10 @@ private:\n> \n> \t/* Camera sensor params. */\n> \tCameraMode mode_;\n> -\tCameraMode lastMode_;\n> \n> \t/* Raspberry Pi controller specific defines. */\n> \tstd::unique_ptr helper_;\n> \tRPiController::Controller controller_;\n> -\tbool controllerInit_;\n> \tRPiController::Metadata rpiMetadata_;\n> \n> \t/*\n> @@ -387,8 +384,6 @@ int IPARPi::configure(const CameraSensorInfo &sensorInfo,\n> \t\tresult->controls = std::move(ctrls);\n> \t}\n> \n> -\tlastMode_ = mode_;\n> -\n> \treturn 0;\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB43EC32E1\n\tfor ;\n\tMon, 22 Mar 2021 21:20:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12F7B68D62;\n\tMon, 22 Mar 2021 22:20:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4AD768D50\n\tfor ;\n\tMon, 22 Mar 2021 22:20:42 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6977AED;\n\tMon, 22 Mar 2021 22:20:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HuFSjj+N\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616448042;\n\tbh=2USEsf+tc417qatVPwlSYVBRPK/cYmVTLU0QRwAR4i8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HuFSjj+NC+xEOKx0KbUNwf7uY+LF8gr5ksjvsAL+5NAjWzFCOOMdkqzggSQ1H7NPw\n\tiYFv/AjKmc9bCgBfdeo6eQnv5/mFBi5WhoQSQ9VOn2v0gKSvhBGeT/Pks1Kj1nlnxe\n\tzdWMM+dUtp51heV2HFtTnoB4k/VRRfWGlpheQh7g=","Date":"Mon, 22 Mar 2021 23:20:01 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20210317100211.1067585-1-naush@raspberrypi.com>\n\t<20210317100211.1067585-6-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210317100211.1067585-6-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 5/7] ipa: raspberrypi: Remove unused\n\tmember variables","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]