{"id":11601,"url":"https://patchwork.libcamera.org/api/patches/11601/?format=json","web_url":"https://patchwork.libcamera.org/patch/11601/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210317100211.1067585-4-naush@raspberrypi.com>","date":"2021-03-17T10:02:07","name":"[libcamera-devel,3/7] pipeline: raspberrypi: Conditionally open the embedded data node","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"e718cf72832922243a3456def977f7a607533652","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11601/mbox/","series":[{"id":1799,"url":"https://patchwork.libcamera.org/api/series/1799/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1799","date":"2021-03-17T10:02:06","name":"Raspberry Pi: ipa::init() restructuring","version":1,"mbox":"https://patchwork.libcamera.org/series/1799/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11601/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11601/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB044BD80C\n\tfor ;\n\tWed, 17 Mar 2021 10:02:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 33B1A68D6B;\n\tWed, 17 Mar 2021 11:02:23 +0100 (CET)","from mail-ej1-x632.google.com (mail-ej1-x632.google.com\n\t[IPv6:2a00:1450:4864:20::632])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E1B2668D64\n\tfor ;\n\tWed, 17 Mar 2021 11:02:20 +0100 (CET)","by mail-ej1-x632.google.com with SMTP id c10so1575629ejx.9\n\tfor ;\n\tWed, 17 Mar 2021 03:02:20 -0700 (PDT)","from naush-laptop.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tp24sm12061179edt.5.2021.03.17.03.02.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 17 Mar 2021 03:02:19 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"KRY4IO/f\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=9d0Ao7XbkMYX6Y2YZicWKq7YJ5FSsGKWU9neZBJlIYE=;\n\tb=KRY4IO/fhWDGv7kmxp3DmYpDUAfKmDFe63Pjr+nl17zJHwR0nJK5q9cZT+zDgZNHp0\n\tqnJT3v8skjo82VsKnrQyPFz3Q5Biwq+ZoAwfjuUO4QkWb+lTQoTFb9Xcs0Hs8VzTtEnR\n\tbJV9O9QPoYseNUoJvJTZNqFS6Fcp1MWDgAeKbAPVNAW3fY+jbYQXQYIrG1l+BF1kW70S\n\toeKv7Tji8F4QHlPaTuwwaQRhlpbnqysQbL3VSGuwXz/6usjWGkvhgmaFPU9Zt9DJIkkr\n\tNralOLVmIlmEfMhrLaKw+lZ77JLhn+TsrExs7689g/67PqsR5rIJTwLLpJkyJLdYgvwP\n\tKPuw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=9d0Ao7XbkMYX6Y2YZicWKq7YJ5FSsGKWU9neZBJlIYE=;\n\tb=j0r8okq8ou87libX/XTX3tO3kg/q4/AaHzhePYc1IKjke4J5cdq9EhsX73TcvPrEy/\n\tDTEAX+826dpsF/FFz9uI1Jra+NdZXventOFpHgoMxKBOW3QbY45NG5cEY12ww2t3JSGM\n\tmfH+Ev41/S1vLZh5Z7lANT020G7aJ9ZjHnSdUP0cukGY6mFezOQA6SlGkEG7TTql2bll\n\t3TrYowEC8Fdtl4wDv041Lm/fHwsgO/hpevGm6/nuQbCmv/OpMIWjlOuF9R82xE9UcGsn\n\tunrfu4CgWtGLCR5HpY0Yj0sqoHVqJKYlQgGX1jWCTT5RQaVT05aD1JnKzETEsipEdbA4\n\tcgpw==","X-Gm-Message-State":"AOAM5331+lnmZzTptZxE1cJJ2qcLzU2iKN6kg9i/MOtanO5dhS9W+Ohm\n\tYI2xfkcC4VL7aI3evv9s3TZEqF7ugCpEJw==","X-Google-Smtp-Source":"ABdhPJyUGUJhNTWQ1jyMWN0DNvU2XoToD+Qv+Ypcd+zeUvYguJXb7sZzgq0ZvzeXMn3a2Z26X4ZoHQ==","X-Received":"by 2002:a17:906:380b:: with SMTP id\n\tv11mr35136608ejc.183.1615975340087; \n\tWed, 17 Mar 2021 03:02:20 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 17 Mar 2021 10:02:07 +0000","Message-Id":"<20210317100211.1067585-4-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210317100211.1067585-1-naush@raspberrypi.com>","References":"<20210317100211.1067585-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 3/7] pipeline: raspberrypi: Conditionally\n\topen the embedded data node","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Conditionally open the embedded data node in pipeline_handler::match()\nbased on whether the ipa::init() result reports if the sensor supports\nembedded data or not.\n\nSigned-off-by: Naushir Patuck \n---\n .../pipeline/raspberrypi/raspberrypi.cpp | 60 ++++++++-----------\n 1 file changed, 24 insertions(+), 36 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex ce1994186d66..cd8a10a5747f 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -138,7 +138,7 @@ class RPiCameraData : public CameraData\n {\n public:\n \tRPiCameraData(PipelineHandler *pipe)\n-\t\t: CameraData(pipe), embeddedNodeOpened_(false), state_(State::Stopped),\n+\t\t: CameraData(pipe), state_(State::Stopped),\n \t\t supportsFlips_(false), flipsAlterBayerOrder_(false),\n \t\t updateScalerCrop_(true), dropFrameCount_(0), ispOutputCount_(0)\n \t{\n@@ -183,7 +183,6 @@ public:\n \n \tstd::unique_ptr delayedCtrls_;\n \tbool sensorMetadata_;\n-\tbool embeddedNodeOpened_;\n \n \t/*\n \t * All the functions in this class are called from a single calling\n@@ -749,19 +748,13 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n \t\tLOG(RPI, Error) << \"Failed to configure the IPA: \" << ret;\n \n \t/*\n-\t * The IPA will set data->sensorMetadata_ to true if embedded data is\n-\t * supported on this sensor. If so, open the Unicam embedded data\n-\t * node and configure the output format.\n+\t * Configure the Unicam embedded data output format only if the sensor\n+\t * supports it.\n \t */\n \tif (data->sensorMetadata_) {\n \t\tformat = {};\n \t\tformat.fourcc = V4L2PixelFormat(V4L2_META_FMT_SENSOR_DATA);\n \n-\t\tif (!data->embeddedNodeOpened_) {\n-\t\t\tdata->unicam_[Unicam::Embedded].dev()->open();\n-\t\t\tdata->embeddedNodeOpened_ = true;\n-\t\t}\n-\n \t\tLOG(RPI, Debug) << \"Setting embedded data format.\";\n \t\tret = data->unicam_[Unicam::Embedded].dev()->setFormat(&format);\n \t\tif (ret) {\n@@ -778,14 +771,6 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n \t\t */\n \t\tif (rawStream)\n \t\t\tdata->unicam_[Unicam::Embedded].setExternal(true);\n-\t} else {\n-\t\t/*\n-\t\t * No embedded data present, so we do not want to iterate over\n-\t\t * the embedded data stream when starting and stopping.\n-\t\t */\n-\t\tdata->streams_.erase(std::remove(data->streams_.begin(), data->streams_.end(),\n-\t\t\t\t\t\t &data->unicam_[Unicam::Embedded]),\n-\t\t\t\t data->streams_.end());\n \t}\n \n \t/*\n@@ -989,24 +974,6 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator)\n \tdata->isp_[Isp::Output1] = RPi::Stream(\"ISP Output1\", isp_->getEntityByName(\"bcm2835-isp0-capture2\"));\n \tdata->isp_[Isp::Stats] = RPi::Stream(\"ISP Stats\", isp_->getEntityByName(\"bcm2835-isp0-capture3\"));\n \n-\t/* This is just for convenience so that we can easily iterate over all streams. */\n-\tfor (auto &stream : data->unicam_)\n-\t\tdata->streams_.push_back(&stream);\n-\tfor (auto &stream : data->isp_)\n-\t\tdata->streams_.push_back(&stream);\n-\n-\t/*\n-\t * Open all Unicam and ISP streams. The exception is the embedded data\n-\t * stream, which only gets opened if the IPA reports that the sensor\n-\t * supports embedded data. This happens in RPiCameraData::configureIPA().\n-\t */\n-\tfor (auto const stream : data->streams_) {\n-\t\tif (stream != &data->unicam_[Unicam::Embedded]) {\n-\t\t\tif (stream->dev()->open())\n-\t\t\t\treturn false;\n-\t\t}\n-\t}\n-\n \t/* Wire up all the buffer connections. */\n \tdata->unicam_[Unicam::Image].dev()->frameStart.connect(data.get(), &RPiCameraData::frameStarted);\n \tdata->unicam_[Unicam::Image].dev()->bufferReady.connect(data.get(), &RPiCameraData::unicamBufferDequeue);\n@@ -1036,6 +1003,27 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator)\n \t\treturn false;\n \t}\n \n+\t/*\n+\t * Open all Unicam and ISP streams. The exception is the embedded data\n+\t * stream, which only gets opened if the IPA reports that the sensor\n+\t * supports embedded data below.\n+\t *\n+\t * The below grouping is just for convenience so that we can easily\n+\t * iterate over all streams in one go.\n+\t */\n+\tfor (auto &stream : data->unicam_) {\n+\t\tif (sensorConfig.sensorMetadata || &stream != &data->unicam_[Unicam::Embedded]) {\n+\t\t\tdata->streams_.push_back(&stream);\n+\t\t\tif (stream.dev()->open())\n+\t\t\t\treturn false;\n+\t\t}\n+\t}\n+\tfor (auto &stream : data->isp_) {\n+\t\tdata->streams_.push_back(&stream);\n+\t\tif (stream.dev()->open())\n+\t\t\treturn false;\n+\t}\n+\n \t/*\n \t * Setup our delayed control writer with the sensor default\n \t * gain and exposure delays. Mark VBLANK for priority write.\n","prefixes":["libcamera-devel","3/7"]}