{"id":11598,"url":"https://patchwork.libcamera.org/api/patches/11598/?format=json","web_url":"https://patchwork.libcamera.org/patch/11598/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210316155211.6679-6-m.cichy@pengutronix.de>","date":"2021-03-16T15:52:10","name":"[libcamera-devel,RFC,5/6] pipeline: simple: rename setupFormats to setupStreamProperties","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0b6bd739d4ae4c6dfa07d7de6372cb2371f35527","submitter":{"id":80,"url":"https://patchwork.libcamera.org/api/people/80/?format=json","name":"Marian Cichy","email":"m.cichy@pengutronix.de"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11598/mbox/","series":[{"id":1798,"url":"https://patchwork.libcamera.org/api/series/1798/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1798","date":"2021-03-16T15:52:05","name":"Add propagation of sensor frame interval","version":1,"mbox":"https://patchwork.libcamera.org/series/1798/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11598/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11598/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC8CEBD80C\n\tfor ;\n\tTue, 16 Mar 2021 15:52:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1400768D5E;\n\tTue, 16 Mar 2021 16:52:34 +0100 (CET)","from metis.ext.pengutronix.de (metis.ext.pengutronix.de\n\t[IPv6:2001:67c:670:201:290:27ff:fe1d:cc33])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C4B8568D4C\n\tfor ;\n\tTue, 16 Mar 2021 16:52:27 +0100 (CET)","from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28])\n\tby metis.ext.pengutronix.de with esmtps\n\t(TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)\n\t(envelope-from )\n\tid 1lMBzf-0000V5-3I; Tue, 16 Mar 2021 16:52:27 +0100","from mci by dude02.hi.pengutronix.de with local (Exim 4.92)\n\t(envelope-from )\n\tid 1lMBze-0003Du-Jb; Tue, 16 Mar 2021 16:52:26 +0100"],"From":"Marian Cichy ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 16 Mar 2021 16:52:10 +0100","Message-Id":"<20210316155211.6679-6-m.cichy@pengutronix.de>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20210316155211.6679-1-m.cichy@pengutronix.de>","References":"<20210316155211.6679-1-m.cichy@pengutronix.de>","MIME-Version":"1.0","X-SA-Exim-Connect-IP":"2001:67c:670:100:1d::28","X-SA-Exim-Mail-From":"mci@pengutronix.de","X-SA-Exim-Scanned":"No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false","X-PTX-Original-Recipient":"libcamera-devel@lists.libcamera.org","Subject":"[libcamera-devel] [RFC PATCH 5/6] pipeline: simple: rename\n\tsetupFormats to setupStreamProperties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"graphics@pengutronix.de, Marian Cichy ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This function does not only setup the format anymore but also propagates\nthe frame interval from the camera sensor to the camera interface, so\nlets choose a more generic name for it.\n\nSigned-off-by: Marian Cichy \n---\n src/libcamera/pipeline/simple/simple.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 296412e2..bc969125 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -150,7 +150,7 @@ public:\n \n \tint init();\n \tint setupLinks();\n-\tint setupFormats(V4L2SubdeviceFormat *format,\n+\tint setupStreamProperties(V4L2SubdeviceFormat *format,\n \t\t\t V4L2Subdevice::Whence whence);\n \n \tunsigned int streamIndex(const Stream *stream) const\n@@ -354,7 +354,7 @@ int SimpleCameraData::init()\n \tfor (unsigned int code : sensor_->mbusCodes()) {\n \t\tV4L2SubdeviceFormat format{ code, sensor_->resolution() };\n \n-\t\tret = setupFormats(&format, V4L2Subdevice::TryFormat);\n+\t\tret = setupStreamProperties(&format, V4L2Subdevice::TryFormat);\n \t\tif (ret < 0) {\n \t\t\tLOG(SimplePipeline, Debug)\n \t\t\t\t<< \"Media bus code \" << utils::hex(code, 4)\n@@ -455,7 +455,7 @@ int SimpleCameraData::setupLinks()\n \treturn 0;\n }\n \n-int SimpleCameraData::setupFormats(V4L2SubdeviceFormat *format,\n+int SimpleCameraData::setupStreamProperties(V4L2SubdeviceFormat *format,\n \t\t\t\t V4L2Subdevice::Whence whence)\n {\n \tSimplePipelineHandler *pipe = static_cast(pipe_);\n@@ -719,7 +719,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \tconst SimpleCameraData::Configuration *pipeConfig = config->pipeConfig();\n \tV4L2SubdeviceFormat format{ pipeConfig->code, data->sensor_->resolution() };\n \n-\tret = data->setupFormats(&format, V4L2Subdevice::ActiveFormat);\n+\tret = data->setupStreamProperties(&format, V4L2Subdevice::ActiveFormat);\n \tif (ret < 0)\n \t\treturn ret;\n \n","prefixes":["libcamera-devel","RFC","5/6"]}