[{"id":15731,"web_url":"https://patchwork.libcamera.org/comment/15731/","msgid":"","date":"2021-03-16T21:04:21","subject":"Re: [libcamera-devel] [RFC PATCH 6/6] gst: utils: Add framerate to\n\tcaps","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le mardi 16 mars 2021 à 16:52 +0100, Marian Cichy a écrit :\n> The framerate of a stream is the inverse of the frame interval from the\n> stream configuration.\n> \n> Signed-off-by: Marian Cichy \n> ---\n>  src/gstreamer/gstlibcamera-utils.cpp | 2 ++\n>  1 file changed, 2 insertions(+)\n> \n> diff --git a/src/gstreamer/gstlibcamera-utils.cpp\n> b/src/gstreamer/gstlibcamera-utils.cpp\n> index 61370d5f..7516f84a 100644\n> --- a/src/gstreamer/gstlibcamera-utils.cpp\n> +++ b/src/gstreamer/gstlibcamera-utils.cpp\n> @@ -125,6 +125,8 @@ gst_libcamera_stream_configuration_to_caps(const\n> StreamConfiguration &stream_cfg\n>         gst_structure_set(s,\n>                           \"width\", G_TYPE_INT, stream_cfg.size.width,\n>                           \"height\", G_TYPE_INT, stream_cfg.size.height,\n> +                         \"framerate\", GST_TYPE_FRACTION,\n> stream_cfg.frameInterval.denominator,\n> +                                                       stream_cfg.frameInterv\n> al.numerator,\n\nSo only fixed sizes can have a framerate ? What about the size ranges ? Do we\nexpect backend to repeat the sizes in order to offer multiple rate ?\n\n>                           nullptr);\n>         gst_caps_append_structure(caps, s);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 710A1BD80C\n\tfor ;\n\tTue, 16 Mar 2021 21:04:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC13568D49;\n\tTue, 16 Mar 2021 22:04:25 +0100 (CET)","from mail-qt1-x834.google.com (mail-qt1-x834.google.com\n\t[IPv6:2607:f8b0:4864:20::834])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D179268D49\n\tfor ;\n\tTue, 16 Mar 2021 22:04:23 +0100 (CET)","by mail-qt1-x834.google.com with SMTP id s2so12739220qtx.10\n\tfor ;\n\tTue, 16 Mar 2021 14:04:23 -0700 (PDT)","from nicolas-tpx395.localdomain (173-246-12-168.qc.cable.ebox.net.\n\t[173.246.12.168]) by smtp.gmail.com with ESMTPSA id\n\tl4sm14135320qte.64.2021.03.16.14.04.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 16 Mar 2021 14:04:22 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ndufresne-ca.20150623.gappssmtp.com\n\theader.i=@ndufresne-ca.20150623.gappssmtp.com\n\theader.b=\"NT6/D4rZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20150623.gappssmtp.com; s=20150623;\n\th=message-id:subject:from:to:cc:date:in-reply-to:references\n\t:user-agent:mime-version:content-transfer-encoding;\n\tbh=niiQaG//eF3M/dtwzKaCwQRvv5RdXMJDbah7QbLoILQ=;\n\tb=NT6/D4rZ43+1WfpF3tYq2U36Yr8HRm/Ow7dQ6EGYVx4wa5ebaCAyChKhhcd7tCtQRG\n\tUqHwYVJK+coDrvI5TBfWZFRQKouVVFa1qKVn9pdssB5d0WwyufIGbOAe89Yf2JUfxj6A\n\tKIdbYOUGW3bqm6Ux27HMrdtGzbYwyrcT6MZVheAdqmkNjIGAJf+D2GKXxPITYF6trToi\n\t4Ql2VeMhpMDui92efsd+QK6x/TVxUvoAzJSH3VMf6I+XWm+FXnCI4VcgHXDS+GCS3AcL\n\tAAaeZvP1pkvZpJqP+5LB8pAhM8H8xq2hHWY/nvAxKa61K6FacYp8axzz4ha+QIt0rvMV\n\tiUSQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=niiQaG//eF3M/dtwzKaCwQRvv5RdXMJDbah7QbLoILQ=;\n\tb=QejESGxJKfIV4hkoCY2UN6NHjjS1pxQexmRwlHBJDcYEcOr51qpFpQ8JI3p9gO7Mnj\n\tnE2g4KFcRZbwnmfV4m8rUEFuu+iwciZUpjcL8jSkbuRZgRgRUmoDlDGc5cxqvlmK+YjK\n\twB5sGxr7K2XuK6tHiUmM9QeXUb0lK5tTpZo61GxRuiA1FYKKjP/4FwNvUF40Jctq4SlN\n\tHRg3hlhfZ9f1NIJwg2PlfQUZtdG3i0+vpOFegI+A9n1aqlHfPkuV2hEjKr+XOVYK39S0\n\tWR1BGkAvRa73/zNTn+qKLW4dfmvI3AtDGgdzqHrYvkoQrv+hBUNnBoySC8h+3NeAfwpb\n\tk3Pw==","X-Gm-Message-State":"AOAM532QVI5vkAKtc9OG/dqyu2odmM2Qxp+uzIiBUTuAZY27MYZARHo5\n\ta9BPmHLPzZwdQtBzYaOHjd6eeg==","X-Google-Smtp-Source":"ABdhPJwAWWMNbcZl9wK9v/Nb+uOPkVXzF177s9VD1oTxacPlIH3eW2DGKMYqH/K7Oo/lzJh1qQPNjQ==","X-Received":"by 2002:ac8:4755:: with SMTP id k21mr803780qtp.102.1615928662706;\n\tTue, 16 Mar 2021 14:04:22 -0700 (PDT)","Message-ID":"","From":"Nicolas Dufresne ","To":"Marian Cichy ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 16 Mar 2021 17:04:21 -0400","In-Reply-To":"<20210316155211.6679-7-m.cichy@pengutronix.de>","References":"<20210316155211.6679-1-m.cichy@pengutronix.de>\n\t<20210316155211.6679-7-m.cichy@pengutronix.de>","User-Agent":"Evolution 3.38.4 (3.38.4-1.fc33) ","MIME-Version":"1.0","Subject":"Re: [libcamera-devel] [RFC PATCH 6/6] gst: utils: Add framerate to\n\tcaps","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"graphics@pengutronix.de","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]