{"id":11594,"url":"https://patchwork.libcamera.org/api/patches/11594/?format=json","web_url":"https://patchwork.libcamera.org/patch/11594/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210316155211.6679-2-m.cichy@pengutronix.de>","date":"2021-03-16T15:52:06","name":"[libcamera-devel,RFC,1/6] libcamera: Add fraction.h","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"320302cc2938befeddbff777251a23386b19d017","submitter":{"id":80,"url":"https://patchwork.libcamera.org/api/people/80/?format=json","name":"Marian Cichy","email":"m.cichy@pengutronix.de"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11594/mbox/","series":[{"id":1798,"url":"https://patchwork.libcamera.org/api/series/1798/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1798","date":"2021-03-16T15:52:05","name":"Add propagation of sensor frame interval","version":1,"mbox":"https://patchwork.libcamera.org/series/1798/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11594/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11594/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F144ABD80C\n\tfor ;\n\tTue, 16 Mar 2021 15:52:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A947368D55;\n\tTue, 16 Mar 2021 16:52:31 +0100 (CET)","from metis.ext.pengutronix.de (metis.ext.pengutronix.de\n\t[IPv6:2001:67c:670:201:290:27ff:fe1d:cc33])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BF1B068D4A\n\tfor ;\n\tTue, 16 Mar 2021 16:52:27 +0100 (CET)","from dude02.hi.pengutronix.de ([2001:67c:670:100:1d::28])\n\tby metis.ext.pengutronix.de with esmtps\n\t(TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)\n\t(envelope-from )\n\tid 1lMBze-0000V1-TI; Tue, 16 Mar 2021 16:52:26 +0100","from mci by dude02.hi.pengutronix.de with local (Exim 4.92)\n\t(envelope-from )\n\tid 1lMBze-0003DS-He; Tue, 16 Mar 2021 16:52:26 +0100"],"From":"Marian Cichy ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 16 Mar 2021 16:52:06 +0100","Message-Id":"<20210316155211.6679-2-m.cichy@pengutronix.de>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20210316155211.6679-1-m.cichy@pengutronix.de>","References":"<20210316155211.6679-1-m.cichy@pengutronix.de>","MIME-Version":"1.0","X-SA-Exim-Connect-IP":"2001:67c:670:100:1d::28","X-SA-Exim-Mail-From":"mci@pengutronix.de","X-SA-Exim-Scanned":"No (on metis.ext.pengutronix.de);\n\tSAEximRunCond expanded to false","X-PTX-Original-Recipient":"libcamera-devel@lists.libcamera.org","Subject":"[libcamera-devel] [RFC PATCH 1/6] libcamera: Add fraction.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"graphics@pengutronix.de, Marian Cichy ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a new class that represents a fraction. A structure like this is\nalso often used in linux camera drivers, e.g. v4l2_fract to represent a\nframe interval or in applications like Gstreamer to represent frame\nrates.\n\nAdding this class helps to interface frame intervals and frame\nrates in video streams.\n\nSigned-off-by: Marian Cichy \n---\n include/libcamera/fraction.h | 34 ++++++++++++++++++++\n src/libcamera/fraction.cpp | 60 ++++++++++++++++++++++++++++++++++++\n src/libcamera/meson.build | 1 +\n 3 files changed, 95 insertions(+)\n create mode 100644 include/libcamera/fraction.h\n create mode 100644 src/libcamera/fraction.cpp","diff":"diff --git a/include/libcamera/fraction.h b/include/libcamera/fraction.h\nnew file mode 100644\nindex 00000000..aa6a1abb\n--- /dev/null\n+++ b/include/libcamera/fraction.h\n@@ -0,0 +1,34 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021, Pengutronix, Marian Cichy \n+ *\n+ * fraction.h - A fraction consisting of two integers\n+ */\n+\n+#ifndef __LIBCAMERA_FRACTION_H__\n+#define __LIBCAMERA_FRACTION_H__\n+\n+namespace libcamera {\n+\n+class Fraction {\n+public:\n+\tconstexpr Fraction() :\n+\t\tnumerator(0), denominator(0)\n+\t{\n+\t}\n+\n+\tconstexpr Fraction(unsigned int num, unsigned int den) :\n+\t\tnumerator(num), denominator(den)\n+\t{\n+\t}\n+\n+\tunsigned int numerator;\n+\tunsigned int denominator;\n+\n+\tconst std::string toString() const;\n+};\n+\n+} /* namespace libcamera */\n+\n+#endif /* __LIBCAMERA_FRACTION_H__ */\ndiff --git a/src/libcamera/fraction.cpp b/src/libcamera/fraction.cpp\nnew file mode 100644\nindex 00000000..76c373aa\n--- /dev/null\n+++ b/src/libcamera/fraction.cpp\n@@ -0,0 +1,60 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2021, Pengutronix, Marian Cichy \n+ *\n+ * fraction.h - A fraction consisting of two integers\n+ */\n+\n+#include \n+#include \n+\n+#include \n+\n+/**\n+ * \\file fraction.h\n+ * \\brief A fraction consisting of two integers.\n+ */\n+\n+namespace libcamera {\n+\n+/**\n+ * \\class Fraction\n+ * \\brief Represents a fraction with a nominator and a denominator.\n+ */\n+\n+/**\n+ * \\fn Fraction::Fraction()\n+ * \\brief Construct a Fraction with value 0/0. This should be interpreted\n+ * as invalid or not-used Fraction.\n+ */\n+\n+/**\n+ * \\fn Fraction::Fraction(unsigned int num, unsigned int den)\n+ * \\brief Construct a Fraction with value n/d.\n+ */\n+\n+/**\n+ * \\var Fraction::numerator\n+ * \\brief The numerator of the fraction.\n+ */\n+\n+/**\n+ * \\var Fraction::denominator\n+ * \\brief The denominator of the fraction.\n+ */\n+\n+/**\n+ * \\brief Assemble and return a string describing the fraction\n+ * \\return A string describing the fraction.\n+ */\n+const std::string Fraction::toString() const\n+{\n+\tstd::stringstream ss;\n+\n+\tss << numerator << \"/\" << denominator;\n+\n+\treturn ss.str();\n+}\n+\n+} /* namespace libcamera */\ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 815629db..7927481f 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -22,6 +22,7 @@ libcamera_sources = files([\n 'file.cpp',\n 'file_descriptor.cpp',\n 'formats.cpp',\n+ 'fraction.cpp',\n 'framebuffer_allocator.cpp',\n 'geometry.cpp',\n 'ipa_controls.cpp',\n","prefixes":["libcamera-devel","RFC","1/6"]}