[{"id":15722,"web_url":"https://patchwork.libcamera.org/comment/15722/","msgid":"<20210316155054.5ziet775qppmnxjm@uno.localdomain>","date":"2021-03-16T15:50:54","subject":"Re: [libcamera-devel] [PATCH v4 2/2] libcamera: ipu3: Pass the BDS\n\trectangle at IPA configure call","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hello Jean-Michel\n\nOn Tue, Mar 16, 2021 at 04:40:23PM +0100, Jean-Michel Hautbois wrote:\n> The IPU3 IPA will need the BDS configuration when the AWB/AGC algorithm\n> will be integrated.\n> In order to do that, the configure() interface needs to be modified.\n>\n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Jacopo Mondi \n> Reviewed-by: Laurent Pinchart \n>\n> ---\n> v4:\n> - get back to pipeConfig_ beeing private\n> v3:\n> - pass bds size to ipa->configure()\n> v2:\n> - rename bds => bdsOutputSize\n> - use a libcamera::Size instead of libcamera::Rectangle\n> ---\n> include/libcamera/ipa/ipu3.mojom | 2 +-\n> src/ipa/ipu3/ipu3.cpp | 7 +++++--\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 3 files changed, 7 insertions(+), 4 deletions(-)\n>\n> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\n> index 6ee11333..5d13e7ea 100644\n> --- a/include/libcamera/ipa/ipu3.mojom\n> +++ b/include/libcamera/ipa/ipu3.mojom\n> @@ -30,7 +30,7 @@ interface IPAIPU3Interface {\n> \tstart() => (int32 ret);\n> \tstop();\n>\n> -\tconfigure(map entityControls) => ();\n> +\tconfigure(map entityControls, Size bdsOutputSize) => ();\n>\n> \tmapBuffers(array buffers);\n> \tunmapBuffers(array ids);\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index b63e58be..be73a225 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -35,7 +35,9 @@ public:\n> \tint start() override { return 0; }\n> \tvoid stop() override {}\n>\n> -\tvoid configure(const std::map &entityControls) override;\n> +\tvoid configure(\n> +\t\tconst std::map &entityControls,\n\nThis fits on the previous line\n\nPlease retain my tag!\n\nThanks\n j\n\n> +\t\tconst Size &bdsOutputSize) override;\n>\n> \tvoid mapBuffers(const std::vector &buffers) override;\n> \tvoid unmapBuffers(const std::vector &ids) override;\n> @@ -62,7 +64,8 @@ private:\n> \tuint32_t maxGain_;\n> };\n>\n> -void IPAIPU3::configure(const std::map &entityControls)\n> +void IPAIPU3::configure(const std::map &entityControls,\n> +\t\t\t[[maybe_unused]] const Size &bdsOutputSize)\n> {\n> \tif (entityControls.empty())\n> \t\treturn;\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index bb61ef4a..c9e3c5ef 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -635,7 +635,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n>\n> \tstd::map entityControls;\n> \tentityControls.emplace(0, data->cio2_.sensor()->controls());\n> -\tdata->ipa_->configure(entityControls);\n> +\tdata->ipa_->configure(entityControls, config->imguConfig().bds);\n>\n> \treturn 0;\n> }\n> --\n> 2.27.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B170C32E1\n\tfor ;\n\tTue, 16 Mar 2021 15:50:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7397F68D49;\n\tTue, 16 Mar 2021 16:50:26 +0100 (CET)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA8F368D48\n\tfor ;\n\tTue, 16 Mar 2021 16:50:24 +0100 (CET)","from uno.localdomain (host-79-22-58-175.retail.telecomitalia.it\n\t[79.22.58.175]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 797AE60009;\n\tTue, 16 Mar 2021 15:50:23 +0000 (UTC)"],"X-Originating-IP":"79.22.58.175","Date":"Tue, 16 Mar 2021 16:50:54 +0100","From":"Jacopo Mondi ","To":"Jean-Michel Hautbois ","Message-ID":"<20210316155054.5ziet775qppmnxjm@uno.localdomain>","References":"<20210316154023.46033-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210316154023.46033-3-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210316154023.46033-3-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 2/2] libcamera: ipu3: Pass the BDS\n\trectangle at IPA configure call","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15746,"web_url":"https://patchwork.libcamera.org/comment/15746/","msgid":"","date":"2021-03-17T14:09:54","subject":"Re: [libcamera-devel] [PATCH v4 2/2] libcamera: ipu3: Pass the BDS\n\trectangle at IPA configure call","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nOn Tue, Mar 16, 2021 at 04:40:23PM +0100, Jean-Michel Hautbois wrote:\n> The IPU3 IPA will need the BDS configuration when the AWB/AGC algorithm\n> will be integrated.\n> In order to do that, the configure() interface needs to be modified.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> Reviewed-by: Jacopo Mondi \n> Reviewed-by: Laurent Pinchart \n> \n> ---\n> v4:\n> - get back to pipeConfig_ beeing private\n> v3:\n> - pass bds size to ipa->configure()\n> v2:\n> - rename bds => bdsOutputSize\n> - use a libcamera::Size instead of libcamera::Rectangle\n> ---\n> include/libcamera/ipa/ipu3.mojom | 2 +-\n> src/ipa/ipu3/ipu3.cpp | 7 +++++--\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n> 3 files changed, 7 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\n> index 6ee11333..5d13e7ea 100644\n> --- a/include/libcamera/ipa/ipu3.mojom\n> +++ b/include/libcamera/ipa/ipu3.mojom\n> @@ -30,7 +30,7 @@ interface IPAIPU3Interface {\n> \tstart() => (int32 ret);\n> \tstop();\n> \n> -\tconfigure(map entityControls) => ();\n> +\tconfigure(map entityControls, Size bdsOutputSize) => ();\n> \n> \tmapBuffers(array buffers);\n> \tunmapBuffers(array ids);\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index b63e58be..be73a225 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -35,7 +35,9 @@ public:\n> \tint start() override { return 0; }\n> \tvoid stop() override {}\n> \n> -\tvoid configure(const std::map &entityControls) override;\n> +\tvoid configure(\n> +\t\tconst std::map &entityControls,\n> +\t\tconst Size &bdsOutputSize) override;\n\nI forgot to mention, this should be\n\n\tvoid configure(const std::map &entityControls,\n\t\t const Size &bdsOutputSize) override;\n\nto match the usual coding style. The rest looks good.\n\n> \n> \tvoid mapBuffers(const std::vector &buffers) override;\n> \tvoid unmapBuffers(const std::vector &ids) override;\n> @@ -62,7 +64,8 @@ private:\n> \tuint32_t maxGain_;\n> };\n> \n> -void IPAIPU3::configure(const std::map &entityControls)\n> +void IPAIPU3::configure(const std::map &entityControls,\n> +\t\t\t[[maybe_unused]] const Size &bdsOutputSize)\n> {\n> \tif (entityControls.empty())\n> \t\treturn;\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index bb61ef4a..c9e3c5ef 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -635,7 +635,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> \n> \tstd::map entityControls;\n> \tentityControls.emplace(0, data->cio2_.sensor()->controls());\n> -\tdata->ipa_->configure(entityControls);\n> +\tdata->ipa_->configure(entityControls, config->imguConfig().bds);\n> \n> \treturn 0;\n> }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E46FC32E1\n\tfor ;\n\tWed, 17 Mar 2021 14:10:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1CE6768D60;\n\tWed, 17 Mar 2021 15:10:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3485605B1\n\tfor ;\n\tWed, 17 Mar 2021 15:10:30 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 27F5345D;\n\tWed, 17 Mar 2021 15:10:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OvAKe5zn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615990230;\n\tbh=Vn2/jgCRBJvDLK9QkC1YjvUU6w1uqwQKLoCvROxYZ7I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OvAKe5zn6O+wFX8SLRQN/0SdAW10ZB5iqNXJcN5sclPo6sswQVl5jTPNUPdFJo+Ti\n\toIjfMR14ScJER6cJtwLhpMlxSfnDOEMm5woitTf/Ti4f3UnvbhUHHScwSApzSIuFRJ\n\tbRIc5YvaPnAmDuMkqVAEXaC+jI7dFyankxciSHjI=","Date":"Wed, 17 Mar 2021 16:09:54 +0200","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210316154023.46033-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210316154023.46033-3-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210316154023.46033-3-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 2/2] libcamera: ipu3: Pass the BDS\n\trectangle at IPA configure call","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]