{"id":11591,"url":"https://patchwork.libcamera.org/api/patches/11591/?format=json","web_url":"https://patchwork.libcamera.org/patch/11591/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210316154023.46033-3-jeanmichel.hautbois@ideasonboard.com>","date":"2021-03-16T15:40:23","name":"[libcamera-devel,v4,2/2] libcamera: ipu3: Pass the BDS rectangle at IPA configure call","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b617ca08f76bbd85525c4dbec034516592c27a37","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11591/mbox/","series":[{"id":1797,"url":"https://patchwork.libcamera.org/api/series/1797/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1797","date":"2021-03-16T15:40:21","name":"Prepare IPU3 pipeline to pass BDS to IPA","version":4,"mbox":"https://patchwork.libcamera.org/series/1797/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11591/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11591/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF780C32E1\n\tfor ;\n\tTue, 16 Mar 2021 15:40:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4FF6A68D54;\n\tTue, 16 Mar 2021 16:40:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 48B1F68D49\n\tfor ;\n\tTue, 16 Mar 2021 16:40:27 +0100 (CET)","from localhost.localdomain (unknown\n\t[IPv6:2a01:e0a:169:7140:f840:1816:ba68:a009])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E77068F7;\n\tTue, 16 Mar 2021 16:40:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fOJN5iHs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615909227;\n\tbh=ciD+j3GB5O29Bs9wqtSwYTHeGrR1vGG65741+aPl4LY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=fOJN5iHsuJDCeMsJC3f6GEBoOj1Dh3EgLOIssAwSbUIVaU0JHNGOnDqCwW+cyyoUW\n\ti1trgKQyc5uwiZbDcKO5iRvpo/Wpqm5UJms1I49sjs9M18m1O96/egEGtgd5Jnm0cy\n\t/Nm2ieAKvKVlz1+3DKrS7NgvE1O/WJQ5zNhgs2IU=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 16 Mar 2021 16:40:23 +0100","Message-Id":"<20210316154023.46033-3-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210316154023.46033-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20210316154023.46033-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 2/2] libcamera: ipu3: Pass the BDS\n\trectangle at IPA configure call","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The IPU3 IPA will need the BDS configuration when the AWB/AGC algorithm\nwill be integrated.\nIn order to do that, the configure() interface needs to be modified.\n\nSigned-off-by: Jean-Michel Hautbois \nReviewed-by: Jacopo Mondi \nReviewed-by: Laurent Pinchart \n\n---\nv4:\n- get back to pipeConfig_ beeing private\nv3:\n- pass bds size to ipa->configure()\nv2:\n- rename bds => bdsOutputSize\n- use a libcamera::Size instead of libcamera::Rectangle\n---\n include/libcamera/ipa/ipu3.mojom | 2 +-\n src/ipa/ipu3/ipu3.cpp | 7 +++++--\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n 3 files changed, 7 insertions(+), 4 deletions(-)","diff":"diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\nindex 6ee11333..5d13e7ea 100644\n--- a/include/libcamera/ipa/ipu3.mojom\n+++ b/include/libcamera/ipa/ipu3.mojom\n@@ -30,7 +30,7 @@ interface IPAIPU3Interface {\n \tstart() => (int32 ret);\n \tstop();\n \n-\tconfigure(map entityControls) => ();\n+\tconfigure(map entityControls, Size bdsOutputSize) => ();\n \n \tmapBuffers(array buffers);\n \tunmapBuffers(array ids);\ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex b63e58be..be73a225 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -35,7 +35,9 @@ public:\n \tint start() override { return 0; }\n \tvoid stop() override {}\n \n-\tvoid configure(const std::map &entityControls) override;\n+\tvoid configure(\n+\t\tconst std::map &entityControls,\n+\t\tconst Size &bdsOutputSize) override;\n \n \tvoid mapBuffers(const std::vector &buffers) override;\n \tvoid unmapBuffers(const std::vector &ids) override;\n@@ -62,7 +64,8 @@ private:\n \tuint32_t maxGain_;\n };\n \n-void IPAIPU3::configure(const std::map &entityControls)\n+void IPAIPU3::configure(const std::map &entityControls,\n+\t\t\t[[maybe_unused]] const Size &bdsOutputSize)\n {\n \tif (entityControls.empty())\n \t\treturn;\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex bb61ef4a..c9e3c5ef 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -635,7 +635,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \n \tstd::map entityControls;\n \tentityControls.emplace(0, data->cio2_.sensor()->controls());\n-\tdata->ipa_->configure(entityControls);\n+\tdata->ipa_->configure(entityControls, config->imguConfig().bds);\n \n \treturn 0;\n }\n","prefixes":["libcamera-devel","v4","2/2"]}