[{"id":15693,"web_url":"https://patchwork.libcamera.org/comment/15693/","msgid":"","date":"2021-03-15T09:28:35","subject":"Re: [libcamera-devel] [PATCH] ipa: ipa_interface: Add comment to\n\tdefend the forward-declaration","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Paul,\n\nThanks for your patch.\n\nOn 2021-03-15 18:24:56 +0900, Paul Elder wrote:\n> Any struct that is defined in core.mojom with the skipHeader tag needs\n> to be present in ipa_interface, either forward-declared or #included.\n> Add an argument so that, in the future, people don't try to send patches\n> removing the seemingly unused forward-declaration.\n> \n> Signed-off-by: Paul Elder \n\nI have commented once that this forward declaration should be dropped \nand acked a patch that removes it, hopefully a comment reminding me to \nnot do so will stop me in the future to make the same mistake ;-)\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/ipa/ipa_interface.h | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 47f81d1d..5d99e2cf 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -20,6 +20,11 @@\n> \n> namespace libcamera {\n> \n> +/*\n> + * Structs that are defined in core.mojom and have the skipHeader tag must be\n> + * forward-declared or #included here.\n> + */\n> +\n> struct CameraSensorInfo;\n> \n> class IPAInterface\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C93D8BD80C\n\tfor ;\n\tMon, 15 Mar 2021 09:28:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3D5F468D3E;\n\tMon, 15 Mar 2021 10:28:38 +0100 (CET)","from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com\n\t[IPv6:2a00:1450:4864:20::12e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 670F2602ED\n\tfor ;\n\tMon, 15 Mar 2021 10:28:37 +0100 (CET)","by mail-lf1-x12e.google.com with SMTP id n16so55756749lfb.4\n\tfor ;\n\tMon, 15 Mar 2021 02:28:37 -0700 (PDT)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\th24sm2823263ljg.77.2021.03.15.02.28.35\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 15 Mar 2021 02:28:36 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"ZwlHaNF9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=KaN7RoQRZWbkwrZIpb99P+FvwzHyuEeYbYXY8D1iFIo=;\n\tb=ZwlHaNF9ZgOKUHytpiz3jEUUKqMQ0Ex4gvwjhVRxWqkE8YHowAStf2GcJp5pJnY+AK\n\tRstcY8Flr6X2tIA5IL4PBGub9pNe+8iOPrYWNGXePhqnoKalxfBE689Sc9CmQn9hcDU4\n\tLtgl+gHxoVgW39m5P7RS5j0YLq4loc632aLPa2iIkbD0uGQHOpfFNSwQJWrfbSsearrB\n\tFRYl1CKv8VEnpxQY6RXW1/D1pupcl6C7hktaULDlhrYH3hpS7EPggRhLGVgxYUmvmo9/\n\t+kQwnC09LN3vYWAWPw6cAKZyCroRQaLSAldZdkXEq/CGxuGTQGy0k4EunvPyiMoelh1V\n\t4VUA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=KaN7RoQRZWbkwrZIpb99P+FvwzHyuEeYbYXY8D1iFIo=;\n\tb=sTe3C3U4kPFGe+rpo9ibiSAmE3BYMCUuJXlT0Bz5b2PAs5cqA5pLkCPKqTp/hMDyCM\n\tqh3MEXQ7LCpkQDc+V9UTNcdd4SBbbsvQJthTQExdOPO9Ji+RTHWhfap5V0k8BLjJs0wV\n\tYL0CE75a7dycacl8dGoBHdVSm3/BmyI/Y0GaNkNhklUv2dzeYuUecsnjoc7o2LX3E6Pq\n\t8dL0K4uNQjaKTCXaZ2VuVToZG25l736mU+8oqylCRrKJCZUIn9usw1Mjn+D56We/yvoM\n\t2RcN9lr0L2U5jRVC8iz4LSpPXWGKKOE3uv0JeyGsnD1ORhXUxD5X0sO42xvfZ2RbRZQ6\n\tkODg==","X-Gm-Message-State":"AOAM531SJPOeFYlROpeFX+AyfEh42t8+aIwQlvJD22DynJbfCl66VIWw\n\tLEjSuA61GPb8UDwQW/s/ewadIA==","X-Google-Smtp-Source":"ABdhPJxgJGbeAmddqHvgK09VPBsEatU0Lm4/qb5spSydrNAaCPe//qF/1J38M4125tbM29/1o+//hA==","X-Received":"by 2002:a05:6512:ac4:: with SMTP id\n\tn4mr7210768lfu.622.1615800516549; \n\tMon, 15 Mar 2021 02:28:36 -0700 (PDT)","Date":"Mon, 15 Mar 2021 10:28:35 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Paul Elder ","Message-ID":"","References":"<20210315092456.13525-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210315092456.13525-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: ipa_interface: Add comment to\n\tdefend the forward-declaration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15694,"web_url":"https://patchwork.libcamera.org/comment/15694/","msgid":"<6ae05e1d-01d6-b958-f7f9-98ac0232091b@ideasonboard.com>","date":"2021-03-15T10:36:40","subject":"Re: [libcamera-devel] [PATCH] ipa: ipa_interface: Add comment to\n\tdefend the forward-declaration","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Paul,\n\nOn 15/03/2021 09:24, Paul Elder wrote:\n> Any struct that is defined in core.mojom with the skipHeader tag needs\n> to be present in ipa_interface, either forward-declared or #included.\n> Add an argument so that, in the future, people don't try to send patches\n> removing the seemingly unused forward-declaration.\n> \n\nThanks ;-) That will help me for sure!\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Paul Elder \n> ---\n> include/libcamera/ipa/ipa_interface.h | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 47f81d1d..5d99e2cf 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -20,6 +20,11 @@\n> \n> namespace libcamera {\n> \n> +/*\n> + * Structs that are defined in core.mojom and have the skipHeader tag must be\n> + * forward-declared or #included here.\n> + */\n> +\n> struct CameraSensorInfo;\n> \n> class IPAInterface\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A73F4BD80C\n\tfor ;\n\tMon, 15 Mar 2021 10:36:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 00DDA68D42;\n\tMon, 15 Mar 2021 11:36:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2AF9862BDE\n\tfor ;\n\tMon, 15 Mar 2021 11:36:44 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FA73556;\n\tMon, 15 Mar 2021 11:36:43 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LigszcBl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615804603;\n\tbh=C7PMssxD8Y4WYPXAVud6G3sbtmBbBK/hhjOwHWfG7HI=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=LigszcBlrSnvivQwsrO7GijJG7mEba/Ku0N3+zkYX2VMdDi2GnK3OtT1MdTmiizud\n\taEgPvDNsnXmBmrAYlqmOpMyeEOJdOu7TGFTW+Q2OQZNX6LA2TAn3k0X1Sfh3je3l9/\n\tLlnt14YM1WhsPd3/DNfnwLvmn/6q/QsqTVnv3EbQ=","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210315092456.13525-1-paul.elder@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<6ae05e1d-01d6-b958-f7f9-98ac0232091b@ideasonboard.com>","Date":"Mon, 15 Mar 2021 10:36:40 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210315092456.13525-1-paul.elder@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] ipa: ipa_interface: Add comment to\n\tdefend the forward-declaration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15712,"web_url":"https://patchwork.libcamera.org/comment/15712/","msgid":"","date":"2021-03-15T23:26:01","subject":"Re: [libcamera-devel] [PATCH] ipa: ipa_interface: Add comment to\n\tdefend the forward-declaration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Mon, Mar 15, 2021 at 06:24:56PM +0900, Paul Elder wrote:\n> Any struct that is defined in core.mojom with the skipHeader tag needs\n> to be present in ipa_interface, either forward-declared or #included.\n> Add an argument so that, in the future, people don't try to send patches\n\ns/argument/command/ ?\n\n> removing the seemingly unused forward-declaration.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/ipa/ipa_interface.h | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 47f81d1d..5d99e2cf 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -20,6 +20,11 @@\n> \n> namespace libcamera {\n> \n> +/*\n> + * Structs that are defined in core.mojom and have the skipHeader tag must be\n> + * forward-declared or #included here.\n> + */\n> +\n> struct CameraSensorInfo;\n> \n> class IPAInterface","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2ED9BD80C\n\tfor ;\n\tMon, 15 Mar 2021 23:26:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B056F68D46;\n\tTue, 16 Mar 2021 00:26:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7381602E3\n\tfor ;\n\tTue, 16 Mar 2021 00:26:37 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 72D073E7;\n\tTue, 16 Mar 2021 00:26:37 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bWnW5+Fm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615850797;\n\tbh=Hmj8YvTOWmkLiZGDUu1nl2nV6v1HkYgnUkJ3WSU+NEw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bWnW5+Fm7Qx6atWP2YKisGdmdEuKDjE1QlbwG0e8AVV/1zYR0dP4Hzu9UIsSklI23\n\tbh4ko/aDQPbHMdEeNIQ2FR5NtZMonBl+Lc11Ga9fX2uTwdAcrUWRDzBH8GYYaS+nYD\n\tzqHZ1gb2IjizVoW5I2/T+yh6ZimhsdJoldcx9YuA=","Date":"Tue, 16 Mar 2021 01:26:01 +0200","From":"Laurent Pinchart ","To":"Paul Elder ","Message-ID":"","References":"<20210315092456.13525-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210315092456.13525-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: ipa_interface: Add comment to\n\tdefend the forward-declaration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15714,"web_url":"https://patchwork.libcamera.org/comment/15714/","msgid":"<20210316021645.GA2551@pyrite.rasen.tech>","date":"2021-03-16T02:16:45","subject":"Re: [libcamera-devel] [PATCH] ipa: ipa_interface: Add comment to\n\tdefend the forward-declaration","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Tue, Mar 16, 2021 at 01:26:01AM +0200, Laurent Pinchart wrote:\n> Hi Paul,\n> \n> Thank you for the patch.\n> \n> On Mon, Mar 15, 2021 at 06:24:56PM +0900, Paul Elder wrote:\n> > Any struct that is defined in core.mojom with the skipHeader tag needs\n> > to be present in ipa_interface, either forward-declared or #included.\n> > Add an argument so that, in the future, people don't try to send patches\n> \n> s/argument/command/ ?\n\nAh, so I typoed an entire word. What I meant was comment.\n\n\nThanks,\n\nPaul\n\n> > removing the seemingly unused forward-declaration.\n> > \n> > Signed-off-by: Paul Elder \n> \n> Reviewed-by: Laurent Pinchart \n> \n> > ---\n> > include/libcamera/ipa/ipa_interface.h | 5 +++++\n> > 1 file changed, 5 insertions(+)\n> > \n> > diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> > index 47f81d1d..5d99e2cf 100644\n> > --- a/include/libcamera/ipa/ipa_interface.h\n> > +++ b/include/libcamera/ipa/ipa_interface.h\n> > @@ -20,6 +20,11 @@\n> > \n> > namespace libcamera {\n> > \n> > +/*\n> > + * Structs that are defined in core.mojom and have the skipHeader tag must be\n> > + * forward-declared or #included here.\n> > + */\n> > +\n> > struct CameraSensorInfo;\n> > \n> > class IPAInterface","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 929CEBD80C\n\tfor ;\n\tTue, 16 Mar 2021 02:16:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EA7BB602E3;\n\tTue, 16 Mar 2021 03:16:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5FC6E602DB\n\tfor ;\n\tTue, 16 Mar 2021 03:16:52 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D0D283E7;\n\tTue, 16 Mar 2021 03:16:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"e0qIiZpt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615861012;\n\tbh=mszbuxN4pJrTpWJ455FzxJaK/FS+W3IJNE/nOo8KI+Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=e0qIiZptUY+sK7F6oGZSUGYboeEUFTAgwyYxtcx/xHb+mojErKHf1zH+ZQHb4f/Rb\n\tmc2XKo/C+GRMo5GoyyhzYQ/OLQJ8SF9Nck/kB4GuglBLcQTm89HkTOdZn5pYWaz9mP\n\tnWRIaOsERkJblF8xYvsFyDq9Z9NI4kkiNj0tb4BQ=","Date":"Tue, 16 Mar 2021 11:16:45 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210316021645.GA2551@pyrite.rasen.tech>","References":"<20210315092456.13525-1-paul.elder@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] ipa: ipa_interface: Add comment to\n\tdefend the forward-declaration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15715,"web_url":"https://patchwork.libcamera.org/comment/15715/","msgid":"","date":"2021-03-16T02:22:35","subject":"Re: [libcamera-devel] [PATCH] ipa: ipa_interface: Add comment to\n\tdefend the forward-declaration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nOn Tue, Mar 16, 2021 at 11:16:45AM +0900, paul.elder@ideasonboard.com wrote:\n> On Tue, Mar 16, 2021 at 01:26:01AM +0200, Laurent Pinchart wrote:\n> > On Mon, Mar 15, 2021 at 06:24:56PM +0900, Paul Elder wrote:\n> > > Any struct that is defined in core.mojom with the skipHeader tag needs\n> > > to be present in ipa_interface, either forward-declared or #included.\n> > > Add an argument so that, in the future, people don't try to send patches\n> > \n> > s/argument/command/ ?\n> \n> Ah, so I typoed an entire word. What I meant was comment.\n\nSo did I... :-)\n\n> > > removing the seemingly unused forward-declaration.\n> > > \n> > > Signed-off-by: Paul Elder \n> > \n> > Reviewed-by: Laurent Pinchart \n> > \n> > > ---\n> > > include/libcamera/ipa/ipa_interface.h | 5 +++++\n> > > 1 file changed, 5 insertions(+)\n> > > \n> > > diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> > > index 47f81d1d..5d99e2cf 100644\n> > > --- a/include/libcamera/ipa/ipa_interface.h\n> > > +++ b/include/libcamera/ipa/ipa_interface.h\n> > > @@ -20,6 +20,11 @@\n> > > \n> > > namespace libcamera {\n> > > \n> > > +/*\n> > > + * Structs that are defined in core.mojom and have the skipHeader tag must be\n> > > + * forward-declared or #included here.\n> > > + */\n> > > +\n> > > struct CameraSensorInfo;\n> > > \n> > > class IPAInterface","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 87B42BD80E\n\tfor ;\n\tTue, 16 Mar 2021 02:23:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C5BE968D45;\n\tTue, 16 Mar 2021 03:23:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B867D602DB\n\tfor ;\n\tTue, 16 Mar 2021 03:23:11 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2971F3E7;\n\tTue, 16 Mar 2021 03:23:11 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g/gBQf6s\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615861391;\n\tbh=fzNRalRHzmIGOooSY3zLTp+T6XP16fQWrnE8wD8zXXc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=g/gBQf6sv09n32e9Fc6EYC/CCKWzJprEljVd5kOY1KYL2t5koadCcfTFZAUAPtQdd\n\t30uZRqJONE4+urBzskhh+3+NmNtcfaZ6WJw0vYmCt3hELoyjQPrIg8Rpu5A1qmVDOc\n\tz/KIg/K/e9MYW5CS+eS+ILrU/M3kIoiOXHp2rIls=","Date":"Tue, 16 Mar 2021 04:22:35 +0200","From":"Laurent Pinchart ","To":"paul.elder@ideasonboard.com","Message-ID":"","References":"<20210315092456.13525-1-paul.elder@ideasonboard.com>\n\t\n\t<20210316021645.GA2551@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210316021645.GA2551@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH] ipa: ipa_interface: Add comment to\n\tdefend the forward-declaration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]