{"id":11576,"url":"https://patchwork.libcamera.org/api/patches/11576/?format=json","web_url":"https://patchwork.libcamera.org/patch/11576/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210315092456.13525-1-paul.elder@ideasonboard.com>","date":"2021-03-15T09:24:56","name":"[libcamera-devel] ipa: ipa_interface: Add comment to defend the forward-declaration","commit_ref":"0d0ac3cb132ec5aa1fd7ba7bc0c5b50c139049ba","pull_url":null,"state":"accepted","archived":false,"hash":"6acd8c2c359da4736c06cb61dd9deef9a40712b0","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11576/mbox/","series":[{"id":1790,"url":"https://patchwork.libcamera.org/api/series/1790/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1790","date":"2021-03-15T09:24:56","name":"[libcamera-devel] ipa: ipa_interface: Add comment to defend the forward-declaration","version":1,"mbox":"https://patchwork.libcamera.org/series/1790/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11576/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11576/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 28FC4BD80E\n\tfor ;\n\tMon, 15 Mar 2021 09:25:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9182A68D40;\n\tMon, 15 Mar 2021 10:25:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 237CE602ED\n\tfor ;\n\tMon, 15 Mar 2021 10:25:08 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0D717556;\n\tMon, 15 Mar 2021 10:25:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"auwZAxG6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615800307;\n\tbh=Ny+qAk3bA5OBaThSSqybsPYh7IauoVbXbGwfMD8Zudo=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=auwZAxG6TVUpYkshTRODDF7FNO8ZB7kAJhwhZr8gnEMf9US0olES+qXXAgbmcaNzT\n\tSR3NO3V49AR1sA2ClQyA365CG/DP7R32OZWcAna57vc5ynh1k8Ga7o4P7LI3MbB29O\n\tH0WU+ygmoeAvBhF/z+0ATS5DRSp7GPb6d/j90kHU=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 15 Mar 2021 18:24:56 +0900","Message-Id":"<20210315092456.13525-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] ipa: ipa_interface: Add comment to defend\n\tthe forward-declaration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Any struct that is defined in core.mojom with the skipHeader tag needs\nto be present in ipa_interface, either forward-declared or #included.\nAdd an argument so that, in the future, people don't try to send patches\nremoving the seemingly unused forward-declaration.\n\nSigned-off-by: Paul Elder \n---\n include/libcamera/ipa/ipa_interface.h | 5 +++++\n 1 file changed, 5 insertions(+)","diff":"diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\nindex 47f81d1d..5d99e2cf 100644\n--- a/include/libcamera/ipa/ipa_interface.h\n+++ b/include/libcamera/ipa/ipa_interface.h\n@@ -20,6 +20,11 @@\n \n namespace libcamera {\n \n+/*\n+ * Structs that are defined in core.mojom and have the skipHeader tag must be\n+ * forward-declared or #included here.\n+ */\n+\n struct CameraSensorInfo;\n \n class IPAInterface\n","prefixes":["libcamera-devel"]}