[{"id":15652,"web_url":"https://patchwork.libcamera.org/comment/15652/","msgid":"","date":"2021-03-13T19:47:09","subject":"Re: [libcamera-devel] [PATCH] libcamera: delayed_controls: Add\n\tmissing documentation for ControlParams","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Sat, Mar 13, 2021 at 10:02:18AM +0000, Naushir Patuck wrote:\n> Document struct DelayedControls::ControlParams and its associated\n> fields.\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/libcamera/delayed_controls.cpp | 17 +++++++++++++++++\n> 1 file changed, 17 insertions(+)\n> \n> diff --git a/src/libcamera/delayed_controls.cpp b/src/libcamera/delayed_controls.cpp\n> index a3917fd99e7a..0f70d087b22c 100644\n> --- a/src/libcamera/delayed_controls.cpp\n> +++ b/src/libcamera/delayed_controls.cpp\n> @@ -37,6 +37,23 @@ LOG_DEFINE_CATEGORY(DelayedControls)\n> * delay.\n> */\n> \n> +/**\n> + * \\struct DelayedControls::ControlParams\n> + * \\brief Parameters associated with controls handled by the \\a DelayedControls\n> + * helper class\n> + *\n> + * \\var ControlParams::delay\n> + * \\brief Frame delay from setting the control on a sensor device to when it is\n> + * consumed during framing.\n> + *\n> + * \\var ControlParams::priorityWrite\n> + * \\brief Flag to indicate that this control must be applied\n> + * ahead of, and separately from the other controls. Typically set for the \\a\n> + * V4L2_CID_VBLANK control so that the device driver does not reject \\a\n> + * V4L2_CID_EXPOSURE control values that may be outside of the existing vertical\n> + * blanking specified bounds, but are within the new blanking bounds.\n\nI'll add a blank line after the first sentence, otherwise the brief\nisn't really a brief :-)\n\nReviewed-by: Laurent Pinchart \n\n> + */\n> +\n> /**\n> * \\brief Construct a DelayedControls instance\n> * \\param[in] device The V4L2 device the controls have to be applied to","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 967E6BD1F1\n\tfor ;\n\tSat, 13 Mar 2021 19:47:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F0965605B2;\n\tSat, 13 Mar 2021 20:47:46 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 469F7605B2\n\tfor ;\n\tSat, 13 Mar 2021 20:47:45 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A51FE3F0;\n\tSat, 13 Mar 2021 20:47:44 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"etfrJTU5\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615664864;\n\tbh=XtFKgSJNrK2ONL6KimfindV+cleqhu8HbjhcOASNl0Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=etfrJTU5g/IjJNI/SkRtZlXZP/t9+CHMSCGfrMGW19hGliZl7aowT+CHcjT91r7hJ\n\tyLfQdGGd7xqYCkSQ8bXR1grkQWwvIuIU1F6toxAQBw7mZurQTnF4OxMTuSDoyVJ14+\n\t2gb2AxT247HWonM9ASc07HjbKM7CtZBYS81e/wLg=","Date":"Sat, 13 Mar 2021 21:47:09 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20210313100218.2872534-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210313100218.2872534-1-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: delayed_controls: Add\n\tmissing documentation for ControlParams","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]