[{"id":15619,"web_url":"https://patchwork.libcamera.org/comment/15619/","msgid":"<4cde745c-37e9-dfb2-fb1a-0b62b577e4e8@ideasonboard.com>","date":"2021-03-12T13:42:05","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: ipu3: Pass the BDS\n\trectangle at IPA configure call","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi JM,\n\nOn 12/03/2021 13:03, Jean-Michel Hautbois wrote:\n> The IPU3 IPA will need the BDS configuration when the AWB/AGC algorithm\n> will be integrated.\n> In order to do that, the configure() interface needs to be modified.\n> \n\nDo you envisage needing to send more stream configuration parameters\ninto the IPA?\n\nI wonder if we should have a struct to send more stream parameters in,\nbut we can always change that if we get more.\n\n\n\n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> include/libcamera/ipa/ipu3.mojom | 2 +-\n> src/ipa/ipu3/ipu3.cpp | 7 +++++--\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 4 +++-\n> 3 files changed, 9 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\n> index 6ee11333..71b61c60 100644\n> --- a/include/libcamera/ipa/ipu3.mojom\n> +++ b/include/libcamera/ipa/ipu3.mojom\n> @@ -30,7 +30,7 @@ interface IPAIPU3Interface {\n> \tstart() => (int32 ret);\n> \tstop();\n> \n> -\tconfigure(map entityControls) => ();\n> +\tconfigure(map entityControls, Rectangle bds) => ();\n> \n> \tmapBuffers(array buffers);\n> \tunmapBuffers(array ids);\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index b63e58be..4bce5c27 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -35,7 +35,9 @@ public:\n> \tint start() override { return 0; }\n> \tvoid stop() override {}\n> \n> -\tvoid configure(const std::map &entityControls) override;\n> +\tvoid configure(\n> +\t\tconst std::map &entityControls,\n> +\t\tconst Rectangle &bds) override;\n> \n> \tvoid mapBuffers(const std::vector &buffers) override;\n> \tvoid unmapBuffers(const std::vector &ids) override;\n> @@ -62,7 +64,8 @@ private:\n> \tuint32_t maxGain_;\n> };\n> \n> -void IPAIPU3::configure(const std::map &entityControls)\n> +void IPAIPU3::configure(const std::map &entityControls,\n> +\t\t\t[[maybe_unused]] const Rectangle &bds)\n> {\n> \tif (entityControls.empty())\n> \t\treturn;\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 0d133031..4958d2fe 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -722,6 +722,7 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n> \tIPU3CameraData *data = cameraData(camera);\n> \tCIO2Device *cio2 = &data->cio2_;\n> \tImgUDevice *imgu = data->imgu_;\n> +\tRectangle bds{ 0, 0, data->pipeConfig_.bds };\n> \tint ret;\n> \n> \t/* Allocate buffers for internal pipeline usage. */\n> @@ -746,7 +747,8 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n> \t\tgoto error;\n> \n> \tentityControls.emplace(0, data->cio2_.sensor()->controls());\n> -\tdata->ipa_->configure(entityControls);\n> +\n> +\tdata->ipa_->configure(entityControls, bds);\n> \n> \treturn 0;\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A9591BD80C\n\tfor ;\n\tFri, 12 Mar 2021 13:42:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 020C868C6A;\n\tFri, 12 Mar 2021 14:42:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16DEC68C67\n\tfor ;\n\tFri, 12 Mar 2021 14:42:09 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FBB5A2A;\n\tFri, 12 Mar 2021 14:42:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g40xCqa0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615556528;\n\tbh=PWM+QaIuO9haFa43BMoa71Q6KPf6Hzehahusk7Y804I=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=g40xCqa0X8fXzpaATGlrB85EEjGFeobgxZJquPC9y2F12tw98Xp3t30sTY9GmJuxo\n\tKizwE7LCw9xlf774vaxsUI1EHiMMJajQO9QuSAmtyGq7spjjYjTlejABucW/rNVYeo\n\tmHtwWmDqe1uBbrXCSTaOsk6WcEGZ92s/d/8pJz6k=","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210312130304.34698-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210312130304.34698-3-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<4cde745c-37e9-dfb2-fb1a-0b62b577e4e8@ideasonboard.com>","Date":"Fri, 12 Mar 2021 13:42:05 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210312130304.34698-3-jeanmichel.hautbois@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: ipu3: Pass the BDS\n\trectangle at IPA configure call","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15620,"web_url":"https://patchwork.libcamera.org/comment/15620/","msgid":"<83c55593-89c4-605a-7637-8379b59b5026@ideasonboard.com>","date":"2021-03-12T13:47:23","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: ipu3: Pass the BDS\n\trectangle at IPA configure call","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hello Kieran,\n\nOn 12/03/2021 14:42, Kieran Bingham wrote:\n> Hi JM,\n> \n> On 12/03/2021 13:03, Jean-Michel Hautbois wrote:\n>> The IPU3 IPA will need the BDS configuration when the AWB/AGC algorithm\n>> will be integrated.\n>> In order to do that, the configure() interface needs to be modified.\n>>\n> \n> Do you envisage needing to send more stream configuration parameters\n> into the IPA?\n> \n> I wonder if we should have a struct to send more stream parameters in,\n> but we can always change that if we get more.\n\nI don't think it will be needed, as the parameters are really at the BDS\nstage. That's why I selected the bds Rectangle only :-).\n\n> \n>> Signed-off-by: Jean-Michel Hautbois \n>> ---\n>> include/libcamera/ipa/ipu3.mojom | 2 +-\n>> src/ipa/ipu3/ipu3.cpp | 7 +++++--\n>> src/libcamera/pipeline/ipu3/ipu3.cpp | 4 +++-\n>> 3 files changed, 9 insertions(+), 4 deletions(-)\n>>\n>> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\n>> index 6ee11333..71b61c60 100644\n>> --- a/include/libcamera/ipa/ipu3.mojom\n>> +++ b/include/libcamera/ipa/ipu3.mojom\n>> @@ -30,7 +30,7 @@ interface IPAIPU3Interface {\n>> \tstart() => (int32 ret);\n>> \tstop();\n>> \n>> -\tconfigure(map entityControls) => ();\n>> +\tconfigure(map entityControls, Rectangle bds) => ();\n>> \n>> \tmapBuffers(array buffers);\n>> \tunmapBuffers(array ids);\n>> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n>> index b63e58be..4bce5c27 100644\n>> --- a/src/ipa/ipu3/ipu3.cpp\n>> +++ b/src/ipa/ipu3/ipu3.cpp\n>> @@ -35,7 +35,9 @@ public:\n>> \tint start() override { return 0; }\n>> \tvoid stop() override {}\n>> \n>> -\tvoid configure(const std::map &entityControls) override;\n>> +\tvoid configure(\n>> +\t\tconst std::map &entityControls,\n>> +\t\tconst Rectangle &bds) override;\n>> \n>> \tvoid mapBuffers(const std::vector &buffers) override;\n>> \tvoid unmapBuffers(const std::vector &ids) override;\n>> @@ -62,7 +64,8 @@ private:\n>> \tuint32_t maxGain_;\n>> };\n>> \n>> -void IPAIPU3::configure(const std::map &entityControls)\n>> +void IPAIPU3::configure(const std::map &entityControls,\n>> +\t\t\t[[maybe_unused]] const Rectangle &bds)\n>> {\n>> \tif (entityControls.empty())\n>> \t\treturn;\n>> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> index 0d133031..4958d2fe 100644\n>> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> @@ -722,6 +722,7 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n>> \tIPU3CameraData *data = cameraData(camera);\n>> \tCIO2Device *cio2 = &data->cio2_;\n>> \tImgUDevice *imgu = data->imgu_;\n>> +\tRectangle bds{ 0, 0, data->pipeConfig_.bds };\n>> \tint ret;\n>> \n>> \t/* Allocate buffers for internal pipeline usage. */\n>> @@ -746,7 +747,8 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n>> \t\tgoto error;\n>> \n>> \tentityControls.emplace(0, data->cio2_.sensor()->controls());\n>> -\tdata->ipa_->configure(entityControls);\n>> +\n>> +\tdata->ipa_->configure(entityControls, bds);\n>> \n>> \treturn 0;\n>> \n>>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69532BD1F1\n\tfor ;\n\tFri, 12 Mar 2021 13:47:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C386B68C68;\n\tFri, 12 Mar 2021 14:47:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB6BF68C67\n\tfor ;\n\tFri, 12 Mar 2021 14:47:24 +0100 (CET)","from [IPv6:2a01:e0a:169:7140:ddbd:a3a3:e47b:e390] (unknown\n\t[IPv6:2a01:e0a:169:7140:ddbd:a3a3:e47b:e390])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 631B0A2A;\n\tFri, 12 Mar 2021 14:47:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Kqn5cM/E\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615556844;\n\tbh=IlfYRGEFaitm0zf1UjTi97+rJXGL2vRvYaCxwZCZO5Q=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=Kqn5cM/Etl2N0iMrkcmp1bsqH4+LpRlQfbX7/hHLnpa6cczhai6+eJEnpkdmGWX+f\n\t4PiOv5kuQU1HClVYO8FLM+yNFTUnVeUzEgYv/1HN3B7BaGLJ6jIdPRU3O+/s9ZTERF\n\tafGFYMH9KfBR0rgEaOfTA4JUb8qeRTq0eSdEDowM=","To":"kieran.bingham@ideasonboard.com,\n\tJean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210312130304.34698-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210312130304.34698-3-jeanmichel.hautbois@ideasonboard.com>\n\t<4cde745c-37e9-dfb2-fb1a-0b62b577e4e8@ideasonboard.com>","From":"Jean-Michel Hautbois ","Message-ID":"<83c55593-89c4-605a-7637-8379b59b5026@ideasonboard.com>","Date":"Fri, 12 Mar 2021 14:47:23 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.7.1","MIME-Version":"1.0","In-Reply-To":"<4cde745c-37e9-dfb2-fb1a-0b62b577e4e8@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: ipu3: Pass the BDS\n\trectangle at IPA configure call","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15642,"web_url":"https://patchwork.libcamera.org/comment/15642/","msgid":"<20210313083235.62i56m7tl5f5zyxs@uno.localdomain>","date":"2021-03-13T08:32:35","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: ipu3: Pass the BDS\n\trectangle at IPA configure call","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Jean-Micheal,\n\nOn Fri, Mar 12, 2021 at 02:03:04PM +0100, Jean-Michel Hautbois wrote:\n> The IPU3 IPA will need the BDS configuration when the AWB/AGC algorithm\n> will be integrated.\n> In order to do that, the configure() interface needs to be modified.\n\nOnly BDS should be passed to the IPA, or should the whole pipe\nconfiguration ? True that, when runnin over IPC, the less data are\nexchanged the better..\n\n>\n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> include/libcamera/ipa/ipu3.mojom | 2 +-\n> src/ipa/ipu3/ipu3.cpp | 7 +++++--\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 4 +++-\n> 3 files changed, 9 insertions(+), 4 deletions(-)\n>\n> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\n> index 6ee11333..71b61c60 100644\n> --- a/include/libcamera/ipa/ipu3.mojom\n> +++ b/include/libcamera/ipa/ipu3.mojom\n> @@ -30,7 +30,7 @@ interface IPAIPU3Interface {\n> \tstart() => (int32 ret);\n> \tstop();\n>\n> -\tconfigure(map entityControls) => ();\n> +\tconfigure(map entityControls, Rectangle bds) => ();\n>\n> \tmapBuffers(array buffers);\n> \tunmapBuffers(array ids);\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index b63e58be..4bce5c27 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -35,7 +35,9 @@ public:\n> \tint start() override { return 0; }\n> \tvoid stop() override {}\n>\n> -\tvoid configure(const std::map &entityControls) override;\n> +\tvoid configure(\n> +\t\tconst std::map &entityControls,\n> +\t\tconst Rectangle &bds) override;\n>\n> \tvoid mapBuffers(const std::vector &buffers) override;\n> \tvoid unmapBuffers(const std::vector &ids) override;\n> @@ -62,7 +64,8 @@ private:\n> \tuint32_t maxGain_;\n> };\n>\n> -void IPAIPU3::configure(const std::map &entityControls)\n> +void IPAIPU3::configure(const std::map &entityControls,\n> +\t\t\t[[maybe_unused]] const Rectangle &bds)\n> {\n> \tif (entityControls.empty())\n> \t\treturn;\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 0d133031..4958d2fe 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -722,6 +722,7 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n> \tIPU3CameraData *data = cameraData(camera);\n> \tCIO2Device *cio2 = &data->cio2_;\n> \tImgUDevice *imgu = data->imgu_;\n> +\tRectangle bds{ 0, 0, data->pipeConfig_.bds };\n> \tint ret;\n>\n> \t/* Allocate buffers for internal pipeline usage. */\n> @@ -746,7 +747,8 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n> \t\tgoto error;\n>\n> \tentityControls.emplace(0, data->cio2_.sensor()->controls());\n> -\tdata->ipa_->configure(entityControls);\n> +\n\nIntentional empty line ?\n\nThanks\n j\n\n> +\tdata->ipa_->configure(entityControls, bds);\n>\n> \treturn 0;\n>\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC6CEBD1F1\n\tfor ;\n\tSat, 13 Mar 2021 08:32:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 952F768C67;\n\tSat, 13 Mar 2021 09:32:06 +0100 (CET)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7ACC3602E3\n\tfor ;\n\tSat, 13 Mar 2021 09:32:05 +0100 (CET)","from uno.localdomain (host-79-22-58-175.retail.telecomitalia.it\n\t[79.22.58.175]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id C056060007;\n\tSat, 13 Mar 2021 08:32:04 +0000 (UTC)"],"X-Originating-IP":"79.22.58.175","Date":"Sat, 13 Mar 2021 09:32:35 +0100","From":"Jacopo Mondi ","To":"Jean-Michel Hautbois ","Message-ID":"<20210313083235.62i56m7tl5f5zyxs@uno.localdomain>","References":"<20210312130304.34698-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210312130304.34698-3-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210312130304.34698-3-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: ipu3: Pass the BDS\n\trectangle at IPA configure call","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15674,"web_url":"https://patchwork.libcamera.org/comment/15674/","msgid":"<20210314092024.jh4mya4r2nhh6jy7@uno.localdomain>","date":"2021-03-14T09:20:24","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: ipu3: Pass the BDS\n\trectangle at IPA configure call","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi again,\n\nOn Sat, Mar 13, 2021 at 09:32:35AM +0100, Jacopo Mondi wrote:\n> Hi Jean-Micheal,\n>\n> On Fri, Mar 12, 2021 at 02:03:04PM +0100, Jean-Michel Hautbois wrote:\n> > The IPU3 IPA will need the BDS configuration when the AWB/AGC algorithm\n> > will be integrated.\n> > In order to do that, the configure() interface needs to be modified.\n>\n> Only BDS should be passed to the IPA, or should the whole pipe\n> configuration ? True that, when runnin over IPC, the less data are\n> exchanged the better..\n>\n\nI've just noticed Kieran had the same question and you replied\nalready.\n\nAnyway, it will be trivial to pass the rest of the pipe config if\nneeded.\n\nPlease add\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> >\n> > Signed-off-by: Jean-Michel Hautbois \n> > ---\n> > include/libcamera/ipa/ipu3.mojom | 2 +-\n> > src/ipa/ipu3/ipu3.cpp | 7 +++++--\n> > src/libcamera/pipeline/ipu3/ipu3.cpp | 4 +++-\n> > 3 files changed, 9 insertions(+), 4 deletions(-)\n> >\n> > diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\n> > index 6ee11333..71b61c60 100644\n> > --- a/include/libcamera/ipa/ipu3.mojom\n> > +++ b/include/libcamera/ipa/ipu3.mojom\n> > @@ -30,7 +30,7 @@ interface IPAIPU3Interface {\n> > \tstart() => (int32 ret);\n> > \tstop();\n> >\n> > -\tconfigure(map entityControls) => ();\n> > +\tconfigure(map entityControls, Rectangle bds) => ();\n> >\n> > \tmapBuffers(array buffers);\n> > \tunmapBuffers(array ids);\n> > diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> > index b63e58be..4bce5c27 100644\n> > --- a/src/ipa/ipu3/ipu3.cpp\n> > +++ b/src/ipa/ipu3/ipu3.cpp\n> > @@ -35,7 +35,9 @@ public:\n> > \tint start() override { return 0; }\n> > \tvoid stop() override {}\n> >\n> > -\tvoid configure(const std::map &entityControls) override;\n> > +\tvoid configure(\n> > +\t\tconst std::map &entityControls,\n> > +\t\tconst Rectangle &bds) override;\n> >\n> > \tvoid mapBuffers(const std::vector &buffers) override;\n> > \tvoid unmapBuffers(const std::vector &ids) override;\n> > @@ -62,7 +64,8 @@ private:\n> > \tuint32_t maxGain_;\n> > };\n> >\n> > -void IPAIPU3::configure(const std::map &entityControls)\n> > +void IPAIPU3::configure(const std::map &entityControls,\n> > +\t\t\t[[maybe_unused]] const Rectangle &bds)\n> > {\n> > \tif (entityControls.empty())\n> > \t\treturn;\n> > diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > index 0d133031..4958d2fe 100644\n> > --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> > @@ -722,6 +722,7 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n> > \tIPU3CameraData *data = cameraData(camera);\n> > \tCIO2Device *cio2 = &data->cio2_;\n> > \tImgUDevice *imgu = data->imgu_;\n> > +\tRectangle bds{ 0, 0, data->pipeConfig_.bds };\n> > \tint ret;\n> >\n> > \t/* Allocate buffers for internal pipeline usage. */\n> > @@ -746,7 +747,8 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n> > \t\tgoto error;\n> >\n> > \tentityControls.emplace(0, data->cio2_.sensor()->controls());\n> > -\tdata->ipa_->configure(entityControls);\n> > +\n>\n> Intentional empty line ?\n>\n> Thanks\n> j\n>\n> > +\tdata->ipa_->configure(entityControls, bds);\n> >\n> > \treturn 0;\n> >\n> > --\n> > 2.27.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63DAABD1F1\n\tfor ;\n\tSun, 14 Mar 2021 09:19:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AA3EF60850;\n\tSun, 14 Mar 2021 10:19:55 +0100 (CET)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FDEF605B1\n\tfor ;\n\tSun, 14 Mar 2021 10:19:54 +0100 (CET)","from uno.localdomain (host-79-22-58-175.retail.telecomitalia.it\n\t[79.22.58.175]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 7EA92E0005;\n\tSun, 14 Mar 2021 09:19:53 +0000 (UTC)"],"X-Originating-IP":"79.22.58.175","Date":"Sun, 14 Mar 2021 10:20:24 +0100","From":"Jacopo Mondi ","To":"Jean-Michel Hautbois ","Message-ID":"<20210314092024.jh4mya4r2nhh6jy7@uno.localdomain>","References":"<20210312130304.34698-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210312130304.34698-3-jeanmichel.hautbois@ideasonboard.com>\n\t<20210313083235.62i56m7tl5f5zyxs@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210313083235.62i56m7tl5f5zyxs@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: ipu3: Pass the BDS\n\trectangle at IPA configure call","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15689,"web_url":"https://patchwork.libcamera.org/comment/15689/","msgid":"","date":"2021-03-15T02:37:03","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: ipu3: Pass the BDS\n\trectangle at IPA configure call","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Fri, Mar 12, 2021 at 02:03:04PM +0100, Jean-Michel Hautbois wrote:\n> The IPU3 IPA will need the BDS configuration when the AWB/AGC algorithm\n> will be integrated.\n> In order to do that, the configure() interface needs to be modified.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> include/libcamera/ipa/ipu3.mojom | 2 +-\n> src/ipa/ipu3/ipu3.cpp | 7 +++++--\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 4 +++-\n> 3 files changed, 9 insertions(+), 4 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\n> index 6ee11333..71b61c60 100644\n> --- a/include/libcamera/ipa/ipu3.mojom\n> +++ b/include/libcamera/ipa/ipu3.mojom\n> @@ -30,7 +30,7 @@ interface IPAIPU3Interface {\n> \tstart() => (int32 ret);\n> \tstop();\n> \n> -\tconfigure(map entityControls) => ();\n> +\tconfigure(map entityControls, Rectangle bds) => ();\n\nbds stands for Bayer Down Scaler if I'm not mistaken. What is this\nrectangle ? Is it the input size to the BDS, the input crop rectangle,\nthe output crop rectangle, the output size, or something else ? Naming\nthe variable accordingly would be more readable.\n\n> \n> \tmapBuffers(array buffers);\n> \tunmapBuffers(array ids);\n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index b63e58be..4bce5c27 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -35,7 +35,9 @@ public:\n> \tint start() override { return 0; }\n> \tvoid stop() override {}\n> \n> -\tvoid configure(const std::map &entityControls) override;\n> +\tvoid configure(\n> +\t\tconst std::map &entityControls,\n> +\t\tconst Rectangle &bds) override;\n> \n> \tvoid mapBuffers(const std::vector &buffers) override;\n> \tvoid unmapBuffers(const std::vector &ids) override;\n> @@ -62,7 +64,8 @@ private:\n> \tuint32_t maxGain_;\n> };\n> \n> -void IPAIPU3::configure(const std::map &entityControls)\n> +void IPAIPU3::configure(const std::map &entityControls,\n> +\t\t\t[[maybe_unused]] const Rectangle &bds)\n> {\n> \tif (entityControls.empty())\n> \t\treturn;\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 0d133031..4958d2fe 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -722,6 +722,7 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n> \tIPU3CameraData *data = cameraData(camera);\n> \tCIO2Device *cio2 = &data->cio2_;\n> \tImgUDevice *imgu = data->imgu_;\n> +\tRectangle bds{ 0, 0, data->pipeConfig_.bds };\n> \tint ret;\n> \n> \t/* Allocate buffers for internal pipeline usage. */\n> @@ -746,7 +747,8 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n> \t\tgoto error;\n> \n> \tentityControls.emplace(0, data->cio2_.sensor()->controls());\n> -\tdata->ipa_->configure(entityControls);\n> +\n\nYou can move the bds variable declaration right here.\n\n> +\tdata->ipa_->configure(entityControls, bds);\n\nWith these two comments addressed,\n\nReviewed-by: Laurent Pinchart \n> \n> \treturn 0;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AAC77BD80E\n\tfor ;\n\tMon, 15 Mar 2021 02:37:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 078286084E;\n\tMon, 15 Mar 2021 03:37:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E847602E0\n\tfor ;\n\tMon, 15 Mar 2021 03:37:39 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7DE5E87A;\n\tMon, 15 Mar 2021 03:37:38 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PUAT/knk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615775858;\n\tbh=OhvDTdt5zWIUeYxQ7HXkFXCAdioHE7iOfOP9K9C8A5s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PUAT/knkQKp4Jdfvwd5tNKAsm0kzjwF97Na2RZolbbawM64S6PFvgmBe9gmH76bvN\n\tza6QMCDmR9zs0fICnuNfeykkSiSM/xkxgYX15GtregIiAE3dD2pu+dKk8JdW5L5xrU\n\tWduW5NK2eWMhwAhkwFRZu7U3tCNchu3ktGirJSDA=","Date":"Mon, 15 Mar 2021 04:37:03 +0200","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210312130304.34698-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210312130304.34698-3-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210312130304.34698-3-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: ipu3: Pass the BDS\n\trectangle at IPA configure call","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]