{"id":11571,"url":"https://patchwork.libcamera.org/api/patches/11571/?format=json","web_url":"https://patchwork.libcamera.org/patch/11571/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210312130304.34698-3-jeanmichel.hautbois@ideasonboard.com>","date":"2021-03-12T13:03:04","name":"[libcamera-devel,2/2] libcamera: ipu3: Pass the BDS rectangle at IPA configure call","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"36732b3d0da6430bd259bed0417062effd20589f","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11571/mbox/","series":[{"id":1787,"url":"https://patchwork.libcamera.org/api/series/1787/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1787","date":"2021-03-12T13:03:02","name":"Prepare IPU3 pipeline to pass BDS to IPA","version":1,"mbox":"https://patchwork.libcamera.org/series/1787/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11571/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11571/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23575BD1F1\n\tfor ;\n\tFri, 12 Mar 2021 13:03:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D03C068AA1;\n\tFri, 12 Mar 2021 14:03:13 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2635F68C6C\n\tfor ;\n\tFri, 12 Mar 2021 14:03:10 +0100 (CET)","from localhost.localdomain (unknown\n\t[IPv6:2a01:e0a:169:7140:ddbd:a3a3:e47b:e390])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B5914A2A;\n\tFri, 12 Mar 2021 14:03:09 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"IuR0O15q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615554189;\n\tbh=jRaPSBmnyA2T0zu3Y/AwTMDyooztmN7esGJryc+sWdE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=IuR0O15qXNOCEoxYBKXvFc34g3dOlJZlqJNFwaH8DR4flB1DWvfBDJJKApF+XBNhh\n\t0u20QbH/2oqkbY2yaYkfqnW2tG9TA4coPBMByRTQ8WMTZSEINLW0XqzWgDxbqgM2Dv\n\tIDAPb5caH6w0RXeyh9YLOMjTa5Vtxqi4Rmnkx0dA=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 12 Mar 2021 14:03:04 +0100","Message-Id":"<20210312130304.34698-3-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210312130304.34698-1-jeanmichel.hautbois@ideasonboard.com>","References":"<20210312130304.34698-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 2/2] libcamera: ipu3: Pass the BDS\n\trectangle at IPA configure call","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The IPU3 IPA will need the BDS configuration when the AWB/AGC algorithm\nwill be integrated.\nIn order to do that, the configure() interface needs to be modified.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n include/libcamera/ipa/ipu3.mojom | 2 +-\n src/ipa/ipu3/ipu3.cpp | 7 +++++--\n src/libcamera/pipeline/ipu3/ipu3.cpp | 4 +++-\n 3 files changed, 9 insertions(+), 4 deletions(-)","diff":"diff --git a/include/libcamera/ipa/ipu3.mojom b/include/libcamera/ipa/ipu3.mojom\nindex 6ee11333..71b61c60 100644\n--- a/include/libcamera/ipa/ipu3.mojom\n+++ b/include/libcamera/ipa/ipu3.mojom\n@@ -30,7 +30,7 @@ interface IPAIPU3Interface {\n \tstart() => (int32 ret);\n \tstop();\n \n-\tconfigure(map entityControls) => ();\n+\tconfigure(map entityControls, Rectangle bds) => ();\n \n \tmapBuffers(array buffers);\n \tunmapBuffers(array ids);\ndiff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\nindex b63e58be..4bce5c27 100644\n--- a/src/ipa/ipu3/ipu3.cpp\n+++ b/src/ipa/ipu3/ipu3.cpp\n@@ -35,7 +35,9 @@ public:\n \tint start() override { return 0; }\n \tvoid stop() override {}\n \n-\tvoid configure(const std::map &entityControls) override;\n+\tvoid configure(\n+\t\tconst std::map &entityControls,\n+\t\tconst Rectangle &bds) override;\n \n \tvoid mapBuffers(const std::vector &buffers) override;\n \tvoid unmapBuffers(const std::vector &ids) override;\n@@ -62,7 +64,8 @@ private:\n \tuint32_t maxGain_;\n };\n \n-void IPAIPU3::configure(const std::map &entityControls)\n+void IPAIPU3::configure(const std::map &entityControls,\n+\t\t\t[[maybe_unused]] const Rectangle &bds)\n {\n \tif (entityControls.empty())\n \t\treturn;\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 0d133031..4958d2fe 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -722,6 +722,7 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n \tIPU3CameraData *data = cameraData(camera);\n \tCIO2Device *cio2 = &data->cio2_;\n \tImgUDevice *imgu = data->imgu_;\n+\tRectangle bds{ 0, 0, data->pipeConfig_.bds };\n \tint ret;\n \n \t/* Allocate buffers for internal pipeline usage. */\n@@ -746,7 +747,8 @@ int PipelineHandlerIPU3::start(Camera *camera, [[maybe_unused]] const ControlLis\n \t\tgoto error;\n \n \tentityControls.emplace(0, data->cio2_.sensor()->controls());\n-\tdata->ipa_->configure(entityControls);\n+\n+\tdata->ipa_->configure(entityControls, bds);\n \n \treturn 0;\n \n","prefixes":["libcamera-devel","2/2"]}