[{"id":15669,"web_url":"https://patchwork.libcamera.org/comment/15669/","msgid":"","date":"2021-03-14T02:03:20","subject":"Re: [libcamera-devel] [PATCH 6/8] libcamera: pipeline: ipu3:\n\tframes: Group FrameBuffer operations","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Mar 12, 2021 at 06:11:29AM +0000, Kieran Bingham wrote:\n> Ensure that checks on resource availability are handled first, and then\n> operate on the queues only after the resources are confirmed as\n> available.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/pipeline/ipu3/frames.cpp | 3 ++-\n> 1 file changed, 2 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp\n> index b8b471c3c561..7a7c5643df43 100644\n> --- a/src/libcamera/pipeline/ipu3/frames.cpp\n> +++ b/src/libcamera/pipeline/ipu3/frames.cpp\n> @@ -47,12 +47,13 @@ IPU3Frames::Info *IPU3Frames::create(Request *request)\n> \t\tLOG(IPU3, Error) << \"Parameters buffer underrun\";\n> \t\treturn nullptr;\n> \t}\n> -\tFrameBuffer *paramBuffer = availableParamBuffers_.front();\n> \n> \tif (availableStatBuffers_.empty()) {\n> \t\tLOG(IPU3, Error) << \"Statistics buffer underrun\";\n> \t\treturn nullptr;\n> \t}\n> +\n> +\tFrameBuffer *paramBuffer = availableParamBuffers_.front();\n> \tFrameBuffer *statBuffer = availableStatBuffers_.front();\n> \n> \tavailableParamBuffers_.pop();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6E60BD1F1\n\tfor ;\n\tSun, 14 Mar 2021 02:03:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9EAF060850;\n\tSun, 14 Mar 2021 03:03:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 80B826084D\n\tfor ;\n\tSun, 14 Mar 2021 03:03:56 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E87BC55C;\n\tSun, 14 Mar 2021 03:03:55 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hzhjbhwL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615687436;\n\tbh=KHB+MBbouoVr1Vz9L03/65vMZq2w3Qx1XK6glmiSY9c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hzhjbhwLgE+EhBHt/kBOYysUGy/mIHQM4bNW+hw97N+LXhIK4lhZbgWaxBDl2S91Q\n\t2jljQqivWj1pHl/dOdGA/3hy93MDkN5moE05SiCpKAyrvW9NsSGLBVb/ZUy8XSDnYF\n\tvVcXaFeLBLKoGtfNDQH19JFHUeVsWK0/VSNT9kIQ=","Date":"Sun, 14 Mar 2021 04:03:20 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210312061131.854849-1-kieran.bingham@ideasonboard.com>\n\t<20210312061131.854849-7-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210312061131.854849-7-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 6/8] libcamera: pipeline: ipu3:\n\tframes: Group FrameBuffer operations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]