{"id":11564,"url":"https://patchwork.libcamera.org/api/patches/11564/?format=json","web_url":"https://patchwork.libcamera.org/patch/11564/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210312061131.854849-5-kieran.bingham@ideasonboard.com>","date":"2021-03-12T06:11:27","name":"[libcamera-devel,4/8] libcamera: pipeline: ipu3: frames: Use the request sequence","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"9114ef6346055ae9a65e4b3789ccfb1ec15eed03","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11564/mbox/","series":[{"id":1786,"url":"https://patchwork.libcamera.org/api/series/1786/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1786","date":"2021-03-12T06:11:23","name":"IPU3 Debug improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/1786/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11564/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11564/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C55BBD1F1\n\tfor ;\n\tFri, 12 Mar 2021 06:11:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2D05F68C69;\n\tFri, 12 Mar 2021 07:11:43 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 65F2B68C71\n\tfor ;\n\tFri, 12 Mar 2021 07:11:37 +0100 (CET)","from localhost.localdomain\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DF232ACB;\n\tFri, 12 Mar 2021 07:11:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"MjuasMTL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615529497;\n\tbh=GN4ZSNV/Ucmhqppk28VewwPpJ1HdcIXmRI2HpNpYuWE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=MjuasMTLU/JOaLXJeR8j9JdaSAouieH2HLLirkPRutqdnZ3hYrxjc0aQuh58gMBrd\n\t7OhlXhDU1MvYGXiLbOIBhD5hObtMZoE6h8wcrAhJ/dGTbSR4FpClEpGOaWwvMFP3C3\n\tT5hUb6ODr8J+z1w5S3kydoUodWou6jDG8X9VbQCk=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Fri, 12 Mar 2021 06:11:27 +0000","Message-Id":"<20210312061131.854849-5-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210312061131.854849-1-kieran.bingham@ideasonboard.com>","References":"<20210312061131.854849-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 4/8] libcamera: pipeline: ipu3: frames:\n\tUse the request sequence","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"For all frame indexes, use the same sequence number as generated\nby the Request object.\n\nThis allows clear matching of what operations occured to which request.\n\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/pipeline/ipu3/frames.cpp | 4 +---\n src/libcamera/pipeline/ipu3/frames.h | 1 -\n 2 files changed, 1 insertion(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/frames.cpp b/src/libcamera/pipeline/ipu3/frames.cpp\nindex 151ebfe7ca5f..4198e2019f3f 100644\n--- a/src/libcamera/pipeline/ipu3/frames.cpp\n+++ b/src/libcamera/pipeline/ipu3/frames.cpp\n@@ -18,7 +18,6 @@ namespace libcamera {\n LOG_DECLARE_CATEGORY(IPU3)\n \n IPU3Frames::IPU3Frames()\n-\t: nextId_(0)\n {\n }\n \n@@ -31,7 +30,6 @@ void IPU3Frames::init(const std::vector> ¶mBuff\n \tfor (const std::unique_ptr &buffer : statBuffers)\n \t\tavailableStatBuffers_.push(buffer.get());\n \n-\tnextId_ = 0;\n \tframeInfo_.clear();\n }\n \n@@ -43,7 +41,7 @@ void IPU3Frames::clear()\n \n IPU3Frames::Info *IPU3Frames::create(Request *request)\n {\n-\tunsigned int id = nextId_++;\n+\tunsigned int id = request->sequence();\n \n \tif (availableParamBuffers_.empty()) {\n \t\tLOG(IPU3, Error) << \"Parameters buffer underrun\";\ndiff --git a/src/libcamera/pipeline/ipu3/frames.h b/src/libcamera/pipeline/ipu3/frames.h\nindex 106e5c15cc7a..4acdf48eca9d 100644\n--- a/src/libcamera/pipeline/ipu3/frames.h\n+++ b/src/libcamera/pipeline/ipu3/frames.h\n@@ -53,7 +53,6 @@ private:\n \tstd::queue availableParamBuffers_;\n \tstd::queue availableStatBuffers_;\n \n-\tunsigned int nextId_;\n \tstd::map> frameInfo_;\n };\n \n","prefixes":["libcamera-devel","4/8"]}