{"id":11561,"url":"https://patchwork.libcamera.org/api/patches/11561/?format=json","web_url":"https://patchwork.libcamera.org/patch/11561/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210312061131.854849-2-kieran.bingham@ideasonboard.com>","date":"2021-03-12T06:11:24","name":"[libcamera-devel,1/8] libcamera: request: Provide a sequence number","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"b2dc73a573049530c5112f015f881eb544ac59fd","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11561/mbox/","series":[{"id":1786,"url":"https://patchwork.libcamera.org/api/series/1786/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1786","date":"2021-03-12T06:11:23","name":"IPU3 Debug improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/1786/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11561/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11561/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8CBB0BD1F1\n\tfor ;\n\tFri, 12 Mar 2021 06:11:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9067F68C74;\n\tFri, 12 Mar 2021 07:11:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40302602ED\n\tfor ;\n\tFri, 12 Mar 2021 07:11:36 +0100 (CET)","from localhost.localdomain\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BCA8E8F9;\n\tFri, 12 Mar 2021 07:11:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mv+N/Ik7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615529495;\n\tbh=WSRrLaQBYWjP+vcKGc7yio/nTR2LbBqY95CXK5wPI2I=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mv+N/Ik7Ius9KMOGxrQ+jvq87tKAOX6Ho7Yd2GbFLOEXM8aFWwgy9ouvTJU/jMZPr\n\tBgYO+p5P1QbZkZ34j32/p54hGEI/SSPqrOYVRM3N0dbh7DpZ3BgfFHBUC/iimTQ+kr\n\t87WufnbY8Jn0OO+mzPTzR/NsneANcfAjUaR04LbQ=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Fri, 12 Mar 2021 06:11:24 +0000","Message-Id":"<20210312061131.854849-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210312061131.854849-1-kieran.bingham@ideasonboard.com>","References":"<20210312061131.854849-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 1/8] libcamera: request: Provide a\n\tsequence number","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide a sequence number on Requests which are added by the pipeline\nhandler.\n\nEach pipeline handler keeps a requestSequence and increments everytime a\nrequest is queued.\n\nThe sequence number is associated with the Request and can be utilised\nfor assisting with debugging, and printing the queueing sequence of in\nflight requests.\n\nSigned-off-by: Kieran Bingham \n---\n include/libcamera/internal/pipeline_handler.h | 4 +++-\n include/libcamera/request.h | 2 ++\n src/libcamera/pipeline_handler.cpp | 2 ++\n 3 files changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex 6aca0b46f43d..0655a665a85f 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -38,7 +38,7 @@ class CameraData\n {\n public:\n \texplicit CameraData(PipelineHandler *pipe)\n-\t\t: pipe_(pipe)\n+\t\t: pipe_(pipe), requestSequence_(0)\n \t{\n \t}\n \tvirtual ~CameraData() = default;\n@@ -48,6 +48,8 @@ public:\n \tControlInfoMap controlInfo_;\n \tControlList properties_;\n \n+\tuint64_t requestSequence_;\n+\n private:\n \tLIBCAMERA_DISABLE_COPY(CameraData)\n };\ndiff --git a/include/libcamera/request.h b/include/libcamera/request.h\nindex 6e5aad5f6b75..6f2f881e840a 100644\n--- a/include/libcamera/request.h\n+++ b/include/libcamera/request.h\n@@ -50,6 +50,7 @@ public:\n \tint addBuffer(const Stream *stream, FrameBuffer *buffer);\n \tFrameBuffer *findBuffer(const Stream *stream) const;\n \n+\tuint64_t sequence() const { return sequence_; }\n \tuint64_t cookie() const { return cookie_; }\n \tStatus status() const { return status_; }\n \n@@ -71,6 +72,7 @@ private:\n \tBufferMap bufferMap_;\n \tstd::unordered_set pending_;\n \n+\tuint64_t sequence_;\n \tconst uint64_t cookie_;\n \tStatus status_;\n \tbool cancelled_;\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex d22991d318c9..e3d4975d9ffd 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -382,6 +382,8 @@ int PipelineHandler::queueRequest(Request *request)\n \tCameraData *data = cameraData(camera);\n \tdata->queuedRequests_.push_back(request);\n \n+\trequest->sequence_ = data->requestSequence_++;\n+\n \tint ret = queueRequestDevice(camera, request);\n \tif (ret)\n \t\tdata->queuedRequests_.remove(request);\n","prefixes":["libcamera-devel","1/8"]}