[{"id":1554,"web_url":"https://patchwork.libcamera.org/comment/1554/","msgid":"<20190503170904.GB4903@pendragon.ideasonboard.com>","date":"2019-05-03T17:09:04","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_device: Increase\n\terror level for unsupported devices","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, May 03, 2019 at 04:37:07PM +0100, Kieran Bingham wrote:\n> If a component tries to open an unsupported device type, no error is presented\n> unless debug is enabled.\n> \n> Report an error if an unsupported device type is opened to ease pipeline\n> development.\n\nI think there's little reason for a pipeline handler to try and open an\nunsupported device type, so\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nBut if anyone can think of a use case, please say so.\n\n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> ---\n>  src/libcamera/v4l2_device.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index e22323de19c3..8366ffc4db55 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -349,7 +349,7 @@ int V4L2Device::open()\n>  \t\tfdEvent_ = new EventNotifier(fd_, EventNotifier::Read);\n>  \t\tbufferType_ = V4L2_BUF_TYPE_META_CAPTURE;\n>  \t} else {\n> -\t\tLOG(V4L2, Debug) << \"Device is not a supported type\";\n> +\t\tLOG(V4L2, Error) << \"Device is not a supported type\";\n>  \t\treturn -EINVAL;\n>  \t}\n>","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8B47F60003\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  3 May 2019 19:09:21 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 184EF31E;\n\tFri,  3 May 2019 19:09:18 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556903358;\n\tbh=5Oh1J89+t0QVLFFgo7qxQG1s7FEUh4FsSBFgPQJtylI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=h3wZPzUTk13snd9IVu9yk54/My/kRozBUQo7jGZrQzPj1fCJz6kOZlJ6Gn5g4Y2TG\n\tmQPQqGJ13cYXSzLUWTJrFKXf90zupL/WQprQhgA5nKW+TvMv/zW1dGCrq0gt6GmhR7\n\tCdMv072i5j8jfMtRCNIUgOAruPMbFNoutlzOV2mc=","Date":"Fri, 3 May 2019 20:09:04 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190503170904.GB4903@pendragon.ideasonboard.com>","References":"<20190503153707.8918-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190503153707.8918-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_device: Increase\n\terror level for unsupported devices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 03 May 2019 17:09:21 -0000"}}]