{"id":1156,"url":"https://patchwork.libcamera.org/api/patches/1156/?format=json","web_url":"https://patchwork.libcamera.org/patch/1156/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190503153707.8918-1-kieran.bingham@ideasonboard.com>","date":"2019-05-03T15:37:07","name":"[libcamera-devel] libcamera: v4l2_device: Increase error level for unsupported devices","commit_ref":"05ff3d56e04a33756a679d24fe5542e9e50935b4","pull_url":null,"state":"accepted","archived":false,"hash":"7a63816b2c6c46bbe24015e9cfd94f32501c05fd","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1156/mbox/","series":[{"id":294,"url":"https://patchwork.libcamera.org/api/series/294/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=294","date":"2019-05-03T15:37:07","name":"[libcamera-devel] libcamera: v4l2_device: Increase error level for unsupported devices","version":1,"mbox":"https://patchwork.libcamera.org/series/294/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1156/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1156/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2A4A360003\n\tfor ;\n\tFri, 3 May 2019 17:37:11 +0200 (CEST)","from Q.Home (unknown [IPv6:2a02:c7f:1887:5d00:c990:5ff4:193b:c9b8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B8D2931E;\n\tFri, 3 May 2019 17:37:10 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556897830;\n\tbh=5nJj2tjgIE60BvSHJ8564S+I+kuAv60vcG2cntfFVQI=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=K0vivtD/vLuI+TAjvYeGtrlUufxJLfimawBEThz1cl+hE/AT6rbwgpLVy3DAxDcVE\n\tIY7AQJBxgJko3NBiVGFl2zlMq0Ny40QHPcKouSrEZ1MJdccneXO+9qRVFuQBnUCW/m\n\tw1rujMFLdwPezAOEQfSxmd3hgRb5fsgSvijP9Lqc=","From":"Kieran Bingham ","To":"LibCamera Devel ","Date":"Fri, 3 May 2019 16:37:07 +0100","Message-Id":"<20190503153707.8918-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] libcamera: v4l2_device: Increase error\n\tlevel for unsupported devices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 03 May 2019 15:37:11 -0000"},"content":"If a component tries to open an unsupported device type, no error is presented\nunless debug is enabled.\n\nReport an error if an unsupported device type is opened to ease pipeline\ndevelopment.\n\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/v4l2_device.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex e22323de19c3..8366ffc4db55 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -349,7 +349,7 @@ int V4L2Device::open()\n \t\tfdEvent_ = new EventNotifier(fd_, EventNotifier::Read);\n \t\tbufferType_ = V4L2_BUF_TYPE_META_CAPTURE;\n \t} else {\n-\t\tLOG(V4L2, Debug) << \"Device is not a supported type\";\n+\t\tLOG(V4L2, Error) << \"Device is not a supported type\";\n \t\treturn -EINVAL;\n \t}\n \n","prefixes":["libcamera-devel"]}