[{"id":15651,"web_url":"https://patchwork.libcamera.org/comment/15651/","msgid":"<20210313094117.jw5aw33ttdohz2y6@uno.localdomain>","date":"2021-03-13T09:41:17","subject":"Re: [libcamera-devel] [PATCH v2 8/8] libcamera: pipeline: ipu3:\n\tFail if the FrameInfo can't be found","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran\n\nOn Fri, Mar 12, 2021 at 05:47:27AM +0000, Kieran Bingham wrote:\n> The FrameInfo structure associates the data sent to the IPA\n> and is essential for handling events.\n>\n> If it can not be found, this is a fatal error which must be fixed.\n\nAs this is a pipeline development issue, Fatal seems appropriate to\nhave it fixed during development.\n\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nThanks\n  j\n\n>\n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> ---\n>  src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++--\n>  1 file changed, 6 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index c5facaea16dd..a61e2b51ef9e 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -1168,8 +1168,10 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n>  \t}\n>  \tcase ipa::ipu3::ActionParamFilled: {\n>  \t\tIPU3Frames::Info *info = frameInfos_.find(id);\n> -\t\tif (!info)\n> +\t\tif (!info) {\n> +\t\t\tLOG(IPU3, Fatal) << \"No frameInfo for ActionParamFilled on ID: \" << id;\n>  \t\t\tbreak;\n> +\t\t}\n>\n>  \t\t/* Queue all buffers from the request aimed for the ImgU. */\n>  \t\tfor (auto it : info->request->buffers()) {\n> @@ -1190,8 +1192,10 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n>  \t}\n>  \tcase ipa::ipu3::ActionMetadataReady: {\n>  \t\tIPU3Frames::Info *info = frameInfos_.find(id);\n> -\t\tif (!info)\n> +\t\tif (!info) {\n> +\t\t\tLOG(IPU3, Fatal) << \"No frameInfo for ActionMetadataReady on ID: \" << id;\n>  \t\t\tbreak;\n> +\t\t}\n>\n>  \t\t/*\n>  \t\t * \\todo Parse the value of the controls returned by the IPA\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A1514BD80C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 13 Mar 2021 09:40:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C47768C67;\n\tSat, 13 Mar 2021 10:40:47 +0100 (CET)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[217.70.183.201])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED7A4602E3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 13 Mar 2021 10:40:46 +0100 (CET)","from uno.localdomain (host-79-22-58-175.retail.telecomitalia.it\n\t[79.22.58.175]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 5182A1BF205;\n\tSat, 13 Mar 2021 09:40:46 +0000 (UTC)"],"X-Originating-IP":"79.22.58.175","Date":"Sat, 13 Mar 2021 10:41:17 +0100","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<20210313094117.jw5aw33ttdohz2y6@uno.localdomain>","References":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>\n\t<20210312054727.852622-9-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210312054727.852622-9-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 8/8] libcamera: pipeline: ipu3:\n\tFail if the FrameInfo can't be found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":15663,"web_url":"https://patchwork.libcamera.org/comment/15663/","msgid":"<YE1HFkkpwztlymf6@pendragon.ideasonboard.com>","date":"2021-03-13T23:13:26","subject":"Re: [libcamera-devel] [PATCH v2 8/8] libcamera: pipeline: ipu3:\n\tFail if the FrameInfo can't be found","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Mar 12, 2021 at 05:47:27AM +0000, Kieran Bingham wrote:\n> The FrameInfo structure associates the data sent to the IPA\n> and is essential for handling events.\n> \n> If it can not be found, this is a fatal error which must be fixed.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> ---\n>  src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++--\n>  1 file changed, 6 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index c5facaea16dd..a61e2b51ef9e 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -1168,8 +1168,10 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n>  \t}\n>  \tcase ipa::ipu3::ActionParamFilled: {\n>  \t\tIPU3Frames::Info *info = frameInfos_.find(id);\n> -\t\tif (!info)\n> +\t\tif (!info) {\n> +\t\t\tLOG(IPU3, Fatal) << \"No frameInfo for ActionParamFilled on ID: \" << id;\n\ns/ID:/ID/ ?\n\nLet's shorten lines a bit.\n\n\t\t\tLOG(IPU3, Fatal)\n\t\t\t\t<< \"No frameInfo for ActionParamFilled on ID \"\n\t\t\t\t<< id;\n\nSame below.\n\nThis being said, couldn't we more simply turn the existing Error message\nin IPU3Frames::find(unsigned int id) into a Fatal message ?\n\nI also wonder if the same shouldn't be done for\nIPU3Frames::find(FrameBuffer *buffer).\n\n>  \t\t\tbreak;\n> +\t\t}\n>  \n>  \t\t/* Queue all buffers from the request aimed for the ImgU. */\n>  \t\tfor (auto it : info->request->buffers()) {\n> @@ -1190,8 +1192,10 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n>  \t}\n>  \tcase ipa::ipu3::ActionMetadataReady: {\n>  \t\tIPU3Frames::Info *info = frameInfos_.find(id);\n> -\t\tif (!info)\n> +\t\tif (!info) {\n> +\t\t\tLOG(IPU3, Fatal) << \"No frameInfo for ActionMetadataReady on ID: \" << id;\n>  \t\t\tbreak;\n> +\t\t}\n>  \n>  \t\t/*\n>  \t\t * \\todo Parse the value of the controls returned by the IPA","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0D14BBD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 13 Mar 2021 23:14:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 735686084E;\n\tSun, 14 Mar 2021 00:14:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 860526084D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 14 Mar 2021 00:14:03 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E320F55C;\n\tSun, 14 Mar 2021 00:14:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cePBMCIQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615677243;\n\tbh=QSdOR6uCc1HQiaSHTS9Woh0y6Eziljq4LVNz/bsbggA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cePBMCIQfwN53jk4OXjHWP6+EzWWElBW0FcaFsDnJBlVU0tO6zndrNXhQJ9jdLEoe\n\t4vLgQ+Y9F+zP7NJYwIM08c8VV7gokUCV2rzjvoATDFbatabfIisawa/TnWuKJsUhyd\n\tNAS3Q9C4cyYLLZnNkE2I8i26QI+N/UcHnKmlQNBU=","Date":"Sun, 14 Mar 2021 01:13:26 +0200","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Message-ID":"<YE1HFkkpwztlymf6@pendragon.ideasonboard.com>","References":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>\n\t<20210312054727.852622-9-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210312054727.852622-9-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 8/8] libcamera: pipeline: ipu3:\n\tFail if the FrameInfo can't be found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":15863,"web_url":"https://patchwork.libcamera.org/comment/15863/","msgid":"<d165056c-219a-e36e-5643-a759a43c6b44@ideasonboard.com>","date":"2021-03-24T13:02:37","subject":"Re: [libcamera-devel] [PATCH v2 8/8] libcamera: pipeline: ipu3:\n\tFail if the FrameInfo can't be found","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 13/03/2021 23:13, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Fri, Mar 12, 2021 at 05:47:27AM +0000, Kieran Bingham wrote:\n>> The FrameInfo structure associates the data sent to the IPA\n>> and is essential for handling events.\n>>\n>> If it can not be found, this is a fatal error which must be fixed.\n>>\n>> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>> ---\n>>  src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++--\n>>  1 file changed, 6 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> index c5facaea16dd..a61e2b51ef9e 100644\n>> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> @@ -1168,8 +1168,10 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n>>  \t}\n>>  \tcase ipa::ipu3::ActionParamFilled: {\n>>  \t\tIPU3Frames::Info *info = frameInfos_.find(id);\n>> -\t\tif (!info)\n>> +\t\tif (!info) {\n>> +\t\t\tLOG(IPU3, Fatal) << \"No frameInfo for ActionParamFilled on ID: \" << id;\n> \n> s/ID:/ID/ ?\n> \n> Let's shorten lines a bit.\n> \n> \t\t\tLOG(IPU3, Fatal)\n> \t\t\t\t<< \"No frameInfo for ActionParamFilled on ID \"\n> \t\t\t\t<< id;\n> \n> Same below.\n> \n> This being said, couldn't we more simply turn the existing Error message\n> in IPU3Frames::find(unsigned int id) into a Fatal message ?\n\nI think I hadn't done that because I thought that there were legitimate\nreasons for not being able to find a FrameInfo for a buffer. But I don't\nbelieve there is.\n\nFrameInfo is not removed until the request is completed, so any failure\nto find it is fatal.\n\nHaving the internal structure associated with a Request::Private\ninternal pointer would therefore save lookups and be a (nearish) future\nimprovement.\n\nI'll make this fully fatal and retest everything.\n\n\n> I also wonder if the same shouldn't be done for\n> IPU3Frames::find(FrameBuffer *buffer).\n> \n>>  \t\t\tbreak;\n>> +\t\t}\n>>  \n>>  \t\t/* Queue all buffers from the request aimed for the ImgU. */\n>>  \t\tfor (auto it : info->request->buffers()) {\n>> @@ -1190,8 +1192,10 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n>>  \t}\n>>  \tcase ipa::ipu3::ActionMetadataReady: {\n>>  \t\tIPU3Frames::Info *info = frameInfos_.find(id);\n>> -\t\tif (!info)\n>> +\t\tif (!info) {\n>> +\t\t\tLOG(IPU3, Fatal) << \"No frameInfo for ActionMetadataReady on ID: \" << id;\n>>  \t\t\tbreak;\n>> +\t\t}\n>>  \n>>  \t\t/*\n>>  \t\t * \\todo Parse the value of the controls returned by the IPA\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D92C8C32E5\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 24 Mar 2021 13:02:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1F92D68D61;\n\tWed, 24 Mar 2021 14:02:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2671C602E3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 24 Mar 2021 14:02:40 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8FFD6580;\n\tWed, 24 Mar 2021 14:02:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"s+ipllL/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1616590959;\n\tbh=0GTw67XfcPF9XiuZJbp2rAeo/io7kIJQYf6IJTC67W8=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=s+ipllL/3uKdP373PkOFK7rze1CiFrZwvqbTmZNgEMMMpiBrbOAt+FBVyjEusVG9X\n\tkrAHC017yz84YvvetzL3B04sQdjUv+i+l6homLhgTGIJAtmxgtxj+AYQBw26P+/VxS\n\tChyUwhqXMqMUkE6jslEsVytLczXks9Fg29FkXyZY=","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","References":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>\n\t<20210312054727.852622-9-kieran.bingham@ideasonboard.com>\n\t<YE1HFkkpwztlymf6@pendragon.ideasonboard.com>","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<d165056c-219a-e36e-5643-a759a43c6b44@ideasonboard.com>","Date":"Wed, 24 Mar 2021 13:02:37 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<YE1HFkkpwztlymf6@pendragon.ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 8/8] libcamera: pipeline: ipu3:\n\tFail if the FrameInfo can't be found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]