{"id":11559,"url":"https://patchwork.libcamera.org/api/patches/11559/?format=json","web_url":"https://patchwork.libcamera.org/patch/11559/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210312054727.852622-9-kieran.bingham@ideasonboard.com>","date":"2021-03-12T05:47:27","name":"[libcamera-devel,v2,8/8] libcamera: pipeline: ipu3: Fail if the FrameInfo can't be found","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"723ec2307185fba691045055266d1c19767785f5","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11559/mbox/","series":[{"id":1785,"url":"https://patchwork.libcamera.org/api/series/1785/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1785","date":"2021-03-12T05:47:19","name":"IPU3 Stability","version":2,"mbox":"https://patchwork.libcamera.org/series/1785/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11559/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11559/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE80FBD1F1\n\tfor ;\n\tFri, 12 Mar 2021 05:47:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7209C68C6B;\n\tFri, 12 Mar 2021 06:47:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C2CD68C6A\n\tfor ;\n\tFri, 12 Mar 2021 06:47:34 +0100 (CET)","from localhost.localdomain\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CD6F88F9;\n\tFri, 12 Mar 2021 06:47:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JyDe18xw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615528054;\n\tbh=RKxT41wukt/83iJeLfzLWLhu6Ut9PVoijpveHju7Dwc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JyDe18xwAuO8Yhuz3nj+ZgCmIr/PVt/OLKh08QsDd9blnfdepp5hM3IJMbgGSRucx\n\tnlNOLvAS0J/0olQHYzSirgkUutnrucsezLvNoKjZpPH15XtgA9i9zDV1dymrZ25t4R\n\tczBhQvIhC/93o3UfLGsQD/prgYd6RRG8ru2l6aF0=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Fri, 12 Mar 2021 05:47:27 +0000","Message-Id":"<20210312054727.852622-9-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>","References":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 8/8] libcamera: pipeline: ipu3: Fail if\n\tthe FrameInfo can't be found","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The FrameInfo structure associates the data sent to the IPA\nand is essential for handling events.\n\nIf it can not be found, this is a fatal error which must be fixed.\n\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex c5facaea16dd..a61e2b51ef9e 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -1168,8 +1168,10 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n \t}\n \tcase ipa::ipu3::ActionParamFilled: {\n \t\tIPU3Frames::Info *info = frameInfos_.find(id);\n-\t\tif (!info)\n+\t\tif (!info) {\n+\t\t\tLOG(IPU3, Fatal) << \"No frameInfo for ActionParamFilled on ID: \" << id;\n \t\t\tbreak;\n+\t\t}\n \n \t\t/* Queue all buffers from the request aimed for the ImgU. */\n \t\tfor (auto it : info->request->buffers()) {\n@@ -1190,8 +1192,10 @@ void IPU3CameraData::queueFrameAction(unsigned int id,\n \t}\n \tcase ipa::ipu3::ActionMetadataReady: {\n \t\tIPU3Frames::Info *info = frameInfos_.find(id);\n-\t\tif (!info)\n+\t\tif (!info) {\n+\t\t\tLOG(IPU3, Fatal) << \"No frameInfo for ActionMetadataReady on ID: \" << id;\n \t\t\tbreak;\n+\t\t}\n \n \t\t/*\n \t\t * \\todo Parse the value of the controls returned by the IPA\n","prefixes":["libcamera-devel","v2","8/8"]}