[{"id":15649,"web_url":"https://patchwork.libcamera.org/comment/15649/","msgid":"<20210313093727.yzk2l5zrogyj4gul@uno.localdomain>","date":"2021-03-13T09:37:27","subject":"Re: [libcamera-devel] [PATCH v2 6/8] libcamera: pipeline: ipu3:\n\tStop IPA before stopping devices","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Fri, Mar 12, 2021 at 05:47:25AM +0000, Kieran Bingham wrote:\n> The IPA should be stopped before the hardware devices to ensure that\n> all asynchronous actions have completed within the IPA before resources\n> are removed and released.\n>\n> Signed-off-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 00da2bb26e41..7ab3a5bfdccb 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -764,13 +764,13 @@ void PipelineHandlerIPU3::stop(Camera *camera)\n> \tIPU3CameraData *data = cameraData(camera);\n> \tint ret = 0;\n>\n> +\tdata->ipa_->stop();\n> +\n> \tret |= data->imgu_->stop();\n> \tret |= data->cio2_.stop();\n> \tif (ret)\n> \t\tLOG(IPU3, Warning) << \"Failed to stop camera \" << camera->id();\n>\n> -\tdata->ipa_->stop();\n> -\n> \tfreeBuffers(camera);\n> }\n>\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EE3ABBD1F1\n\tfor ;\n\tSat, 13 Mar 2021 09:36:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ACE3068C67;\n\tSat, 13 Mar 2021 10:36:58 +0100 (CET)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B5DB7602E3\n\tfor ;\n\tSat, 13 Mar 2021 10:36:56 +0100 (CET)","from uno.localdomain (host-79-22-58-175.retail.telecomitalia.it\n\t[79.22.58.175]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 1B9A9200005;\n\tSat, 13 Mar 2021 09:36:55 +0000 (UTC)"],"Date":"Sat, 13 Mar 2021 10:37:27 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20210313093727.yzk2l5zrogyj4gul@uno.localdomain>","References":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>\n\t<20210312054727.852622-7-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210312054727.852622-7-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 6/8] libcamera: pipeline: ipu3:\n\tStop IPA before stopping devices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]