{"id":11557,"url":"https://patchwork.libcamera.org/api/patches/11557/?format=json","web_url":"https://patchwork.libcamera.org/patch/11557/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210312054727.852622-7-kieran.bingham@ideasonboard.com>","date":"2021-03-12T05:47:25","name":"[libcamera-devel,v2,6/8] libcamera: pipeline: ipu3: Stop IPA before stopping devices","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"de0b807588a0af473eadbe7d0093ec202f611997","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11557/mbox/","series":[{"id":1785,"url":"https://patchwork.libcamera.org/api/series/1785/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1785","date":"2021-03-12T05:47:19","name":"IPU3 Stability","version":2,"mbox":"https://patchwork.libcamera.org/series/1785/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11557/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11557/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C6844BD1F1\n\tfor ;\n\tFri, 12 Mar 2021 05:47:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7F6F768C74;\n\tFri, 12 Mar 2021 06:47:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E1EF68C6B\n\tfor ;\n\tFri, 12 Mar 2021 06:47:33 +0100 (CET)","from localhost.localdomain\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2F241ACB;\n\tFri, 12 Mar 2021 06:47:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Xdszhroe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615528053;\n\tbh=s79U5rdG5uSSK+LypEViC6Dv5AOaNWqEelXOaCCyHT8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XdszhroeAur5nQrZpp7m2fonNnRPrVLBp6t0ySG8L4SDIb3fIh/kBHLsJ9BoukqZL\n\tbzNAtUCFSU4SY5bACneS4brFDnrweLFvJsCh7yD3O9bx+/8HXfyGai5HcdPePSrGcr\n\t3CaBrR4uNEYgoGVyoPQoqwrYysRM+i8rnmsjUUwE=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Fri, 12 Mar 2021 05:47:25 +0000","Message-Id":"<20210312054727.852622-7-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>","References":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 6/8] libcamera: pipeline: ipu3: Stop\n\tIPA before stopping devices","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The IPA should be stopped before the hardware devices to ensure that\nall asynchronous actions have completed within the IPA before resources\nare removed and released.\n\nSigned-off-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 00da2bb26e41..7ab3a5bfdccb 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -764,13 +764,13 @@ void PipelineHandlerIPU3::stop(Camera *camera)\n \tIPU3CameraData *data = cameraData(camera);\n \tint ret = 0;\n \n+\tdata->ipa_->stop();\n+\n \tret |= data->imgu_->stop();\n \tret |= data->cio2_.stop();\n \tif (ret)\n \t\tLOG(IPU3, Warning) << \"Failed to stop camera \" << camera->id();\n \n-\tdata->ipa_->stop();\n-\n \tfreeBuffers(camera);\n }\n \n","prefixes":["libcamera-devel","v2","6/8"]}