[{"id":15609,"web_url":"https://patchwork.libcamera.org/comment/15609/","msgid":"<46d37fca-4ac2-3ef6-6325-ec5a049d3f8c@ideasonboard.com>","date":"2021-03-12T05:54:12","subject":"Re: [libcamera-devel] [PATCH v2 5/8] libcamera: v4l2_videodevice:\n\tPrevent queueing buffers without a cache","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 12/03/2021 05:47, Kieran Bingham wrote:\n> The v4l2 buffer cache allows us to map incoming buffers to an instance\n> of the V4L2 Buffer required to actually queue.\n> \n> If the cache_ is not available, then the buffers required to allow\n> queuing to a device have been released, and this indicates an issue at\n> the pipeline handler.\n> \n> This could be a common mistake, as it could happen if a pipeline handler\n> always requeues buffers to the device after they complete, without\n> checking if they are cancelled.\n> \n> That can then lead to trying to queue a buffer to a device which no\n> longer expects buffers, so add a loud message to indicate what has\n> happened but return an error without fatally crashing.\n\nPerhaps you forgot to update this commit message.\n\nI'd recommend change the last paragraph to the following when/if committing:\n\nCatch any invalid queueing of buffers to the V4L2 video device when\nresources have been released by adding a Fatal log message to highlight\nthe error during development.\n\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> src/libcamera/v4l2_videodevice.cpp | 10 ++++++++++\n> 1 file changed, 10 insertions(+)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index cb52d4cea3f6..12c09dc7578d 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -1391,6 +1391,16 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> \tstruct v4l2_buffer buf = {};\n> \tint ret;\n> \n> +\t/*\n> +\t * Pipeline handlers should not requeue buffers after releasing the\n> +\t * buffers on the device. Any occurence of this error should be fixed\n> +\t * in the pipeline handler directly.\n> +\t */\n> +\tif (!cache_) {\n> +\t\tLOG(V4L2, Fatal) << \"No BufferCache available to queue.\";\n> +\t\treturn -ENOENT;\n> +\t}\n> +\n> \tret = cache_->get(*buffer);\n> \tif (ret < 0)\n> \t\treturn ret;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F1B2BD80C\n\tfor ;\n\tFri, 12 Mar 2021 05:54:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8EFF068C6A;\n\tFri, 12 Mar 2021 06:54:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 46637605B2\n\tfor ;\n\tFri, 12 Mar 2021 06:54:16 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A21EE88F;\n\tFri, 12 Mar 2021 06:54:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hZ6PK+sc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615528455;\n\tbh=IE5AIVjqHroUdLtm3z0t7H9+fdr8iUXfqjR/jfAc0Cg=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=hZ6PK+scB0pYu+bAOpsatvBNtoH/+5HDGGGpNCbITkYTsB289QDMY4GOMG+jDKwoY\n\tHNjW+PUk4Pp6wX6zU/7Wjsdy6dg+zCK7nq/H/uXyemM0w+D8qLrpFcyTiAwELiqiJH\n\tEOevUp0NJgWVa78ZJtNOdUEYE+0Pat9n+Bo0tYhQ=","To":"Kieran Bingham ,\n\tLibCamera Devel ","References":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>\n\t<20210312054727.852622-6-kieran.bingham@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<46d37fca-4ac2-3ef6-6325-ec5a049d3f8c@ideasonboard.com>","Date":"Fri, 12 Mar 2021 05:54:12 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210312054727.852622-6-kieran.bingham@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 5/8] libcamera: v4l2_videodevice:\n\tPrevent queueing buffers without a cache","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15648,"web_url":"https://patchwork.libcamera.org/comment/15648/","msgid":"<20210313093659.jargisfaprw7thba@uno.localdomain>","date":"2021-03-13T09:36:59","subject":"Re: [libcamera-devel] [PATCH v2 5/8] libcamera: v4l2_videodevice:\n\tPrevent queueing buffers without a cache","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Fri, Mar 12, 2021 at 05:54:12AM +0000, Kieran Bingham wrote:\n> Hi Kieran,\n>\n> On 12/03/2021 05:47, Kieran Bingham wrote:\n> > The v4l2 buffer cache allows us to map incoming buffers to an instance\n> > of the V4L2 Buffer required to actually queue.\n> >\n> > If the cache_ is not available, then the buffers required to allow\n> > queuing to a device have been released, and this indicates an issue at\n> > the pipeline handler.\n> >\n> > This could be a common mistake, as it could happen if a pipeline handler\n> > always requeues buffers to the device after they complete, without\n> > checking if they are cancelled.\n> >\n> > That can then lead to trying to queue a buffer to a device which no\n> > longer expects buffers, so add a loud message to indicate what has\n> > happened but return an error without fatally crashing.\n>\n> Perhaps you forgot to update this commit message.\n>\n> I'd recommend change the last paragraph to the following when/if committing:\n>\n> Catch any invalid queueing of buffers to the V4L2 video device when\n> resources have been released by adding a Fatal log message to highlight\n> the error during development.\n>\n\nWith the commit message updated, and Niklas' concern about other\npipelines not triggering this verified\nReviewed-by: Jacopo Mondi \n\n> >\n> > Signed-off-by: Kieran Bingham \n> > ---\n> > src/libcamera/v4l2_videodevice.cpp | 10 ++++++++++\n> > 1 file changed, 10 insertions(+)\n> >\n> > diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> > index cb52d4cea3f6..12c09dc7578d 100644\n> > --- a/src/libcamera/v4l2_videodevice.cpp\n> > +++ b/src/libcamera/v4l2_videodevice.cpp\n> > @@ -1391,6 +1391,16 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> > \tstruct v4l2_buffer buf = {};\n> > \tint ret;\n> >\n> > +\t/*\n> > +\t * Pipeline handlers should not requeue buffers after releasing the\n> > +\t * buffers on the device. Any occurence of this error should be fixed\n> > +\t * in the pipeline handler directly.\n> > +\t */\n> > +\tif (!cache_) {\n> > +\t\tLOG(V4L2, Fatal) << \"No BufferCache available to queue.\";\n> > +\t\treturn -ENOENT;\n> > +\t}\n> > +\n> > \tret = cache_->get(*buffer);\n> > \tif (ret < 0)\n> > \t\treturn ret;\n> >\n>\n> --\n> Regards\n> --\n> Kieran\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5EF47BD1F1\n\tfor ;\n\tSat, 13 Mar 2021 09:36:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2428368C69;\n\tSat, 13 Mar 2021 10:36:30 +0100 (CET)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40874602E3\n\tfor ;\n\tSat, 13 Mar 2021 10:36:29 +0100 (CET)","from uno.localdomain (host-79-22-58-175.retail.telecomitalia.it\n\t[79.22.58.175]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 9DA1F1C0008;\n\tSat, 13 Mar 2021 09:36:28 +0000 (UTC)"],"X-Originating-IP":"79.22.58.175","Date":"Sat, 13 Mar 2021 10:36:59 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20210313093659.jargisfaprw7thba@uno.localdomain>","References":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>\n\t<20210312054727.852622-6-kieran.bingham@ideasonboard.com>\n\t<46d37fca-4ac2-3ef6-6325-ec5a049d3f8c@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<46d37fca-4ac2-3ef6-6325-ec5a049d3f8c@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 5/8] libcamera: v4l2_videodevice:\n\tPrevent queueing buffers without a cache","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"LibCamera Devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15661,"web_url":"https://patchwork.libcamera.org/comment/15661/","msgid":"","date":"2021-03-13T23:02:22","subject":"Re: [libcamera-devel] [PATCH v2 5/8] libcamera: v4l2_videodevice:\n\tPrevent queueing buffers without a cache","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Mar 12, 2021 at 05:54:12AM +0000, Kieran Bingham wrote:\n> On 12/03/2021 05:47, Kieran Bingham wrote:\n> > The v4l2 buffer cache allows us to map incoming buffers to an instance\n\ns/v4l2/V4L2/ ?\n\n> > of the V4L2 Buffer required to actually queue.\n\ns/Buffer/buffer/ as there's no V4L2Buffer class ?\n\n> > If the cache_ is not available, then the buffers required to allow\n> > queuing to a device have been released, and this indicates an issue at\n> > the pipeline handler.\n> > \n> > This could be a common mistake, as it could happen if a pipeline handler\n> > always requeues buffers to the device after they complete, without\n> > checking if they are cancelled.\n> > \n> > That can then lead to trying to queue a buffer to a device which no\n> > longer expects buffers, so add a loud message to indicate what has\n> > happened but return an error without fatally crashing.\n> \n> Perhaps you forgot to update this commit message.\n> \n> I'd recommend change the last paragraph to the following when/if committing:\n> \n> Catch any invalid queueing of buffers to the V4L2 video device when\n> resources have been released by adding a Fatal log message to highlight\n> the error during development.\n> \n> > Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> > ---\n> > src/libcamera/v4l2_videodevice.cpp | 10 ++++++++++\n> > 1 file changed, 10 insertions(+)\n> > \n> > diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> > index cb52d4cea3f6..12c09dc7578d 100644\n> > --- a/src/libcamera/v4l2_videodevice.cpp\n> > +++ b/src/libcamera/v4l2_videodevice.cpp\n> > @@ -1391,6 +1391,16 @@ int V4L2VideoDevice::queueBuffer(FrameBuffer *buffer)\n> > \tstruct v4l2_buffer buf = {};\n> > \tint ret;\n> > \n> > +\t/*\n> > +\t * Pipeline handlers should not requeue buffers after releasing the\n> > +\t * buffers on the device. Any occurence of this error should be fixed\n> > +\t * in the pipeline handler directly.\n> > +\t */\n> > +\tif (!cache_) {\n> > +\t\tLOG(V4L2, Fatal) << \"No BufferCache available to queue.\";\n> > +\t\treturn -ENOENT;\n> > +\t}\n> > +\n> > \tret = cache_->get(*buffer);\n> > \tif (ret < 0)\n> > \t\treturn ret;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95D82BD80C\n\tfor ;\n\tSat, 13 Mar 2021 23:03:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9FD9460850;\n\tSun, 14 Mar 2021 00:03:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 571626084D\n\tfor ;\n\tSun, 14 Mar 2021 00:02:59 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C422A55C;\n\tSun, 14 Mar 2021 00:02:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"I1B9836r\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615676578;\n\tbh=pZZ5i7SOgPMeOrabAp7gmnJM8txKUpU4OuPkCTIAQW0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=I1B9836rTOZhhA9Uuj31vl81mal5gwiG51cZyhE1mtwAHOwcDLyViLZ4vjMc4P6+u\n\tZ4yx7n8GaxSWHUg3rfFE5mAwUna/yPpwPhou/Eu6lRMfBVKY67kV60PZNeluJoOQyw\n\tw04ZPv9WN29OE8tDgk7eLAVpTNcWcRs32kWMmzv8=","Date":"Sun, 14 Mar 2021 01:02:22 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>\n\t<20210312054727.852622-6-kieran.bingham@ideasonboard.com>\n\t<46d37fca-4ac2-3ef6-6325-ec5a049d3f8c@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<46d37fca-4ac2-3ef6-6325-ec5a049d3f8c@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 5/8] libcamera: v4l2_videodevice:\n\tPrevent queueing buffers without a cache","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"LibCamera Devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]