{"id":11555,"url":"https://patchwork.libcamera.org/api/patches/11555/?format=json","web_url":"https://patchwork.libcamera.org/patch/11555/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210312054727.852622-5-kieran.bingham@ideasonboard.com>","date":"2021-03-12T05:47:23","name":"[libcamera-devel,v2,4/8] libcamera: camera: Validate requests are completed in Running state","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"f319a03be2753bd361f36a87e36b770aad806ebf","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11555/mbox/","series":[{"id":1785,"url":"https://patchwork.libcamera.org/api/series/1785/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1785","date":"2021-03-12T05:47:19","name":"IPU3 Stability","version":2,"mbox":"https://patchwork.libcamera.org/series/1785/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11555/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11555/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8494BD1F1\n\tfor ;\n\tFri, 12 Mar 2021 05:47:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 72FDE68C6A;\n\tFri, 12 Mar 2021 06:47:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D30A68C6E\n\tfor ;\n\tFri, 12 Mar 2021 06:47:33 +0100 (CET)","from localhost.localdomain\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A10BA2A;\n\tFri, 12 Mar 2021 06:47:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Yff1ksrb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615528052;\n\tbh=8lnDfH/NO4/Q9HX64lxchoVP23qzoB/7ihqg0whiYUg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Yff1ksrbbGMJut2dSrSEdNyE55E0pIv8Dp/yWhCscurwH7JaByW0qs+fdus7voSAe\n\tJ6AiX3r4ymfT7ZMBe0WyMFGTRcciiYxODhuNysxCormqq6Q81Bx182+qfn8i84MdD4\n\tA0h3XJdQptJl3jqsom7rZh7aOoYNwfF4Akb2qzDc=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Fri, 12 Mar 2021 05:47:23 +0000","Message-Id":"<20210312054727.852622-5-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>","References":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 4/8] libcamera: camera: Validate\n\trequests are completed in Running state","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"All requests must have completed before the Camera has fully stopped.\n\nRequests completing when the camera is not running represent an internal\npipeline handler bug.\n\nTrap this event with a fatal error.\n\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/camera.cpp | 10 ++++++++--\n 1 file changed, 8 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 84edbb8f494d..19fb9eb415b0 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -1062,11 +1062,11 @@ int Camera::stop()\n \n \tLOG(Camera, Debug) << \"Stopping capture\";\n \n-\td->setState(Private::CameraConfigured);\n-\n \td->pipe_->invokeMethod(&PipelineHandler::stop, ConnectionTypeBlocking,\n \t\t\t this);\n \n+\td->setState(Private::CameraConfigured);\n+\n \treturn 0;\n }\n \n@@ -1079,6 +1079,12 @@ int Camera::stop()\n */\n void Camera::requestComplete(Request *request)\n {\n+\tPrivate *const d = LIBCAMERA_D_PTR();\n+\n+\tint ret = d->isAccessAllowed(Private::CameraRunning);\n+\tif (ret < 0)\n+\t\tLOG(Camera, Fatal) << \"Trying to complete a request when Stopped\";\n+\n \trequestCompleted.emit(request);\n }\n \n","prefixes":["libcamera-devel","v2","4/8"]}