[{"id":15634,"web_url":"https://patchwork.libcamera.org/comment/15634/","msgid":"","date":"2021-03-12T23:12:05","subject":"Re: [libcamera-devel] [PATCH v2 1/8] utils: ipc: proxy: Assert\n\tasynchronous calls execute in the running state","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran and Laurent,\n\nOn 2021-03-12 05:47:20 +0000, Kieran Bingham wrote:\n> From: Laurent Pinchart \n> \n> Signals and calls from the IPA should not occur after the IPA has been\n> put into the stopped state.\n> \n> Add assertions to catch and prevent any messages being processed after\n> this.\n> \n> Signed-off-by: Laurent Pinchart \n> Signed-off-by: Kieran Bingham \n\nI think this makes sens.\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 2 ++\n> utils/ipc/generators/libcamera_templates/proxy_functions.tmpl | 4 ++--\n> 2 files changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> index f75b1206cad4..e3b541db4e36 100644\n> --- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> +++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> @@ -173,6 +173,7 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n> \t{%- endfor -%}\n> );\n> {% elif method|is_async %}\n> +\tASSERT(running_);\n> \tproxy_.invokeMethod(&ThreadProxy::{{method.mojom_name}}, ConnectionTypeQueued,\n> \t{%- for param in method|method_param_names -%}\n> \t\t{{param}}{{- \", \" if not loop.last}}\n> @@ -225,6 +226,7 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n> {% for method in interface_event.methods %}\n> {{proxy_funcs.func_sig(proxy_name, method, \"Thread\")}}\n> {\n> +\tASSERT(running_);\n> \t{{method.mojom_name}}.emit({{method.parameters|params_comma_sep}});\n> }\n> \n> diff --git a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> index c2ac42fca45b..13dc8fdcab6e 100644\n> --- a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> +++ b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> @@ -26,12 +26,12 @@\n> \tif (!running_)\n> \t\treturn;\n> \n> -\trunning_ = false;\n> -\n> \tproxy_.invokeMethod(&ThreadProxy::stop, ConnectionTypeBlocking);\n> \n> \tthread_.exit();\n> \tthread_.wait();\n> +\n> +\trunning_ = false;\n> {%- endmacro -%}\n> \n> \n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D500BD1F1\n\tfor ;\n\tFri, 12 Mar 2021 23:12:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC72368C68;\n\tSat, 13 Mar 2021 00:12:11 +0100 (CET)","from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n\t[IPv6:2a00:1450:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13E14602E8\n\tfor ;\n\tSat, 13 Mar 2021 00:12:08 +0100 (CET)","by mail-wr1-x433.google.com with SMTP id 7so5674151wrz.0\n\tfor ;\n\tFri, 12 Mar 2021 15:12:08 -0800 (PST)","from localhost (p54ac5521.dip0.t-ipconnect.de. [84.172.85.33])\n\tby smtp.gmail.com with ESMTPSA id\n\tn23sm10058433wra.71.2021.03.12.15.12.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 12 Mar 2021 15:12:08 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"YCC//145\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=cQtlFfxYGozE1afVzQXbI/lHi2+3KLalkVpDtx0WGo8=;\n\tb=YCC//145th4ZJKmdugwqLxVSpyTptIRaBRB5WeVAyAk6pRKNqslJb1kLT3UT1P/oNs\n\tk6lP2g3fUVr2q95bQzzKEv1APxVPOGleYUSOiMLQxQ8lfwhj4SmRsGEwvrHtFM7vrAh+\n\taMGxBk2v37PVk2+ZFSZyVcn94DNDhYbOjWOlifi3gslc1WUnclOEKBV6DPglzlCOIU8I\n\t+A7UHEUG374aNt/kwdym4Pn8PFiq31EvBga5caHFSpfUsgzJWac8SJ58Le9DJhYl1zYk\n\tXELPpCiQ0VxjCV+RlDC/6gkROPyvHPebujM/kySmcmR6K6RL9FsuGWaNKGD2wAMGgAW0\n\tJHrw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=cQtlFfxYGozE1afVzQXbI/lHi2+3KLalkVpDtx0WGo8=;\n\tb=Ae8Lj/BH/y/lKezKklzNfIMXOF5lR0ghlNd1+ul8dwul0l34caDh1ArDqwvGj2+Myx\n\taEroW80vs9a56pAsYXJbzGa1me9qrlZRNAiknkqh4iP4cPqc8Y2KMkUdXYObXJe4PmTN\n\t1eg339e9Ree9+axy2/pOfvZbh0oS+rv1WghWqYvIIjLqISDU+8O7K7bCyl2y7PdesnvJ\n\tEBDaffaHyh2evTMFeFyvhf4tld+sSRkdfMegzmftoRHrEpvJeRWjnj1V+tdm99D00zl7\n\thukbquMtBGRlR4fuE6LOGrZzZDtsUah171kB4GwwKHp8iszs91jJCEi0YfQXenBSfZqV\n\txmPQ==","X-Gm-Message-State":"AOAM533trR9PSp3pH5Y9aOBZtXubkbBWqNdH/AyvOb27qKoYeuEupyhu\n\tGQthZRXRZIbhP1LRijdHtroOyA==","X-Google-Smtp-Source":"ABdhPJy0CPwzkhshnFk/TPwICQ5HvnLZgzifAK8G99xYNA5QZQjCZpUgx8XIYeLnP+gTFx2xilFM2A==","X-Received":"by 2002:a05:6000:4b:: with SMTP id\n\tk11mr16219763wrx.35.1615590728614; \n\tFri, 12 Mar 2021 15:12:08 -0800 (PST)","Date":"Sat, 13 Mar 2021 00:12:05 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Message-ID":"","References":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>\n\t<20210312054727.852622-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210312054727.852622-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/8] utils: ipc: proxy: Assert\n\tasynchronous calls execute in the running state","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15644,"web_url":"https://patchwork.libcamera.org/comment/15644/","msgid":"<20210313092659.uvkzbvapua24zgy3@uno.localdomain>","date":"2021-03-13T09:26:59","subject":"Re: [libcamera-devel] [PATCH v2 1/8] utils: ipc: proxy: Assert\n\tasynchronous calls execute in the running state","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran\n\nOn Fri, Mar 12, 2021 at 05:47:20AM +0000, Kieran Bingham wrote:\n> From: Laurent Pinchart \n>\n> Signals and calls from the IPA should not occur after the IPA has been\n> put into the stopped state.\n>\n> Add assertions to catch and prevent any messages being processed after\n> this.\n>\n> Signed-off-by: Laurent Pinchart \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 2 ++\n> utils/ipc/generators/libcamera_templates/proxy_functions.tmpl | 4 ++--\n> 2 files changed, 4 insertions(+), 2 deletions(-)\n>\n> diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> index f75b1206cad4..e3b541db4e36 100644\n> --- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> +++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> @@ -173,6 +173,7 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n> \t{%- endfor -%}\n> );\n> {% elif method|is_async %}\n> +\tASSERT(running_);\n> \tproxy_.invokeMethod(&ThreadProxy::{{method.mojom_name}}, ConnectionTypeQueued,\n> \t{%- for param in method|method_param_names -%}\n> \t\t{{param}}{{- \", \" if not loop.last}}\n> @@ -225,6 +226,7 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n> {% for method in interface_event.methods %}\n> {{proxy_funcs.func_sig(proxy_name, method, \"Thread\")}}\n> {\n> +\tASSERT(running_);\n> \t{{method.mojom_name}}.emit({{method.parameters|params_comma_sep}});\n> }\n>\n> diff --git a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> index c2ac42fca45b..13dc8fdcab6e 100644\n> --- a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> +++ b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> @@ -26,12 +26,12 @@\n> \tif (!running_)\n> \t\treturn;\n>\n> -\trunning_ = false;\n> -\n> \tproxy_.invokeMethod(&ThreadProxy::stop, ConnectionTypeBlocking);\n>\n> \tthread_.exit();\n> \tthread_.wait();\n> +\n> +\trunning_ = false;\n> {%- endmacro -%}\n>\n>\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 98040BD1F1\n\tfor ;\n\tSat, 13 Mar 2021 09:26:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2676668C67;\n\tSat, 13 Mar 2021 10:26:30 +0100 (CET)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7BA76602E3\n\tfor ;\n\tSat, 13 Mar 2021 10:26:29 +0100 (CET)","from uno.localdomain (host-79-22-58-175.retail.telecomitalia.it\n\t[79.22.58.175]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id ACDC91C0009;\n\tSat, 13 Mar 2021 09:26:28 +0000 (UTC)"],"X-Originating-IP":"79.22.58.175","Date":"Sat, 13 Mar 2021 10:26:59 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20210313092659.uvkzbvapua24zgy3@uno.localdomain>","References":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>\n\t<20210312054727.852622-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210312054727.852622-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/8] utils: ipc: proxy: Assert\n\tasynchronous calls execute in the running state","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15657,"web_url":"https://patchwork.libcamera.org/comment/15657/","msgid":"","date":"2021-03-13T21:36:55","subject":"Re: [libcamera-devel] [PATCH v2 1/8] utils: ipc: proxy: Assert\n\tasynchronous calls execute in the running state","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Fri, Mar 12, 2021 at 05:47:20AM +0000, Kieran Bingham wrote:\n> From: Laurent Pinchart \n> \n> Signals and calls from the IPA should not occur after the IPA has been\n> put into the stopped state.\n> \n> Add assertions to catch and prevent any messages being processed after\n> this.\n> \n> Signed-off-by: Laurent Pinchart \n> Signed-off-by: Kieran Bingham \n> ---\n> .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 2 ++\n> utils/ipc/generators/libcamera_templates/proxy_functions.tmpl | 4 ++--\n> 2 files changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> index f75b1206cad4..e3b541db4e36 100644\n> --- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> +++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> @@ -173,6 +173,7 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n> \t{%- endfor -%}\n> );\n> {% elif method|is_async %}\n> +\tASSERT(running_);\n\nThis will fail to catch pipeline handlers calling into an IPA that is\nstopping, from the event handlers called by the dispatchMessages() call\nin 2/8. I think we need to turn running_ into a state_ variable, with\nthree states (Running, Stopping, Stopped) and ASSERT(state_ == Running)\nhere.\n\n> \tproxy_.invokeMethod(&ThreadProxy::{{method.mojom_name}}, ConnectionTypeQueued,\n> \t{%- for param in method|method_param_names -%}\n> \t\t{{param}}{{- \", \" if not loop.last}}\n> @@ -225,6 +226,7 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n> {% for method in interface_event.methods %}\n> {{proxy_funcs.func_sig(proxy_name, method, \"Thread\")}}\n> {\n> +\tASSERT(running_);\n\nHere we would ASSERT(state_ != Stopped).\n\n> \t{{method.mojom_name}}.emit({{method.parameters|params_comma_sep}});\n> }\n> \n> diff --git a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> index c2ac42fca45b..13dc8fdcab6e 100644\n> --- a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> +++ b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> @@ -26,12 +26,12 @@\n> \tif (!running_)\n> \t\treturn;\n> \n> -\trunning_ = false;\n> -\n\n\tstate_ = Stopping;\n\n> \tproxy_.invokeMethod(&ThreadProxy::stop, ConnectionTypeBlocking);\n> \n> \tthread_.exit();\n> \tthread_.wait();\n> +\n> +\trunning_ = false;\n\n\tstate_ = Stopped;\n\nThis could go on top of this series, as this patch is already an\nimprovement on its own.\n\n> {%- endmacro -%}\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A9EFBBD1F1\n\tfor ;\n\tSat, 13 Mar 2021 21:37:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EDB2F6084F;\n\tSat, 13 Mar 2021 22:37:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B664605B2\n\tfor ;\n\tSat, 13 Mar 2021 22:37:30 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E0C5C3F0;\n\tSat, 13 Mar 2021 22:37:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"L7DC8R6Q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615671450;\n\tbh=IxUoO1A2LEEdg8WWO/NG7IBv8kSnWys1uvWqcuASYKc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=L7DC8R6Q5oerhpwaxju6SZdJoG3nwwM5aAfR3dGZLeP+Qf0C4Vd8WUoBb0oqC3Yvw\n\tDVYxzUFBu4Vscq6WAJOC0v6TdZzBVBUUu5ulZQVcsfvMcemIoLVL5OWc8i3CqTYIee\n\tKUbsXhbkKF5YHS5N5Vwwu19NAh64rFt4VknyUrqo=","Date":"Sat, 13 Mar 2021 23:36:55 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>\n\t<20210312054727.852622-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210312054727.852622-2-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/8] utils: ipc: proxy: Assert\n\tasynchronous calls execute in the running state","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15700,"web_url":"https://patchwork.libcamera.org/comment/15700/","msgid":"","date":"2021-03-15T12:38:05","subject":"Re: [libcamera-devel] [PATCH v2 1/8] utils: ipc: proxy: Assert\n\tasynchronous calls execute in the running state","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 13/03/2021 21:36, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> Thank you for the patch.\n> \n> On Fri, Mar 12, 2021 at 05:47:20AM +0000, Kieran Bingham wrote:\n>> From: Laurent Pinchart \n>>\n>> Signals and calls from the IPA should not occur after the IPA has been\n>> put into the stopped state.\n>>\n>> Add assertions to catch and prevent any messages being processed after\n>> this.\n>>\n>> Signed-off-by: Laurent Pinchart \n>> Signed-off-by: Kieran Bingham \n>> ---\n>> .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 2 ++\n>> utils/ipc/generators/libcamera_templates/proxy_functions.tmpl | 4 ++--\n>> 2 files changed, 4 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n>> index f75b1206cad4..e3b541db4e36 100644\n>> --- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n>> +++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n>> @@ -173,6 +173,7 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n>> \t{%- endfor -%}\n>> );\n>> {% elif method|is_async %}\n>> +\tASSERT(running_);\n> \n> This will fail to catch pipeline handlers calling into an IPA that is\n> stopping, from the event handlers called by the dispatchMessages() call\n> in 2/8. I think we need to turn running_ into a state_ variable, with\n> three states (Running, Stopping, Stopped) and ASSERT(state_ == Running)\n> here.\n> \n>> \tproxy_.invokeMethod(&ThreadProxy::{{method.mojom_name}}, ConnectionTypeQueued,\n>> \t{%- for param in method|method_param_names -%}\n>> \t\t{{param}}{{- \", \" if not loop.last}}\n>> @@ -225,6 +226,7 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n>> {% for method in interface_event.methods %}\n>> {{proxy_funcs.func_sig(proxy_name, method, \"Thread\")}}\n>> {\n>> +\tASSERT(running_);\n> \n> Here we would ASSERT(state_ != Stopped).\n> \n>> \t{{method.mojom_name}}.emit({{method.parameters|params_comma_sep}});\n>> }\n>> \n>> diff --git a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n>> index c2ac42fca45b..13dc8fdcab6e 100644\n>> --- a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n>> +++ b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n>> @@ -26,12 +26,12 @@\n>> \tif (!running_)\n>> \t\treturn;\n>> \n>> -\trunning_ = false;\n>> -\n> \n> \tstate_ = Stopping;\n> \n>> \tproxy_.invokeMethod(&ThreadProxy::stop, ConnectionTypeBlocking);\n>> \n>> \tthread_.exit();\n>> \tthread_.wait();\n>> +\n>> +\trunning_ = false;\n> \n> \tstate_ = Stopped;\n> \n> This could go on top of this series, as this patch is already an\n> improvement on its own.\n> \n\nYes, I think this is a worthwhile exercise, I'd prefer on top at the minute.\n\n\n\n>> {%- endmacro -%}\n>> \n>> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 527F3BD80C\n\tfor ;\n\tMon, 15 Mar 2021 12:38:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F313868D40;\n\tMon, 15 Mar 2021 13:38:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68E6660106\n\tfor ;\n\tMon, 15 Mar 2021 13:38:08 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 151B0556;\n\tMon, 15 Mar 2021 13:38:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"meyDj+z6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615811888;\n\tbh=i1W6i9f/NwPrk9GtUYtrDglmrn6ayQRPVgIIl9/64fU=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=meyDj+z6wyb0ylp6W/UtehQFudkV/PU8zA8aelWQ+RzYivntHScPQpk357XNrTTMo\n\tgzXMq+nihkZzLrTvw2j1dlXLxpUeHjqtzWTgKoNap35KSbUugUGINuoRGx4JQ1Z2bb\n\t5+eOP8ZE2+LojKIy/DNrDVx1yD6KEZ4k6HCj1ynM=","To":"Laurent Pinchart ","References":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>\n\t<20210312054727.852622-2-kieran.bingham@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 15 Mar 2021 12:38:05 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 1/8] utils: ipc: proxy: Assert\n\tasynchronous calls execute in the running state","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15710,"web_url":"https://patchwork.libcamera.org/comment/15710/","msgid":"","date":"2021-03-15T23:17:55","subject":"Re: [libcamera-devel] [PATCH v2 1/8] utils: ipc: proxy: Assert\n\tasynchronous calls execute in the running state","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Mar 15, 2021 at 12:38:05PM +0000, Kieran Bingham wrote:\n> On 13/03/2021 21:36, Laurent Pinchart wrote:\n> > On Fri, Mar 12, 2021 at 05:47:20AM +0000, Kieran Bingham wrote:\n> >> From: Laurent Pinchart \n> >>\n> >> Signals and calls from the IPA should not occur after the IPA has been\n> >> put into the stopped state.\n> >>\n> >> Add assertions to catch and prevent any messages being processed after\n> >> this.\n> >>\n> >> Signed-off-by: Laurent Pinchart \n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >> .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 2 ++\n> >> utils/ipc/generators/libcamera_templates/proxy_functions.tmpl | 4 ++--\n> >> 2 files changed, 4 insertions(+), 2 deletions(-)\n> >>\n> >> diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> >> index f75b1206cad4..e3b541db4e36 100644\n> >> --- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> >> +++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> >> @@ -173,6 +173,7 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n> >> \t{%- endfor -%}\n> >> );\n> >> {% elif method|is_async %}\n> >> +\tASSERT(running_);\n> > \n> > This will fail to catch pipeline handlers calling into an IPA that is\n> > stopping, from the event handlers called by the dispatchMessages() call\n> > in 2/8. I think we need to turn running_ into a state_ variable, with\n> > three states (Running, Stopping, Stopped) and ASSERT(state_ == Running)\n> > here.\n> > \n> >> \tproxy_.invokeMethod(&ThreadProxy::{{method.mojom_name}}, ConnectionTypeQueued,\n> >> \t{%- for param in method|method_param_names -%}\n> >> \t\t{{param}}{{- \", \" if not loop.last}}\n> >> @@ -225,6 +226,7 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n> >> {% for method in interface_event.methods %}\n> >> {{proxy_funcs.func_sig(proxy_name, method, \"Thread\")}}\n> >> {\n> >> +\tASSERT(running_);\n> > \n> > Here we would ASSERT(state_ != Stopped).\n> > \n> >> \t{{method.mojom_name}}.emit({{method.parameters|params_comma_sep}});\n> >> }\n> >> \n> >> diff --git a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> >> index c2ac42fca45b..13dc8fdcab6e 100644\n> >> --- a/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> >> +++ b/utils/ipc/generators/libcamera_templates/proxy_functions.tmpl\n> >> @@ -26,12 +26,12 @@\n> >> \tif (!running_)\n> >> \t\treturn;\n> >> \n> >> -\trunning_ = false;\n> >> -\n> > \n> > \tstate_ = Stopping;\n> > \n> >> \tproxy_.invokeMethod(&ThreadProxy::stop, ConnectionTypeBlocking);\n> >> \n> >> \tthread_.exit();\n> >> \tthread_.wait();\n> >> +\n> >> +\trunning_ = false;\n> > \n> > \tstate_ = Stopped;\n> > \n> > This could go on top of this series, as this patch is already an\n> > improvement on its own.\n> \n> Yes, I think this is a worthwhile exercise, I'd prefer on top at the minute.\n\nFine with me. Could you either include a patch on top in the next\niteration, or add a \\todo comment ?\n\n> >> {%- endmacro -%}\n> >> \n> >>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 97E9ABD80C\n\tfor ;\n\tMon, 15 Mar 2021 23:18:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B8DEA68D48;\n\tTue, 16 Mar 2021 00:18:34 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A8E76602E3\n\tfor ;\n\tTue, 16 Mar 2021 00:18:32 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 116B93E7;\n\tTue, 16 Mar 2021 00:18:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iNfKlVnB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615850312;\n\tbh=EKX5nkFNcgbQR31bEYSWmfybRJBXNfTrVzrdTeQgUgI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=iNfKlVnBCRrUSsISN2+88Jt4WaGC0UsHxxVWxxth5yOsH69Lz9JGQ2pmSgqMnAos7\n\tt63Y8CaOUL8oe5ESA4jhKjb5uXYG6U2K6Bp/gNywNeqsK1rX135JNNXis/AR7A/27G\n\tzrfvV1UKSa/EGv7nsqRkyOZjgdVpn0YWukFsLU3A=","Date":"Tue, 16 Mar 2021 01:17:55 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210312054727.852622-1-kieran.bingham@ideasonboard.com>\n\t<20210312054727.852622-2-kieran.bingham@ideasonboard.com>\n\t\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v2 1/8] utils: ipc: proxy: Assert\n\tasynchronous calls execute in the running state","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]