[{"id":15585,"web_url":"https://patchwork.libcamera.org/comment/15585/","msgid":"","date":"2021-03-10T09:52:13","subject":"Re: [libcamera-devel] [PATCH] include: ipa: Remove unused\n\tdeclaration","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2021-03-10 09:29:51 +0000, Kieran Bingham wrote:\n> The struct CameraSensorInfo forward declaration is not used by\n> the ipa_interface.\n> \n> Remove it.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/ipa/ipa_interface.h | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 47f81d1d2e8f..8554613e0217 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -20,8 +20,6 @@\n> \n> namespace libcamera {\n> \n> -struct CameraSensorInfo;\n> -\n> class IPAInterface\n> {\n> public:\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C00DFBD1F1\n\tfor ;\n\tWed, 10 Mar 2021 09:52:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DC6C868AA2;\n\tWed, 10 Mar 2021 10:52:16 +0100 (CET)","from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com\n\t[IPv6:2a00:1450:4864:20::12f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8367E602ED\n\tfor ;\n\tWed, 10 Mar 2021 10:52:15 +0100 (CET)","by mail-lf1-x12f.google.com with SMTP id p21so32360432lfu.11\n\tfor ;\n\tWed, 10 Mar 2021 01:52:15 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ta1sm2728311lfd.31.2021.03.10.01.52.13\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 10 Mar 2021 01:52:14 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"VKpf6hbk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=/EM977/krR2DoTWJtGrWTuWaEIuGn9JyspRUr1mT7kY=;\n\tb=VKpf6hbk787Dz9I36pxMZ5K1jhf8itT8HwfJ4e70e55Ih2du8KTTq92pUJnaWfUw50\n\tUzMvfulHBONp6ZcOlLVKtPSm6KPFYJnZAT9N7biFGHTR5EmFAwBTZsyrZtrxHUBtOXbA\n\tPvQF8nr+W9WhhjIXyAn/3vCDCQ8gVRWozQkijByl5yTNtXsD7S3tyjjK348dIeGcA1sT\n\tieI7QRw8AMDEHxSESBWmYFuD0T3QV+TtGgJ8rymLPSx5/p6z87CYUk0QjO5Frf4mpzun\n\tFyvnIU/eofJnRsFpGji3CuTwxeWMQg9w5YUJitKcXl9nlS7UuJYB5jMJ/yAW8whLUIAC\n\tqYvA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=/EM977/krR2DoTWJtGrWTuWaEIuGn9JyspRUr1mT7kY=;\n\tb=igLfCy4hRSOTE4UAQHyy23ioFD0wE92sdEDqzMwEprF3HDPHA4TvPObvDvcPgqTCfO\n\tRpO3GxEjcU97ZfZg3qteg3jXbN45YlK1sBIfONsHMcGdwwk8y02z8btCuqqzC8ofCruV\n\tDBPSO1ontQ3tf5OV74yiYX86RaraPHhanHmKqPGVOBPtmRnk9iZAqPRvBGhI7fBiU5rG\n\tflfMsvf8Ie4eh70x6JHloLgYR7WPDFIRpieVeTGmMwBqeHFNn9th3EV5BmK3VMjkX3n+\n\t16WiRD0Ns5/Kehl3gQi3BDZXJHx1FT3sOJBl3hJv5O0wGOSQXuyoto2YM32uTgT2AKFA\n\t7PkQ==","X-Gm-Message-State":"AOAM531d0QAIa+TUTSB0DvP7LfwWWtBj8a+fxaOshFO+FssTwDJT4eAf\n\tVveJB97TsTrmTYGtBULKEne64g==","X-Google-Smtp-Source":"ABdhPJzVSYNVTc1f1JrWNHgsRVaPSPpWUkezQpC8ll5lsAJtEUaFYWhSyF0dfFqjBp8AazaQ5vv5bQ==","X-Received":"by 2002:ac2:5234:: with SMTP id\n\ti20mr1549756lfl.471.1615369934712; \n\tWed, 10 Mar 2021 01:52:14 -0800 (PST)","Date":"Wed, 10 Mar 2021 10:52:13 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Message-ID":"","References":"<20210310092951.665759-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210310092951.665759-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] include: ipa: Remove unused\n\tdeclaration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15586,"web_url":"https://patchwork.libcamera.org/comment/15586/","msgid":"<20210310095435.GA2812@pyrite.rasen.tech>","date":"2021-03-10T09:54:35","subject":"Re: [libcamera-devel] [PATCH] include: ipa: Remove unused\n\tdeclaration","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Wed, Mar 10, 2021 at 09:29:51AM +0000, Kieran Bingham wrote:\n> The struct CameraSensorInfo forward declaration is not used by\n> the ipa_interface.\n> \n\nCameraSensorInfo is in the parameters of configure() for the raspberrypi\nand rkisp1 IPA interfaces. rkisp1 doesn't seem to actually use it, but\nraspberrypi does.\n\nNow, CameraSensorInfo is defined in core.mojom, but it has the\nskipHeader tag because CameraSensorInfo is also defined in\ncamera_sensor.h, and it has lots of member functions. This means that\ncore_ipa_interface.h will not have CameraSensorInfo in it.\n\nSince we don't have a way to tell the generated files (proxy cpp+h,\nproxy worker cpp, interface header, serializer) what specific files need\nto be included, they all include ipa_interface.h, and any custom data\nstructures need to be defined in the respective mojom file.\n\nThis means that any struct defined in core.mojom that has skipHeader\nneeds to be defined in ipa_interface.h, or it has to be included by\nipa_interface.h.\n\nSo if you are to remove struct CameraSensorInfo here, then you need to\n#include \"libcamera/internal/camera_sensor.h\"\n\n\nPaul\n\n> Remove it.\n> \n> Signed-off-by: Kieran Bingham \n> ---\n> include/libcamera/ipa/ipa_interface.h | 2 --\n> 1 file changed, 2 deletions(-)\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 47f81d1d2e8f..8554613e0217 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -20,8 +20,6 @@\n> \n> namespace libcamera {\n> \n> -struct CameraSensorInfo;\n> -\n> class IPAInterface\n> {\n> public:\n> -- \n> 2.25.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4FFDCBD80C\n\tfor ;\n\tWed, 10 Mar 2021 09:54:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4FC668AA2;\n\tWed, 10 Mar 2021 10:54:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 746F4602ED\n\tfor ;\n\tWed, 10 Mar 2021 10:54:43 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D998BF3;\n\tWed, 10 Mar 2021 10:54:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"glxbTtgE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615370083;\n\tbh=B8K6kpddMiJnlVdeY1XpHwu0tGGnvcXwibvO7tJDEIE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=glxbTtgEdTzFl6rgNqfCOlnGdjyhacQ83gSjsLoHbMcB7bV9ErQBaCk0am6vbwNK6\n\t7mEitK+4I42LGR6HYBkpZQLm/ko6TRgiQChO97L6H4Bz00xphD76DBcTSi3wOlQmsG\n\tr4gTcSP2/+Asat6GOiBUUUjhr1fXGukU+6oULUTg=","Date":"Wed, 10 Mar 2021 18:54:35 +0900","From":"paul.elder@ideasonboard.com","To":"Kieran Bingham ","Message-ID":"<20210310095435.GA2812@pyrite.rasen.tech>","References":"<20210310092951.665759-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210310092951.665759-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] include: ipa: Remove unused\n\tdeclaration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15610,"web_url":"https://patchwork.libcamera.org/comment/15610/","msgid":"","date":"2021-03-12T06:33:59","subject":"Re: [libcamera-devel] [PATCH] include: ipa: Remove unused\n\tdeclaration","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Paul,\n\nOn 10/03/2021 09:54, paul.elder@ideasonboard.com wrote:\n> Hi Kieran,\n> \n> On Wed, Mar 10, 2021 at 09:29:51AM +0000, Kieran Bingham wrote:\n>> The struct CameraSensorInfo forward declaration is not used by\n>> the ipa_interface.\n>>\n> \n> CameraSensorInfo is in the parameters of configure() for the raspberrypi\n> and rkisp1 IPA interfaces. rkisp1 doesn't seem to actually use it, but\n> raspberrypi does.\n> \n\nAha, I must have been compiling IPU3 only when I looked at this.\n\n\n> Now, CameraSensorInfo is defined in core.mojom, but it has the\n> skipHeader tag because CameraSensorInfo is also defined in\n> camera_sensor.h, and it has lots of member functions. This means that\n> core_ipa_interface.h will not have CameraSensorInfo in it.\n> \n> Since we don't have a way to tell the generated files (proxy cpp+h,\n> proxy worker cpp, interface header, serializer) what specific files need\n> to be included, they all include ipa_interface.h, and any custom data\n> structures need to be defined in the respective mojom file.\n> \n> This means that any struct defined in core.mojom that has skipHeader\n> needs to be defined in ipa_interface.h, or it has to be included by\n> ipa_interface.h.\n\nHrm ... Ok - so it's a bit opaque for the reasoning in the file itself.\nIs there anyway that we could extend the pipeline specific 'include'\nstatements in the mojom files?\n\n\n> So if you are to remove struct CameraSensorInfo here, then you need to\n> #include \"libcamera/internal/camera_sensor.h\"\n\nPerhaps if we end up leaving this here we should comment the includes\n(or forward declarations) that they are needed because they are used by\nspecific pipeline handlers.\n\n> \n> \n> Paul\n> \n>> Remove it.\n>>\n>> Signed-off-by: Kieran Bingham \n>> ---\n>> include/libcamera/ipa/ipa_interface.h | 2 --\n>> 1 file changed, 2 deletions(-)\n>>\n>> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n>> index 47f81d1d2e8f..8554613e0217 100644\n>> --- a/include/libcamera/ipa/ipa_interface.h\n>> +++ b/include/libcamera/ipa/ipa_interface.h\n>> @@ -20,8 +20,6 @@\n>> \n>> namespace libcamera {\n>> \n>> -struct CameraSensorInfo;\n>> -\n>> class IPAInterface\n>> {\n>> public:\n>> -- \n>> 2.25.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A13C5BD1F1\n\tfor ;\n\tFri, 12 Mar 2021 06:34:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1376A68C6D;\n\tFri, 12 Mar 2021 07:34:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BE9B368C69\n\tfor ;\n\tFri, 12 Mar 2021 07:34:02 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2EAF68F9;\n\tFri, 12 Mar 2021 07:34:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rd3URKPS\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615530842;\n\tbh=lMvvrAAAt6CP0v7g0y4XvLHTXYAg04ePEqfD+RAvaAQ=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=rd3URKPS4/SsEBeZd5jg73S05ngOTQtR1EBqeRb+pFTeD/zZEQr8iO8hFJ0PAr9E0\n\tPxIN9vjOZJeZEQxnt1XTAL12/+/Gge2ADCDpaVq13eWmtr+mKnGK4zNTH7f+N6agpO\n\t3rWxCyEPRwx8VDK3k5L0EqwGcVLN+Xp/tfljpzJk=","To":"paul.elder@ideasonboard.com","References":"<20210310092951.665759-1-kieran.bingham@ideasonboard.com>\n\t<20210310095435.GA2812@pyrite.rasen.tech>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 12 Mar 2021 06:33:59 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210310095435.GA2812@pyrite.rasen.tech>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] include: ipa: Remove unused\n\tdeclaration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15611,"web_url":"https://patchwork.libcamera.org/comment/15611/","msgid":"<20210312075033.GB2812@pyrite.rasen.tech>","date":"2021-03-12T07:50:33","subject":"Re: [libcamera-devel] [PATCH] include: ipa: Remove unused\n\tdeclaration","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Fri, Mar 12, 2021 at 06:33:59AM +0000, Kieran Bingham wrote:\n> Hi Paul,\n> \n> On 10/03/2021 09:54, paul.elder@ideasonboard.com wrote:\n> > Hi Kieran,\n> > \n> > On Wed, Mar 10, 2021 at 09:29:51AM +0000, Kieran Bingham wrote:\n> >> The struct CameraSensorInfo forward declaration is not used by\n> >> the ipa_interface.\n> >>\n> > \n> > CameraSensorInfo is in the parameters of configure() for the raspberrypi\n> > and rkisp1 IPA interfaces. rkisp1 doesn't seem to actually use it, but\n> > raspberrypi does.\n> > \n> \n> Aha, I must have been compiling IPU3 only when I looked at this.\n> \n> \n> > Now, CameraSensorInfo is defined in core.mojom, but it has the\n> > skipHeader tag because CameraSensorInfo is also defined in\n> > camera_sensor.h, and it has lots of member functions. This means that\n> > core_ipa_interface.h will not have CameraSensorInfo in it.\n> > \n> > Since we don't have a way to tell the generated files (proxy cpp+h,\n> > proxy worker cpp, interface header, serializer) what specific files need\n> > to be included, they all include ipa_interface.h, and any custom data\n> > structures need to be defined in the respective mojom file.\n> > \n> > This means that any struct defined in core.mojom that has skipHeader\n> > needs to be defined in ipa_interface.h, or it has to be included by\n> > ipa_interface.h.\n> \n> Hrm ... Ok - so it's a bit opaque for the reasoning in the file itself.\n> Is there anyway that we could extend the pipeline specific 'include'\n> statements in the mojom files?\n\nmojo has an import statement, but it looks like the parser actually\nuses it, so no, there's no way in mojo that we can do that.\n\n> \n> > So if you are to remove struct CameraSensorInfo here, then you need to\n> > #include \"libcamera/internal/camera_sensor.h\"\n> \n> Perhaps if we end up leaving this here we should comment the includes\n> (or forward declarations) that they are needed because they are used by\n> specific pipeline handlers.\n\nI was thinking ipa_interface.h as the header file that contains all the\nlibcamera-specific structs that we alow IPA interfaces to use. iirc\nthat was the original intention too.\n\n\nPaul\n\n> > \n> >> Remove it.\n> >>\n> >> Signed-off-by: Kieran Bingham \n> >> ---\n> >> include/libcamera/ipa/ipa_interface.h | 2 --\n> >> 1 file changed, 2 deletions(-)\n> >>\n> >> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> >> index 47f81d1d2e8f..8554613e0217 100644\n> >> --- a/include/libcamera/ipa/ipa_interface.h\n> >> +++ b/include/libcamera/ipa/ipa_interface.h\n> >> @@ -20,8 +20,6 @@\n> >> \n> >> namespace libcamera {\n> >> \n> >> -struct CameraSensorInfo;\n> >> -\n> >> class IPAInterface\n> >> {\n> >> public:\n> >> -- \n> >> 2.25.1","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC29DBD80C\n\tfor ;\n\tFri, 12 Mar 2021 07:50:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B77868C6B;\n\tFri, 12 Mar 2021 08:50:42 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 70B08602ED\n\tfor ;\n\tFri, 12 Mar 2021 08:50:41 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D95E988F;\n\tFri, 12 Mar 2021 08:50:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PzjpckpD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615535441;\n\tbh=vRvYweIE0BxDTufHQfmf3Ac8cgwJElUdzxb66N7wVnU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PzjpckpDawmG28T63kBt2Q1xmq4BDW3SxHEb3nJ525Ht3xFWvKgcbflJuANtHmUkc\n\t7HHpy4MV/TVvt5DpqwNaS+KQPibu28WvbUSs+HSeCPWBuPBcMO6yS0cOwXriihT+mw\n\tBpd2oGJfKe22xWBHNHxFLarSNmaYposuH3zuc8nE=","Date":"Fri, 12 Mar 2021 16:50:33 +0900","From":"paul.elder@ideasonboard.com","To":"Kieran Bingham ","Message-ID":"<20210312075033.GB2812@pyrite.rasen.tech>","References":"<20210310092951.665759-1-kieran.bingham@ideasonboard.com>\n\t<20210310095435.GA2812@pyrite.rasen.tech>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] include: ipa: Remove unused\n\tdeclaration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15672,"web_url":"https://patchwork.libcamera.org/comment/15672/","msgid":"","date":"2021-03-14T02:47:41","subject":"Re: [libcamera-devel] [PATCH] include: ipa: Remove unused\n\tdeclaration","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Mar 12, 2021 at 04:50:33PM +0900, paul.elder@ideasonboard.com wrote:\n> On Fri, Mar 12, 2021 at 06:33:59AM +0000, Kieran Bingham wrote:\n> > On 10/03/2021 09:54, paul.elder@ideasonboard.com wrote:\n> > > On Wed, Mar 10, 2021 at 09:29:51AM +0000, Kieran Bingham wrote:\n> > >> The struct CameraSensorInfo forward declaration is not used by\n> > >> the ipa_interface.\n> > >>\n> > > \n> > > CameraSensorInfo is in the parameters of configure() for the raspberrypi\n> > > and rkisp1 IPA interfaces. rkisp1 doesn't seem to actually use it, but\n> > > raspberrypi does.\n> > \n> > Aha, I must have been compiling IPU3 only when I looked at this.\n> > \n> > > Now, CameraSensorInfo is defined in core.mojom, but it has the\n> > > skipHeader tag because CameraSensorInfo is also defined in\n> > > camera_sensor.h, and it has lots of member functions. This means that\n> > > core_ipa_interface.h will not have CameraSensorInfo in it.\n> > > \n> > > Since we don't have a way to tell the generated files (proxy cpp+h,\n> > > proxy worker cpp, interface header, serializer) what specific files need\n> > > to be included, they all include ipa_interface.h, and any custom data\n> > > structures need to be defined in the respective mojom file.\n> > > \n> > > This means that any struct defined in core.mojom that has skipHeader\n> > > needs to be defined in ipa_interface.h, or it has to be included by\n> > > ipa_interface.h.\n> > \n> > Hrm ... Ok - so it's a bit opaque for the reasoning in the file itself.\n> > Is there anyway that we could extend the pipeline specific 'include'\n> > statements in the mojom files?\n> \n> mojo has an import statement, but it looks like the parser actually\n> uses it, so no, there's no way in mojo that we can do that.\n> \n> > > So if you are to remove struct CameraSensorInfo here, then you need to\n> > > #include \"libcamera/internal/camera_sensor.h\"\n> > \n> > Perhaps if we end up leaving this here we should comment the includes\n> > (or forward declarations) that they are needed because they are used by\n> > specific pipeline handlers.\n> \n> I was thinking ipa_interface.h as the header file that contains all the\n> libcamera-specific structs that we alow IPA interfaces to use. iirc\n> that was the original intention too.\n\nMaybe adding a comment in the file to explain why the forward\ndeclarations shouldn't be dropped would avoid the same patch being\nsubmitted in 6 months by someone else (or even again by Kieran ;-)) ?\n\n> > >> Remove it.\n> > >>\n> > >> Signed-off-by: Kieran Bingham \n> > >> ---\n> > >> include/libcamera/ipa/ipa_interface.h | 2 --\n> > >> 1 file changed, 2 deletions(-)\n> > >>\n> > >> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> > >> index 47f81d1d2e8f..8554613e0217 100644\n> > >> --- a/include/libcamera/ipa/ipa_interface.h\n> > >> +++ b/include/libcamera/ipa/ipa_interface.h\n> > >> @@ -20,8 +20,6 @@\n> > >> \n> > >> namespace libcamera {\n> > >> \n> > >> -struct CameraSensorInfo;\n> > >> -\n> > >> class IPAInterface\n> > >> {\n> > >> public:","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB441BD1F1\n\tfor ;\n\tSun, 14 Mar 2021 02:48:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 378AE60850;\n\tSun, 14 Mar 2021 03:48:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6BB96084D\n\tfor ;\n\tSun, 14 Mar 2021 03:48:18 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F22D55C;\n\tSun, 14 Mar 2021 03:48:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"D3l7UafV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615690098;\n\tbh=qKqM5VMhHQdcN3QiVwT8Qm0FGpfFoTinGhjAj/ffEFE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=D3l7UafVWIKwprXlbaVrvZ+zlFZcLhu3tdBFIoe2DYw6XvnjkNwvkmSQMwiuAgS+a\n\tNbPxE8g8ED8Dv4vLgIdUWmTNemRk+PWPzegVLBXTH3fQkdK0nrspOnO0yLKUu3aAeq\n\tPaxLVuAt/GgAkAjkeOZUgA55CG6P3fP+V8Ri8Ac0=","Date":"Sun, 14 Mar 2021 04:47:41 +0200","From":"Laurent Pinchart ","To":"paul.elder@ideasonboard.com","Message-ID":"","References":"<20210310092951.665759-1-kieran.bingham@ideasonboard.com>\n\t<20210310095435.GA2812@pyrite.rasen.tech>\n\t\n\t<20210312075033.GB2812@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210312075033.GB2812@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH] include: ipa: Remove unused\n\tdeclaration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]