{"id":1154,"url":"https://patchwork.libcamera.org/api/patches/1154/?format=json","web_url":"https://patchwork.libcamera.org/patch/1154/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190503153403.8728-3-kieran.bingham@ideasonboard.com>","date":"2019-05-03T15:34:03","name":"[libcamera-devel,2/2] libcamera: pipeline: uvc: Try a default format against the device","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"340f169d3e73f54cbf68eaba527ad74d0a475503","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1154/mbox/","series":[{"id":292,"url":"https://patchwork.libcamera.org/api/series/292/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=292","date":"2019-05-03T15:34:01","name":"V4L2Device Try format support","version":1,"mbox":"https://patchwork.libcamera.org/series/292/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1154/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1154/checks/","tags":{},"headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6D0E60E6A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  3 May 2019 17:34:11 +0200 (CEST)","from Q.Home (unknown [IPv6:2a02:c7f:1887:5d00:c990:5ff4:193b:c9b8])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B1CE9530;\n\tFri,  3 May 2019 17:34:09 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556897649;\n\tbh=Ay8aKn5NsySJWlSP2RD3sYpZ8feXqk59BmPlZVhKUA4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=CvCw1qLmJtF+AjmV9m9502zWuHgocMb1N0glj4nJpwA0NQOgOoym7oENuSlEaFjHk\n\txNEN0Qs8eNbxRXu1LlmR4v/UBVoI29rDo7afKjnWTPp97MEXBmKe76Sb2Q4DC2rDGw\n\ti6zBWRjHJiM1DcSCIDCl6SttBh21IOJOwrJYqcUc=","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Date":"Fri,  3 May 2019 16:34:03 +0100","Message-Id":"<20190503153403.8728-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20190503153403.8728-1-kieran.bingham@ideasonboard.com>","References":"<20190503153403.8728-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] libcamera: pipeline: uvc: Try a\n\tdefault format against the device","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 03 May 2019 15:34:12 -0000"},"content":"We can not predict a suitable default for a UVC camera as they are so\nvaried.\n\nTake a starting point as a default configuration and test it against the\ndevice with the tryFormat call. The camera will return the closest\nsupported format from that configuration.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/uvcvideo.cpp | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\nindex 5d2f1c98fa36..9247dff33606 100644\n--- a/src/libcamera/pipeline/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo.cpp\n@@ -91,9 +91,16 @@ PipelineHandlerUVC::streamConfiguration(Camera *camera,\n \tUVCCameraData *data = cameraData(camera);\n \tCameraConfiguration config;\n \tStreamConfiguration cfg{};\n+\tV4L2DeviceFormat format;\n \n-\tcfg.pixelFormat = V4L2_PIX_FMT_YUYV;\n-\tcfg.size = { 640, 480 };\n+\tformat.fourcc = V4L2_PIX_FMT_YUYV;\n+\tformat.size = { 1920, 1080 };\n+\n+\t/* Ask the video device to confirm a suitable default configuration. */\n+\tdata->video_->tryFormat(&format);\n+\n+\tcfg.size = format.size;\n+\tcfg.pixelFormat = format.fourcc;\n \tcfg.bufferCount = 4;\n \n \tconfig[&data->stream_] = cfg;\n","prefixes":["libcamera-devel","2/2"]}