[{"id":15571,"web_url":"https://patchwork.libcamera.org/comment/15571/","msgid":"<20210309132204.bau7ary4glmeixas@uno.localdomain>","date":"2021-03-09T13:22:04","subject":"Re: [libcamera-devel] [PATCH v2 3/4] android: jpeg: exif: Fix\n\tsetGPSLocation longitude","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Ouch :)\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\nOn Tue, Mar 09, 2021 at 05:52:34PM +0900, Paul Elder wrote:\n> There was a copy-paste error that caused the latitude to be set twice and\n> the longitude never. Fix this.\n>\n> This is part of the fix that allows the following CTS test to pass:\n> - android.hardware.cts.CameraTest#testJpegExif\n>\n> Signed-off-by: Paul Elder \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Laurent Pinchart \n>\n> ---\n> No change in v2\n> ---\n> src/android/jpeg/exif.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/android/jpeg/exif.cpp b/src/android/jpeg/exif.cpp\n> index cf9e632a..628382a9 100644\n> --- a/src/android/jpeg/exif.cpp\n> +++ b/src/android/jpeg/exif.cpp\n> @@ -395,7 +395,7 @@ void Exif::setGPSLocation(const double *coords)\n> \tstd::tie(deg, min, sec) = degreesToDMS(coords[1]);\n> \tsetString(EXIF_IFD_GPS, static_cast(EXIF_TAG_GPS_LONGITUDE_REF),\n> \t\t EXIF_FORMAT_ASCII, deg >= 0 ? \"E\" : \"W\");\n> -\tsetGPSDMS(EXIF_IFD_GPS, static_cast(EXIF_TAG_GPS_LATITUDE),\n> +\tsetGPSDMS(EXIF_IFD_GPS, static_cast(EXIF_TAG_GPS_LONGITUDE),\n> \t\t std::abs(deg), min, sec);\n>\n> \tsetByte(EXIF_IFD_GPS, static_cast(EXIF_TAG_GPS_ALTITUDE_REF),\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7930ABD80C\n\tfor ;\n\tTue, 9 Mar 2021 13:21:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EF9F868A9C;\n\tTue, 9 Mar 2021 14:21:39 +0100 (CET)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F71F68A99\n\tfor ;\n\tTue, 9 Mar 2021 14:21:38 +0100 (CET)","from uno.localdomain (host-79-22-58-175.retail.telecomitalia.it\n\t[79.22.58.175]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 053DBE0011;\n\tTue, 9 Mar 2021 13:21:35 +0000 (UTC)"],"X-Originating-IP":"79.22.58.175","Date":"Tue, 9 Mar 2021 14:22:04 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20210309132204.bau7ary4glmeixas@uno.localdomain>","References":"<20210309085235.106691-1-paul.elder@ideasonboard.com>\n\t<20210309085235.106691-4-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210309085235.106691-4-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 3/4] android: jpeg: exif: Fix\n\tsetGPSLocation longitude","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]